You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "LoggingResearch (via GitHub)" <gi...@apache.org> on 2023/07/22 08:19:17 UTC
[GitHub] [storm] LoggingResearch opened a new pull request, #3554: [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(…
LoggingResearch opened a new pull request, #3554:
URL: https://github.com/apache/storm/pull/3554
## What is the purpose of the change
This PR addresses the handling of InterruptedException in the close() method of the Supervisor class. The changes include:
Adding a separate catch block for InterruptedException that is thrown by the close() method of the AsyncLocalizer class.
Logging the InterruptedException separately to ensure that the exception type and message are correctly recorded in the logs.
The motivation behind this change is to properly handle the scenario where the close() method of AsyncLocalizer is interrupted, which is a situation that was not specifically addressed in the original code. By catching and logging the InterruptedException separately, we can provide more specific information in the logs when such an event occurs.
## How was the change tested
Built storm-server. Validated logging on dev supervisor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3554:
URL: https://github.com/apache/storm/pull/3554#issuecomment-1775692654
@LoggingResearch any updates on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 closed pull request #3554: [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(…
URL: https://github.com/apache/storm/pull/3554
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3554:
URL: https://github.com/apache/storm/pull/3554#issuecomment-1667646679
Can you rebase @LoggingResearch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3554:
URL: https://github.com/apache/storm/pull/3554#discussion_r1290048620
##########
storm-server/src/main/java/org/apache/storm/daemon/supervisor/Supervisor.java:
##########
Review Comment:
Exception needs to be removed from `throws`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3938] Unhandled InterruptedException and missing log in Supervisor's close(… (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on PR #3554:
URL: https://github.com/apache/storm/pull/3554#issuecomment-1803772348
IDE reports, that this exception isn't thrown at the place the catch block was added. I am closing this PR now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org