You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2018/09/16 15:38:57 UTC
[cordova-lib] branch cross-spawn-test created (now abd060b)
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a change to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git.
at abd060b TEMP revert to default jasmine reporter
This branch includes the following new commits:
new e5695cc CB-14166: (cli) Fixed issue when install plugins on windows
new abd060b TEMP revert to default jasmine reporter
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-lib] 02/02: TEMP revert to default jasmine reporter
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit abd060b358255317ddf38df2bdd2a8af5171a4a2
Author: Raphael von der Grün <ra...@gmail.com>
AuthorDate: Sun Sep 16 17:38:37 2018 +0200
TEMP revert to default jasmine reporter
---
spec/helper.js | 14 --------------
1 file changed, 14 deletions(-)
diff --git a/spec/helper.js b/spec/helper.js
index f1a1782..351e6e4 100644
--- a/spec/helper.js
+++ b/spec/helper.js
@@ -17,17 +17,3 @@
under the License.
*/
jasmine.DEFAULT_TIMEOUT_INTERVAL = 10000;
-
-const SpecReporter = require('jasmine-spec-reporter').SpecReporter;
-
-jasmine.getEnv().clearReporters();
-jasmine.getEnv().addReporter(new SpecReporter({
- spec: {
- displayPending: true,
- displayDuration: true
- },
- summary: {
- displayDuration: true,
- displayStacktrace: true
- }
-}));
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-lib] 01/02: CB-14166: (cli) Fixed issue when install
plugins on windows
Posted by ra...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
raphinesse pushed a commit to branch cross-spawn-test
in repository https://gitbox.apache.org/repos/asf/cordova-lib.git
commit e5695ccdd07312785b4d9036f6b01b8aa55d13ee
Author: Almir Kadric <gi...@almirkadric.com>
AuthorDate: Tue Jul 17 03:23:57 2018 +0900
CB-14166: (cli) Fixed issue when install plugins on windows
The npm package name is already wrapped in quotes to prevent special
characters from being execute. However the additional win32 code was
further injecting quotes around the version causing npm to return a
EINVALIDTAGNAME error. The win32 code is redundant and seems to not
be required.
---
src/plugman/fetch.js | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/src/plugman/fetch.js b/src/plugman/fetch.js
index d52bae7..2ae1b79 100644
--- a/src/plugman/fetch.js
+++ b/src/plugman/fetch.js
@@ -120,7 +120,6 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
var parsedSpec = pluginSpec.parse(plugin_src);
var P;
var skipCopyingPlugin;
- var specContainsSpecialCharacters = false;
plugin_dir = path.join(plugins_dir, parsedSpec.id);
// if the plugin has already been fetched, use it.
if (fs.existsSync(plugin_dir)) {
@@ -135,16 +134,7 @@ function fetchPlugin (plugin_src, plugins_dir, options) {
projectRoot = options.projectRoot;
}
- if (process.platform === 'win32' && parsedSpec.version) {
- var windowsShellSpecialCharacters = ['&', '\\', '<', '>', '^', '|'];
- specContainsSpecialCharacters = windowsShellSpecialCharacters.some(function (character) {
- return parsedSpec.version.indexOf(character);
- });
- }
-
- var fetchPluginSrc = specContainsSpecialCharacters ?
- parsedSpec.package + '@"' + parsedSpec.version + '"' : plugin_src;
- P = fetch(fetchPluginSrc, projectRoot, options);
+ P = fetch(plugin_src, projectRoot, options);
skipCopyingPlugin = false;
}
return P
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org