You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2022/07/05 03:19:17 UTC

[GitHub] [ozone] JacksonYao287 commented on a diff in pull request #3570: HDDS-6127. file checksum to support both CRC32 and CRC32C.

JacksonYao287 commented on code in PR #3570:
URL: https://github.com/apache/ozone/pull/3570#discussion_r913353910


##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/checksum/BaseFileChecksumHelper.java:
##########
@@ -242,8 +253,29 @@ private FileChecksum makeMd5CrcResult() {
     //compute file MD5
     final MD5Hash fileMD5 = MD5Hash.digest(getBlockChecksumBuf().getData());
     // assume CRC32 for now

Review Comment:
   NIT: since we have CRC32C, remove this comment



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org