[jira] [Commented] (FLINK-3377) Remove final flag from ResultPartitionWriter class

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15139016#comment-15139016 ] 

ASF GitHub Bot commented on FLINK-3377:
---------------------------------------

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/1609

    [FLINK-3377] Remove final flag from ResultPartitionWriter class

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 3377_partitionwriter_final

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1609.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1609
    
----
commit 47670f5812c255a3cb992a0a2f396330ed5c519d
Author: zentol <s....@web.de>
Date:   2016-02-09T14:51:11Z

    [FLINK-3377] Remove final flag from ResultPartitionWriter class

----


> Remove final flag from ResultPartitionWriter class
> --------------------------------------------------
>
>                 Key: FLINK-3377
>                 URL: https://issues.apache.org/jira/browse/FLINK-3377
>             Project: Flink
>          Issue Type: Wish
>          Components: Distributed Runtime
>    Affects Versions: 0.10.1
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.00
>
>
> The final flag on the org.apache.flink.runtime.io.network.api.writer.ResultPartitionWriter class is causing issues for me.
> The flag requires me to run a test I'm working on with a @RunWith(PowerMockRunner.class) annotation so that i can use @PrepareForTest({ResultPartitionWriter.class}).
> But it breaks my TemporaryFolder annotated with @ClassRule. (apart from that there also was a classloader issue, but i could resolve that)
> To me these seem like unnecessary problems, as such i propose removing the final flag.
> The 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)