You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by njayaram2 <gi...@git.apache.org> on 2018/06/27 18:43:41 UTC
[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF
GitHub user njayaram2 opened a pull request:
https://github.com/apache/madlib/pull/283
Bugfix: Fix failing dev check in CRF
This commit has the following changes:
- A couple of dev check files in CRF did not have the label table creation
in it. But the label table was consumed by one of the queries that led
to dev-check failure.
- Run dev check on Jenkins build instead of install check.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/madlib/madlib bugfix/crf-dev-check
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/madlib/pull/283.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #283
----
commit deb206b7d1c1e7ce87d6e33c7a1dff91b3adb82b
Author: Nandish Jayaram <nj...@...>
Date: 2018-06-27T18:25:46Z
Bugfix: Fix failing dev check in CRF
This commit has the following changes:
- A couple of dev check files in CRF did not have the label table creation
in it. But the label table was consumed by one of the queries that led
to dev-check failure.
- Run dev check on Jenkins build instead of install check.
----
---
[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF
Posted by kaknikhil <gi...@git.apache.org>.
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/283#discussion_r198641216
--- Diff: src/ports/postgres/modules/crf/test/crf_train_large.sql_in ---
@@ -234,26 +234,40 @@ INSERT INTO train_new_segmenttbl VALUES
(30, 7, 'years', 13, 31),
(31, 7, '.', 44, 31);
-CREATE TABLE train_new_regex(pattern text,name text);
+CREATE TABLE train_new_regex(pattern text,name text);
INSERT INTO train_new_regex VALUES
-('^[A-Z][a-z]+$','InitCapital'), ('^[A-Z]+$','isAllCapital'),
+ ('^[A-Z][a-z]+$','InitCapital'), ('^[A-Z]+$','isAllCapital'),
('^.*[0-9]+.*$','containsDigit'),('^.+[.]$','endsWithDot'),
('^.+[,]$','endsWithComma'), ('^.+er$','endsWithER'),
('^.+est$','endsWithEst'), ('^.+ed$','endsWithED'),
('^.+s$','endsWithS'), ('^.+ing$','endsWithIng'),
('^.+ly$','endsWithly'), ('^.+-.+$','isDashSeparatedWords'),
('^.*@.*$','isEmailId');
- analyze train_new_regex;
+analyze train_new_regex;
- SELECT crf_train_fgen('train_new_segmenttbl', 'train_new_regex', 'crf_label', 'train_new_dictionary', 'train_new_featuretbl','train_new_featureset');
+CREATE TABLE crf_label_new (id integer,label character varying);
--- End diff --
The two files `crf_test_small.sql_in` and `crf_train_large.sql_in` have different indentation. Can we make them consistent
---
[GitHub] madlib issue #283: Bugfix: Fix failing dev check in CRF
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/283
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/525/
---
[GitHub] madlib issue #283: Bugfix: Fix failing dev check in CRF
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/madlib/pull/283
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/madlib-pr-build/526/
---
[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/madlib/pull/283
---
[GitHub] madlib pull request #283: Bugfix: Fix failing dev check in CRF
Posted by kaknikhil <gi...@git.apache.org>.
Github user kaknikhil commented on a diff in the pull request:
https://github.com/apache/madlib/pull/283#discussion_r198644242
--- Diff: src/ports/postgres/modules/crf/test/crf_test_small.sql_in ---
@@ -90,7 +90,7 @@
(18,'PRP$'),(19,'RB'), (20,'RBR'), (21,'RBS'), (22,'RP'), (23,'SYM'), (24,'TO'), (25,'UH'), (26,'VB'),
(27,'VBD'), (28,'VBG'),(29,'VBN'), (30,'VBP'), (31,'VBZ'),(32,'WDT'), (33,'WP'), (34,'WP$'),(35,'WRB'),
(36,'$'), (37,'#'), (38,''''''), (39,'``'), (40,'('), (41,')'), (42,','), (43,'.'), (44,':');
- analyze crf_label;
+ analyze test_crf_label;
--- End diff --
Assuming that the table `crf_label` doesn't exist, why wasn't crf install check always red?
---
[GitHub] madlib issue #283: Bugfix: Fix failing dev check in CRF
Posted by njayaram2 <gi...@git.apache.org>.
Github user njayaram2 commented on the issue:
https://github.com/apache/madlib/pull/283
Thank you for the comments @kaknikhil . I moved out the jenkins build script to a different commit.
---