You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2018/07/31 18:22:57 UTC

[GitHub] DaanHoogland commented on a change in pull request #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…

DaanHoogland commented on a change in pull request #2776: Issue 2774: Changed the implementation of isVolumeOnManagedStorage(VolumeInfo) to…
URL: https://github.com/apache/cloudstack/pull/2776#discussion_r206634564
 
 

 ##########
 File path: engine/storage/datamotion/src/org/apache/cloudstack/storage/motion/StorageSystemDataMotionStrategy.java
 ##########
 @@ -196,10 +196,16 @@ public StrategyPriority canHandle(DataObject srcData, DataObject destData) {
     }
 
     private boolean isVolumeOnManagedStorage(VolumeInfo volumeInfo) {
 
 Review comment:
   yes, I am. I am struggling with the large number of injects but I think the canHandle() should be tested indeed, as the error was because the strategy returned a wrong priority from that call.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services