You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Lars Hofhansl (Created) (JIRA)" <ji...@apache.org> on 2011/10/27 00:03:32 UTC
[jira] [Created] (HBASE-4682) Support deleted rows using
Import/Export
Support deleted rows using Import/Export
----------------------------------------
Key: HBASE-4682
URL: https://issues.apache.org/jira/browse/HBASE-4682
Project: HBase
Issue Type: Sub-task
Components: mapreduce
Reporter: Lars Hofhansl
Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165606#comment-13165606 ]
Lars Hofhansl commented on HBASE-4682:
--------------------------------------
Heh... It takes 46 secs on my machine. Can make it large, too.
As for the messy-ness... The problem is that Delete has strange rules as what you can do in a single Delete (when you add a deleteFamily all prior deleteColumn(s) are removed, etc). So deletes have to be written one-by-one to be correct (that is also why I added the Delete(kv) constructor, rather than an delete(kv) method).
A put, on the other hand, allows adding all put-related KVs of the same row into a single Put object. That's why delete-kvs are issued immediately, and put-kvs are collected into a single Put (that's also what the existing code does).
It is possible that particular row only has delete markers, so the Put is created when needed, and only written to the HBase when there were any put-kvs.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Resolution: Fixed
Hadoop Flags: Reviewed
Status: Resolved (was: Patch Available)
Committed to trunk
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Status: Patch Available (was: Open)
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165631#comment-13165631 ]
Hadoop QA commented on HBASE-4682:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506658/4682-v2.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -160 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 74 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/476//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/476//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/476//console
This message is automatically generated.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Ted Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165048#comment-13165048 ]
Ted Yu commented on HBASE-4682:
-------------------------------
In the new Delete ctor, row key should be included in the IOE.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165589#comment-13165589 ]
stack commented on HBASE-4682:
------------------------------
Nice test. For sure its medium sized? Takes < 50 seconds?
This bit seems a little messy:
{code}
- put.add(kv);
+ if (kv.isDelete()) {
+ context.write(key, new Delete(kv));
+ } else {
+ if (put == null) {
+ put = new Put(key.get());
+ }
+ put.add(kv);
+ }
}
- return put;
+ if (put != null) {
+ context.write(key, put);
+ }
{code}
We write the context if its a delete but if a put, we make a put instance and then do the context.write later... can they not both do context.write in same place or share the context.write invocation (if context.write takes a Mutation).
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165060#comment-13165060 ]
Lars Hofhansl commented on HBASE-4682:
--------------------------------------
@Ted: Will add that. Also instead of ignoring TableInputFormat.SCAN_COLUMN_FAMILY when keep deleted cells is specified, I should probably just let is pass, and have it fail with a IOException soon after.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165971#comment-13165971 ]
Hudson commented on HBASE-4682:
-------------------------------
Integrated in HBase-TRUNK #2532 (See [https://builds.apache.org/job/HBase-TRUNK/2532/])
HBASE-4682 Support deleted rows using Import/Export (Lars H)
larsh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Export.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166173#comment-13166173 ]
Hudson commented on HBASE-4682:
-------------------------------
Integrated in HBase-TRUNK-security #26 (See [https://builds.apache.org/job/HBase-TRUNK-security/26/])
HBASE-4682 Support deleted rows using Import/Export (Lars H)
larsh :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Delete.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/client/Scan.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Export.java
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/mapreduce/Import.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/mapreduce/TestImportExport.java
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Affects Version/s: 0.94.0
Status: Patch Available (was: Open)
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Status: Open (was: Patch Available)
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165458#comment-13165458 ]
Lars Hofhansl commented on HBASE-4682:
--------------------------------------
I did some more testing with this and everything works fine.
Apparently there are no tests for import/export anywhere, so I am adding a test for existing functionality as well.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165057#comment-13165057 ]
Hadoop QA commented on HBASE-4682:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12506578/4682-v1.txt
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
-1 javadoc. The javadoc tool appears to have generated -160 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 74 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed unit tests in .
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/474//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/474//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/474//console
This message is automatically generated.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "stack (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165621#comment-13165621 ]
stack commented on HBASE-4682:
------------------------------
Thanks for explaination. +1 on commit.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Description:
Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
All the building blocks are there.
was:
Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
All the building blocks are there.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Attachment: 4682-v1.txt
Straight forward patch.
I found there's actually a bug in the Scan(Scan) constructor, which did not copy the attributes passed Scan's.
Will add some tests soon, but want to get a test run in tonight.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164859#comment-13164859 ]
Lars Hofhansl commented on HBASE-4682:
--------------------------------------
Have a patch for this in place, will test a bit. Change will be simple (all the heavy lifting is in parent).
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Reporter: Lars Hofhansl
> Fix For: 0.94.0
>
>
> Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl updated HBASE-4682:
---------------------------------
Attachment: 4682-v2.txt
Addressed Ted's comment.
Added an Import/Export test (there were NO tests for Import/Export before)
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165679#comment-13165679 ]
Lars Hofhansl commented on HBASE-4682:
--------------------------------------
Thanks for the review stack (I added comments to the pieces in Import)
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt, 4682-v2.txt
>
>
> Parent allows keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (HBASE-4682) Support deleted rows using
Import/Export
Posted by "Lars Hofhansl (Assigned) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Lars Hofhansl reassigned HBASE-4682:
------------------------------------
Assignee: Lars Hofhansl
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
>
> Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (HBASE-4682) Support deleted rows
using Import/Export
Posted by "Lars Hofhansl (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-4682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165029#comment-13165029 ]
Lars Hofhansl edited comment on HBASE-4682 at 12/8/11 6:47 AM:
---------------------------------------------------------------
Straight forward patch.
I found there's actually a bug in the Scan(Scan) constructor, which did not copy the passed Scan's attributes.
Will add some tests soon, but want to get a test run in tonight.
was (Author: lhofhansl):
Straight forward patch.
I found there's actually a bug in the Scan(Scan) constructor, which did not copy the attributes passed Scan's.
Will add some tests soon, but want to get a test run in tonight.
> Support deleted rows using Import/Export
> ----------------------------------------
>
> Key: HBASE-4682
> URL: https://issues.apache.org/jira/browse/HBASE-4682
> Project: HBase
> Issue Type: Sub-task
> Components: mapreduce
> Affects Versions: 0.94.0
> Reporter: Lars Hofhansl
> Assignee: Lars Hofhansl
> Fix For: 0.94.0
>
> Attachments: 4682-v1.txt
>
>
> Parent allow keeping deleted rows around. Would be nice if those could be exported and imported as well.
> All the building blocks are there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira