[GitHub] [superset] craig-rueda commented on a change in pull request #17757: feat: Authorizing guest access to embedded dashboards

[GitBox <gi...@apache.org>]

craig-rueda commented on a change in pull request #17757:
URL: https://github.com/apache/superset/pull/17757#discussion_r789927130



##########
File path: superset/security/manager.py
##########
@@ -1289,33 +1308,60 @@ def get_guest_user_from_request(self, req: Request) -> Optional[GuestUser]:
 
         try:
             token = self.parse_jwt_guest_token(raw_token)
+            if token.get("user") is None:

Review comment:
       Can you add tests to cover these cases?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org