You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/01/27 08:48:49 UTC

[GitHub] [dubbo] jessin20161124 opened a new pull request #9637: only process context event of original application context

jessin20161124 opened a new pull request #9637:
URL: https://github.com/apache/dubbo/pull/9637

## What is the purpose of the change
The DubboDeployApplicationListener currently processes all applicationContext event from current ApplicationContext and all its child applicationContext. It will cause duplicate deployment and ApplicationDeployListener will receive multi duplicate vents. The most bad is that, when the application uses hot load of child spring context, and destroys the child spring context at runtime, the dubbo infrastructure will be destroyed once receives the child spring context's ContextClosedEvent.

## Brief changelog
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboConfigApplicationListener.java
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/context/DubboDeployApplicationListener.java

## Verifying this change

see the case code in https://github.com/jessin20161124/dubbo_demo.

1. java -Dspring.profiles.active=provider -Dserver.port=9999 -jar target/dubbo_demo-0.0.1-SNAPSHOT.jar
2. curl http://localhost:9999/practice/testGetSubApp
3. curl http://localhost:9999/practice/testDestroySubApp
4. watch the application log, the dubbo application runs normally.

## Checklist
- [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature.
- [ ] GitHub Actions works fine on your own branch.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org