You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Edward Capriolo <ed...@gmail.com> on 2013/10/01 22:15:00 UTC
Re: did you always have to log in to phabricator
I do not know what to say on this, other then we are stuck between a rock
and a hard place. I would say we should just stop using fabricator all
together, but then again we already have two tickets opened with
ASF-infrastructure not going anywhere for months (moving our site to a CMS,
fixing the broken confluence to wiki publishing) so moving the process
officially to some ASF review board type thing might have similar issues.
What we might have to do is host phabricator ourselves like we are hosting
our unit testing ourselves. I do not know what else to say on this.
On Sat, Sep 28, 2013 at 8:55 PM, Sean Busbey <bu...@cloudera.com> wrote:
> Bump. Any update on this?
>
>
> On Tue, Sep 17, 2013 at 12:41 PM, Edward Capriolo <edlinuxguru@gmail.com
> >wrote:
>
> > I do not like this. It is inconvenience when using a mobile device, but
> > more importantly it does not seem very transparent to our end users. For
> > example, a user is browsing jira they may want to review the code only on
> > review board (not yet attached to the issue), they should not be forced
> to
> > "sign up" to help in the process.
> >
> > Would anyone from facebook care to chime in here? I think we all like
> > fabricator for the most part. Our docs suggest this fabricator is our
> > de-facto review system. As an ASF project I do not think requiring a
> login
> > on some external service even to review a jira is correct.
> >
> >
> > On Tue, Sep 17, 2013 at 12:27 PM, Xuefu Zhang <xz...@cloudera.com>
> wrote:
> >
> > > Yeah. I used to be able to view w/o login, but now I am not.
> > >
> > >
> > > On Tue, Sep 17, 2013 at 7:27 AM, Brock Noland <br...@cloudera.com>
> > wrote:
> > >
> > > > Personally I prefer Review Board.
> > > >
> > > > On Tue, Sep 17, 2013 at 8:31 AM, Edward Capriolo <
> > edlinuxguru@gmail.com>
> > > > wrote:
> > > > > I never remeber having to log into phabricator to view a patch. Has
> > > this
> > > > > changed recently? I believe that having to create an external
> account
> > > to
> > > > > view a patch in progress is not something we should be doing.
> > > >
> > > >
> > > >
> > > > --
> > > > Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org
> > > >
> > >
> >
>
>
>
> --
> Sean
>
Re: did you always have to log in to phabricator
Posted by Edward Capriolo <ed...@gmail.com>.
Previously we all agreed that the poster of the patch could chose the
review board of their choice. When this was agreed upon review board did
not require a login to view a review.
I will likely start a PMC vote on this issue soon. If the vote passes we
will remove mention of phabricator from the hive documentation, and not
accept patches for review not posted on Apache's review board.
That being said, if you are invested in phabricator as our review system,
(ring ring committers that put this system into place) you had better get
the wheels moving on removing the required password.
On Tue, Oct 1, 2013 at 4:27 PM, Sean Busbey <bu...@cloudera.com> wrote:
> Well, the ASF review board does currently work. Our dev guide suggests that
> either it or fabricator are fine. Generally all of my own jira submissions
> include a RB, so I'm fairly confident it works (for the features that RB
> has generally).
>
> I presume something as strong as a statement of "we're going to stop using
> fabrictor" as a project would require a PMC vote?
>
> -Sean
>
>
> On Tue, Oct 1, 2013 at 1:15 PM, Edward Capriolo <edlinuxguru@gmail.com
> >wrote:
>
> > I do not know what to say on this, other then we are stuck between a rock
> > and a hard place. I would say we should just stop using fabricator all
> > together, but then again we already have two tickets opened with
> > ASF-infrastructure not going anywhere for months (moving our site to a
> CMS,
> > fixing the broken confluence to wiki publishing) so moving the process
> > officially to some ASF review board type thing might have similar issues.
> >
> > What we might have to do is host phabricator ourselves like we are
> hosting
> > our unit testing ourselves. I do not know what else to say on this.
> >
> >
> > On Sat, Sep 28, 2013 at 8:55 PM, Sean Busbey <bu...@cloudera.com>
> wrote:
> >
> > > Bump. Any update on this?
> > >
> > >
> > > On Tue, Sep 17, 2013 at 12:41 PM, Edward Capriolo <
> edlinuxguru@gmail.com
> > > >wrote:
> > >
> > > > I do not like this. It is inconvenience when using a mobile device,
> but
> > > > more importantly it does not seem very transparent to our end users.
> > For
> > > > example, a user is browsing jira they may want to review the code
> only
> > on
> > > > review board (not yet attached to the issue), they should not be
> forced
> > > to
> > > > "sign up" to help in the process.
> > > >
> > > > Would anyone from facebook care to chime in here? I think we all like
> > > > fabricator for the most part. Our docs suggest this fabricator is our
> > > > de-facto review system. As an ASF project I do not think requiring a
> > > login
> > > > on some external service even to review a jira is correct.
> > > >
> > > >
> > > > On Tue, Sep 17, 2013 at 12:27 PM, Xuefu Zhang <xz...@cloudera.com>
> > > wrote:
> > > >
> > > > > Yeah. I used to be able to view w/o login, but now I am not.
> > > > >
> > > > >
> > > > > On Tue, Sep 17, 2013 at 7:27 AM, Brock Noland <br...@cloudera.com>
> > > > wrote:
> > > > >
> > > > > > Personally I prefer Review Board.
> > > > > >
> > > > > > On Tue, Sep 17, 2013 at 8:31 AM, Edward Capriolo <
> > > > edlinuxguru@gmail.com>
> > > > > > wrote:
> > > > > > > I never remeber having to log into phabricator to view a patch.
> > Has
> > > > > this
> > > > > > > changed recently? I believe that having to create an external
> > > account
> > > > > to
> > > > > > > view a patch in progress is not something we should be doing.
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Apache MRUnit - Unit testing MapReduce -
> http://mrunit.apache.org
> > > > > >
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Sean
> > >
> >
>
>
>
> --
> Sean
>
Re: did you always have to log in to phabricator
Posted by Sean Busbey <bu...@cloudera.com>.
Well, the ASF review board does currently work. Our dev guide suggests that
either it or fabricator are fine. Generally all of my own jira submissions
include a RB, so I'm fairly confident it works (for the features that RB
has generally).
I presume something as strong as a statement of "we're going to stop using
fabrictor" as a project would require a PMC vote?
-Sean
On Tue, Oct 1, 2013 at 1:15 PM, Edward Capriolo <ed...@gmail.com>wrote:
> I do not know what to say on this, other then we are stuck between a rock
> and a hard place. I would say we should just stop using fabricator all
> together, but then again we already have two tickets opened with
> ASF-infrastructure not going anywhere for months (moving our site to a CMS,
> fixing the broken confluence to wiki publishing) so moving the process
> officially to some ASF review board type thing might have similar issues.
>
> What we might have to do is host phabricator ourselves like we are hosting
> our unit testing ourselves. I do not know what else to say on this.
>
>
> On Sat, Sep 28, 2013 at 8:55 PM, Sean Busbey <bu...@cloudera.com> wrote:
>
> > Bump. Any update on this?
> >
> >
> > On Tue, Sep 17, 2013 at 12:41 PM, Edward Capriolo <edlinuxguru@gmail.com
> > >wrote:
> >
> > > I do not like this. It is inconvenience when using a mobile device, but
> > > more importantly it does not seem very transparent to our end users.
> For
> > > example, a user is browsing jira they may want to review the code only
> on
> > > review board (not yet attached to the issue), they should not be forced
> > to
> > > "sign up" to help in the process.
> > >
> > > Would anyone from facebook care to chime in here? I think we all like
> > > fabricator for the most part. Our docs suggest this fabricator is our
> > > de-facto review system. As an ASF project I do not think requiring a
> > login
> > > on some external service even to review a jira is correct.
> > >
> > >
> > > On Tue, Sep 17, 2013 at 12:27 PM, Xuefu Zhang <xz...@cloudera.com>
> > wrote:
> > >
> > > > Yeah. I used to be able to view w/o login, but now I am not.
> > > >
> > > >
> > > > On Tue, Sep 17, 2013 at 7:27 AM, Brock Noland <br...@cloudera.com>
> > > wrote:
> > > >
> > > > > Personally I prefer Review Board.
> > > > >
> > > > > On Tue, Sep 17, 2013 at 8:31 AM, Edward Capriolo <
> > > edlinuxguru@gmail.com>
> > > > > wrote:
> > > > > > I never remeber having to log into phabricator to view a patch.
> Has
> > > > this
> > > > > > changed recently? I believe that having to create an external
> > account
> > > > to
> > > > > > view a patch in progress is not something we should be doing.
> > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Apache MRUnit - Unit testing MapReduce - http://mrunit.apache.org
> > > > >
> > > >
> > >
> >
> >
> >
> > --
> > Sean
> >
>
--
Sean