You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/09/27 11:51:52 UTC
[GitHub] [commons-lang] elharo commented on a diff in pull request #1114: Add TypedEqualsBuilder class and test
elharo commented on code in PR #1114:
URL: https://github.com/apache/commons-lang/pull/1114#discussion_r1338483094
##########
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java:
##########
@@ -450,6 +450,15 @@ public static boolean reflectionEquals(final Object lhs, final Object rhs, final
.isEquals();
}
+ /**
+ * Indicates if an early append method leave should be done
Review Comment:
unclear, rephrase
##########
src/test/java/org/apache/commons/lang3/builder/TypedEqualsBuilderTest.java:
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3.builder;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class TypedEqualsBuilderTest {
+
+ @Test
+ void test_complete_equals() {
+ TestObject testObject1 = new TestObject(1, 2);
+ TestObject testObject2 = new TestObject(1, 3);
+ TestObject testObject3 = new TestObject(1, 2);
+
+ assertEquals(testObject1, testObject1);
+ assertNotEquals(testObject1, testObject2);
+ assertNotEquals(testObject2, testObject1);
+
+ assertEquals(Boolean.TRUE,
Review Comment:
probably use assertTrue and assertFalse, unless perhaps there's some auto-boxing detail I'm missing
##########
src/main/java/org/apache/commons/lang3/builder/EqualsBuilder.java:
##########
@@ -198,7 +198,7 @@ private static void unregister(final Object lhs, final Object rhs) {
* If the fields tested are equals.
Review Comment:
equals --> equal
##########
src/test/java/org/apache/commons/lang3/builder/TypedEqualsBuilderTest.java:
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.commons.lang3.builder;
+
+import org.junit.jupiter.api.Test;
+
+import static org.junit.jupiter.api.Assertions.*;
+
+class TypedEqualsBuilderTest {
+
+ @Test
+ void test_complete_equals() {
+ TestObject testObject1 = new TestObject(1, 2);
+ TestObject testObject2 = new TestObject(1, 3);
+ TestObject testObject3 = new TestObject(1, 2);
+
+ assertEquals(testObject1, testObject1);
+ assertNotEquals(testObject1, testObject2);
+ assertNotEquals(testObject2, testObject1);
+
+ assertEquals(Boolean.TRUE,
+ new TypedEqualsBuilder<>(testObject1, testObject2)
+ .append(TestObject::getA)
+ .isEquals());
+ assertEquals(Boolean.TRUE,
+ new TypedEqualsBuilder<>(testObject1, testObject3)
+ .append(TestObject::getA)
+ .append(TestObject::getB)
+ .isEquals());
+ assertEquals(Boolean.FALSE,
+ new TypedEqualsBuilder<>(testObject1, testObject2)
+ .append(TestObject::getA)
+ .append(TestObject::getB)
+ .isEquals());
+ assertEquals(Boolean.FALSE,
+ new TypedEqualsBuilder<>(testObject2, testObject1)
+ .append(TestObject::getA)
+ .append(TestObject::getB)
+ .isEquals());
+ assertEquals(Boolean.FALSE,
+ new TypedEqualsBuilder<>(testObject1, null)
+ .append(TestObject::getA)
+ .isEquals());
+ assertEquals(Boolean.FALSE,
+ new TypedEqualsBuilder<>(testObject1, "")
+ .append(TestObject::getA)
+ .isEquals());
+ }
+
+ static class TestObject {
Review Comment:
private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org