[jira] [Commented] (YARN-6935) ResourceProfilesManagerImpl.parseResource() has no need of the key parameter

["Manikandan R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16120209#comment-16120209 ] 

Manikandan R commented on YARN-6935:
------------------------------------

Attached patch for review.

> ResourceProfilesManagerImpl.parseResource() has no need of the key parameter
> ----------------------------------------------------------------------------
>
>                 Key: YARN-6935
>                 URL: https://issues.apache.org/jira/browse/YARN-6935
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>          Components: resourcemanager
>    Affects Versions: YARN-3926
>            Reporter: Daniel Templeton
>            Assignee: Manikandan R
>              Labels: newbie
>         Attachments: YARN-6935-YARN-3926.001.patch
>
>
> The {{key}} parameter is the name of the resource profile being parsed, which is irrelevant to parsing the {{value}} as a {{Resource}} and hence is unused.  It should be removed, and {{value}} should be renamed to something more descriptive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org