You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/30 04:37:12 UTC
[GitHub] [cloudstack] harikrishna-patnala commented on a change in pull request #4437: [Bug fix] VMware: Fix for SSVM recreation on deployasis systemVM templates
harikrishna-patnala commented on a change in pull request #4437:
URL: https://github.com/apache/cloudstack/pull/4437#discussion_r514835332
##########
File path: engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java
##########
@@ -824,7 +824,7 @@ private DiskProfile allocateTemplatedVolume(Type type, String name, DiskOffering
int volumesNumber = 1;
List<DatadiskTO> templateAsIsDisks = null;
String configurationId = null;
- if (template.isDeployAsIs()) {
+ if (template.isDeployAsIs() && vm.getType() != VirtualMachine.Type.SecondaryStorageVm) {
Review comment:
do we have to also keep a check for other system VMs ? or pass this condition only for user VMs ? I see a problem when CPVM is tried to recreate when SSVM is not there, we might get into same issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org