You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by markus-h <gi...@git.apache.org> on 2014/07/07 12:54:51 UTC
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
GitHub user markus-h opened a pull request:
https://github.com/apache/incubator-flink/pull/61
[FLINK-984] Extension of the API for distinct for Key Expressions, additional testcases
I extended the API for the distinct operator to also work on POJOs using either key expressions or by using plain distinct() selecting all public fields.
I also added some more testcases for the operator.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markus-h/incubator-flink distinct_extension
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-flink/pull/61.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #61
----
commit dd7aa11b1df58c316c420ffccfe704afdb4f8ed0
Author: Markus Holzemer <ma...@gmx.de>
Date: 2014-07-01T12:27:56Z
Extension of the API for distinct for Key Expressions, additional testcases
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-64377332
I've added key expressions for distinct() as part of my pull request (See: https://github.com/apache/incubator-flink/blob/master/flink-java/src/main/java/org/apache/flink/api/java/DataSet.java#L449)
I can manually merge the pull request and add the additional tests to the system.
I'm going to assign the JIRA to myself to remember that I'm going to do this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-64371088
@rmetzger Can you have a look and see whether this fits into your Pojo work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by markus-h <gi...@git.apache.org>.
Github user markus-h closed the pull request at:
https://github.com/apache/incubator-flink/pull/61
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-64699176
Never hurts to have the tests. Are the failing tests making different assumptions, causing them to fail, or is some piece of functionality still missing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-64692595
Is this PR subsumed by FLINK-984 and can be closed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-64693055
The POJO-related parts are already implemented in the current master. Do you think the compiler tests in this pull request are relevant? I've started porting them to our current master but got some failing tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-flink pull request: [FLINK-984] Extension of the API for...
Posted by rmetzger <gi...@git.apache.org>.
Github user rmetzger commented on the pull request:
https://github.com/apache/incubator-flink/pull/61#issuecomment-66480629
@markus-h: can you close this pull request? The changes have been merged as part of https://github.com/apache/incubator-flink/pull/245.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---