You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/09/17 08:43:50 UTC
[GitHub] [incubator-nuttx] jrosberg opened a new pull request #4569: MPFS emmcsd
jrosberg opened a new pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569
## Summary
mpfs: add emmcsd driver
## Impact
This adds the emmcsd driver for the Polarfire Icicle kit.
## Testing
The driver has been tested with several SD-cards, such as:
- Kingston 32 GB SDS2 Canvas Select Plus
- Kingston MicroSD Canvas Select Plus
- Sandisk Extreme PRO 32 GB
- Transcend 8 GB MicroSD
The internal eMMC hasn't been tested comprehensively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jrosberg edited a comment on pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
jrosberg edited a comment on pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569#issuecomment-922278642
@acassis done. note that the problematic file was not part of original patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jrosberg commented on pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
jrosberg commented on pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569#issuecomment-922251009
@acassis Do you want me to add fix for that on this PR: %d -> %zu
Is it better to do own PR for that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jrosberg commented on pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
jrosberg commented on pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569#issuecomment-922278642
@acassis done. note that the problematic file was not part or original patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis merged pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
acassis merged pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis edited a comment on pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
acassis edited a comment on pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569#issuecomment-922273815
> @acassis Do you want me to add fix for that on this PR: %d -> %zu
> Is it better to do own PR for that?
Yes, please fix it. You don't need to create a new PR, just create a commit to fix it.
If you prefer you can squash the new commit into original commit and push forced, it also works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569#issuecomment-922273815
> @acassis Do you want me to add fix for that on this PR: %d -> %zu
> Is it better to do own PR for that?
Yes, please fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #4569: MPFS emmcsd
Posted by GitBox <gi...@apache.org>.
acassis commented on pull request #4569:
URL: https://github.com/apache/incubator-nuttx/pull/4569#issuecomment-921774283
@jrosberg it is failing because this warning:
```
Building NuttX...
In file included from mmcsd/mmcsd_spi.c:39:
mmcsd/mmcsd_spi.c: In function 'mmcsd_read':
Error: mmcsd/mmcsd_spi.c:1300:9: error: format '%d' expects argument of type 'int', but argument 3 has type 'size_t' {aka 'long unsigned int'} [-Werror=format=]
finfo("Read %d bytes:\n", nbytes);
^~~~~~~~~~~~~~~~~~ ~~~~~~
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org