You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefania (JIRA)" <ji...@apache.org> on 2015/12/14 16:54:46 UTC
[jira] [Commented] (CASSANDRA-10750) Minor code improvements
[ https://issues.apache.org/jira/browse/CASSANDRA-10750?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15056159#comment-15056159 ]
Stefania commented on CASSANDRA-10750:
--------------------------------------
[~snazy] : I have just started working on the review and I hope to have some more comments by tomorrow. In the meantime you may want to rebase and take a look at the cassci results as they don't look too good. Aside from the usual dtests time outs, there seems to be some NPEs. The utests also had a bad run, at a minimum run them one more time to make sure the additional time outs are unrelated.
> Minor code improvements
> -----------------------
>
> Key: CASSANDRA-10750
> URL: https://issues.apache.org/jira/browse/CASSANDRA-10750
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Robert Stupp
> Assignee: Robert Stupp
> Priority: Minor
>
> Went though several IDE inspections and found some places in the code that could be improved. These are just minor improvements and no bug fixes (except one minor "theoretical" thing).
> The [branch on github against trunk|https://github.com/snazy/cassandra/tree/10750-code-opts-trunk] contains a series of commits:
> * simplify Mutation.apply to remove the casts
> * "minor code improvements" just replaces some expressions that are effectively constant
> * remove unused assignments (probably just cosmetic)
> * collapse identical if-branches (probably just cosmetic)
> * empty array constants
> * fix printf usage (could potentially raise an exception in printf)
> * replace tail-recursion in some critical sections (as the JVM cannot optimize that AFAIK)
> * remove methods identical to their super methods (probably just cosmetic)
> [cassci results here|http://cassci.datastax.com/view/Dev/view/snazy/search/?q=snazy-10750-]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)