You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by jinxliu <gi...@git.apache.org> on 2017/10/27 07:04:48 UTC
[GitHub] zeppelin pull request #2634: Kylin intp
GitHub user jinxliu opened a pull request:
https://github.com/apache/zeppelin/pull/2634
Kylin intp
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
* First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinxliu/zeppelin kylin-intp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2634
----
commit ec68d12437611dd6fb817fa058020bb926b7e163
Author: Liu <ji...@ebay.com>
Date: 2017-10-27T06:05:39Z
enhance kylin interpter, add error message parse
commit d20872c5014e66ffcaf9d3bb51193ca3023bce92
Author: Liu <ji...@ebay.com>
Date: 2017-10-27T07:03:26Z
NPE bug fix when returned result set is empty
----
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
@zjffdu sure I will close this PR and have created another PR https://github.com/apache/zeppelin/pull/2645. Please review.
---
[GitHub] zeppelin issue #2634: NPE bug fix and Error message enhancement with Kylin I...
Posted by tinkoff-dwh <gi...@git.apache.org>.
Github user tinkoff-dwh commented on the issue:
https://github.com/apache/zeppelin/pull/2634
@jinxliu
read https://zeppelin.apache.org/contribution/contributions.html (**Creating a Pull Request**)
---
[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu closed the pull request at:
https://github.com/apache/zeppelin/pull/2634
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2634
seems like travis problem. please try to kick it off again by close-reopen this PR
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
@felixcheung is there something wrong with travis-ci?
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
@jinxliu Actually you don't need to create another PR, for the next time you just need to rebase and force push
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
@felixcheung it still does not work.
---
[GitHub] zeppelin issue #2634: NPE bug fix and Error message enhancement with Kylin I...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/2634
can you update the PR description
---
[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu closed the pull request at:
https://github.com/apache/zeppelin/pull/2634
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by zjffdu <gi...@git.apache.org>.
Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
@jinxliu Could you rebase and try again ?
---
[GitHub] zeppelin issue #2634: Kylin intp
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
This PR has two commits, https://github.com/apache/zeppelin/pull/2634/commits/ec68d12437611dd6fb817fa058020bb926b7e163 is to enhance the error message parse and display, the second commit is https://github.com/apache/zeppelin/pull/2634/commits/d20872c5014e66ffcaf9d3bb51193ca3023bce92 for NPE bug fix when returned dataset is empty.
---
[GitHub] zeppelin pull request #2634: [ZEPPELIN-3014] NPE bug fix and Error message e...
Posted by jinxliu <gi...@git.apache.org>.
GitHub user jinxliu reopened a pull request:
https://github.com/apache/zeppelin/pull/2634
[ZEPPELIN-3014] NPE bug fix and Error message enhancement with Kylin Interpreter
### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://zeppelin.apache.org/contribution/contributions.html
### What type of PR is it?
Bug Fix
### Todos
* [ ] - Task
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3014
### How should this be tested?
* Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Use existing unit tests in kylin module.
### Screenshots (if appropriate)
#### before: NPE when result set is empty
#### after: no NPE when result set is empty, just an empty table
#### before: when query fails, only error code is returned, no error message
#### after: when query fails, both error code and error message are displayed to users
### Questions:
* Does the licenses files need update? No.
* Is there breaking changes for older versions? No.
* Does this needs documentation? No.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinxliu/zeppelin kylin-intp
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2634.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2634
----
commit ec68d12437611dd6fb817fa058020bb926b7e163
Author: Liu <ji...@ebay.com>
Date: 2017-10-27T06:05:39Z
enhance kylin interpter, add error message parse
commit cadaa2b9877da39d96db6b2e06f4169c9f604caf
Author: Liu <ji...@ebay.com>
Date: 2017-10-27T07:03:26Z
NPE bug fix when returned result set is empty
commit c1ec9e72ec7c74c75011e2abf37a9563d1af7056
Author: jinxliu <ji...@ebay.com>
Date: 2017-10-27T07:56:09Z
Merge pull request #1 from apache/master
merge recent changes
commit 933c9d872e67d64d9e646cb287a66f2d7593a54a
Author: Liu <ji...@ebay.com>
Date: 2017-10-31T05:45:48Z
use gson
commit a45a3b4bdbef4aff2f743a461c29ea435125c895
Author: Liu <ji...@ebay.com>
Date: 2017-10-31T05:46:55Z
Merge branch 'kylin-intp' of https://github.com/jinxliu/zeppelin into kylin-intp
commit 531318cdf8974d80ee4ff4c659c4fb29bfae91ef
Author: jinxliu <ji...@ebay.com>
Date: 2017-10-31T06:34:31Z
Merge pull request #2 from apache/master
keep up to date with apache master branch
----
---
[GitHub] zeppelin issue #2634: [ZEPPELIN-3014] NPE bug fix and Error message enhancem...
Posted by jinxliu <gi...@git.apache.org>.
Github user jinxliu commented on the issue:
https://github.com/apache/zeppelin/pull/2634
I have tried several times since yesterday, hope this time it works.
---