You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/23 05:10:20 UTC
[GitHub] [incubator-superset] villebro opened a new pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
villebro opened a new pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110
### SUMMARY
With the bump of `pylint` to version 2.5.3 per #10101, the Superset build env should now be fully 3.7+ compatible.
### TEST PLAN
Run all python tests on 3.7 and ensure CI passes smoothly.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10110: [WIP] feat: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-646846386
I'm flagging this as a 0.37 dependency, as I feel adding official support for py38 is important as it's already in production use in some large deployments. If changing the test matrix is too much I can remove those for now, but I'd really like for us to consider py38 officially supported.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on a change in pull request #10110: ci: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#discussion_r465542975
##########
File path: setup.py
##########
@@ -133,6 +133,7 @@ def get_git_sha():
classifiers=[
"Programming Language :: Python :: 3.6",
Review comment:
Let's keep it there a while longer and drop it in a separate PR where `dataclasses` and other backwards compatibility libs are also dropped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] bkyryliuk commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
bkyryliuk commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-658391880
looking forward to it !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-662821271
Close/reopened to re-trigger CI that was stuck
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-658578327
I think it's ok for this project to be prescriptive of the python version (being an app, an not a library). It makes it easier on us as the build matrix can be focussed on a single version, the docker can be aligned with that version, and that everyone running Superset in production should align with the prescribed version for that release. So say if it's `3.7` after this version, it's "run on anything else at your own risk".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter commented on pull request #10110: ci: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-669049706
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=h1) Report
> Merging [#10110](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/57dc7622b4e246d7b900efaebf06f5cbd1b59c6a&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10110 +/- ##
==========================================
- Coverage 63.62% 63.55% -0.07%
==========================================
Files 764 764
Lines 36158 36158
Branches 3438 3438
==========================================
- Hits 23004 22982 -22
- Misses 13041 13060 +19
- Partials 113 116 +3
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `53.99% <ø> (-0.51%)` | :arrow_down: |
| #javascript | `59.92% <ø> (ø)` | |
| #python | `59.09% <ø> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/SqlLab/reducers/getInitialState.js](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9nZXRJbml0aWFsU3RhdGUuanM=) | `33.33% <0.00%> (-16.67%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/TabbedSqlEditors.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RhYmJlZFNxbEVkaXRvcnMuanN4) | `77.27% <0.00%> (-5.20%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/SqlEditorLeftBar.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvckxlZnRCYXIuanN4) | `44.00% <0.00%> (-4.00%)` | :arrow_down: |
| [...end/src/SqlLab/components/TemplateParamsEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1RlbXBsYXRlUGFyYW1zRWRpdG9yLmpzeA==) | `88.57% <0.00%> (-2.86%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/actions/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9hY3Rpb25zL3NxbExhYi5qcw==) | `60.25% <0.00%> (-2.36%)` | :arrow_down: |
| [superset-frontend/src/SqlLab/reducers/sqlLab.js](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9yZWR1Y2Vycy9zcWxMYWIuanM=) | `37.75% <0.00%> (-1.66%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `52.12% <0.00%> (-1.22%)` | :arrow_down: |
| [...rontend/src/SqlLab/components/AceEditorWrapper.tsx](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL0FjZUVkaXRvcldyYXBwZXIudHN4) | `55.91% <0.00%> (-1.08%)` | :arrow_down: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.54% <0.00%> (+0.14%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.33% <0.00%> (+0.25%)` | :arrow_up: |
| ... and [2 more](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=footer). Last update [57dc762...293bf6a](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro edited a comment on pull request #10110: ci: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro edited a comment on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-668177777
Ok @willbarrett , let's temporarily enable 3.6 and 3.7 and disable 3.6 once Apache updates. I'll make the change and reach out to ASF infra.
Edit: decided against it to avoid slowing down CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch edited a comment on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
mistercrunch edited a comment on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-658578327
I think it's ok for this project to be prescriptive of the python version (being an app, an not a library). It makes it easier on us as the build matrix can be focussed on a single version, the docker can be aligned with that version, and that everyone running Superset in production should align with the prescribed version for that release. So say if it's `3.7` after this version, it's "run on anything else at your own risk".
The alternative is to cover a version range of python, and to do that well we need to explode our build matrix. After the whole 2.7 to 3.6 fiasco I'd rather stay away from being straddling across python versions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] ktmud commented on pull request #10110: [WIP] feat: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-646854009
Are we dropping support for Python 3.6 yet?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on a change in pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#discussion_r457537671
##########
File path: setup.py
##########
@@ -133,6 +133,7 @@ def get_git_sha():
classifiers=[
"Programming Language :: Python :: 3.6",
Review comment:
Should we remove this line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro merged pull request #10110: ci: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro merged pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-653937287
@mistercrunch how do you feel about moving tests to py37? If this is ok, who can change the required status checks to reference the 3.7 tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch closed pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
mistercrunch closed pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] etr2460 commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
etr2460 commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-656939478
After discussion today, folks were in favor of moving to python 3.7 as the supported version and removing official support for Python 3.6 after the 0.37 release
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10110: [WIP] feat: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-646855251
I propose we don't, but next release I think we should.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-668177777
Ok @willbarrett , let's temporarily enable 3.6 and 3.7 and disable 3.6 once Apache updates. I'll make the change and reach out to ASF infra.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #10110: ci: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-669049706
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=h1) Report
> Merging [#10110](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/57dc7622b4e246d7b900efaebf06f5cbd1b59c6a&el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #10110 +/- ##
==========================================
+ Coverage 63.62% 63.65% +0.03%
==========================================
Files 764 764
Lines 36158 36158
Branches 3438 3438
==========================================
+ Hits 23004 23017 +13
+ Misses 13041 13028 -13
Partials 113 113
```
| Flag | Coverage Δ | |
|---|---|---|
| #cypress | `54.50% <ø> (ø)` | |
| #javascript | `59.92% <ø> (ø)` | |
| #python | `59.09% <ø> (+0.05%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `89.54% <0.00%> (+0.14%)` | :arrow_up: |
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.33% <0.00%> (+0.25%)` | :arrow_up: |
| [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.22% <0.00%> (+0.83%)` | :arrow_up: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/incubator-superset/pull/10110/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.48% <0.00%> (+12.76%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=footer). Last update [57dc762...293bf6a](https://codecov.io/gh/apache/incubator-superset/pull/10110?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] villebro commented on pull request #10110: ci: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
villebro commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-669042228
ASF Infra ticket: https://issues.apache.org/jira/browse/INFRA-20643
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] willbarrett commented on pull request #10110: chore: bump Python tests to 3.7 and add support for 3.8
Posted by GitBox <gi...@apache.org>.
willbarrett commented on pull request #10110:
URL: https://github.com/apache/incubator-superset/pull/10110#issuecomment-668177195
@villebro I'm thinking we need to ask Apache to update the required checks to 3.7, or temporarily also run against 3.6
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org