[GitHub] [skywalking] IAMTJW commented on issue #2774: Jetty client intercept HttpRequest send with two args may be more userful

[GitBox <gi...@apache.org>]

IAMTJW commented on issue #2774: Jetty client intercept HttpRequest send with two args may be more userful
URL: https://github.com/apache/skywalking/pull/2774#issuecomment-496750317
 
 
   > The jetty plugin only supports to trace the `send` method, because this method is a synchronization call, but the `send` method with two parameters is the asynchronous call. If you want to supports to trace the asynchronous call, You should add new instrumentation to support it.
   
   
   Why cant support asynchronous call，the SyncHttpRequestSendInterceptor afterMethod just call ContextManager.stopSpan() and not do other thing. I think it has nothing to do with the synchronization or asynchronous call. The jetty plugin  supports to trace the called service and not care about the response.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services