You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@james.apache.org by "hungphan227 (via GitHub)" <gi...@apache.org> on 2024/06/13 07:34:57 UTC
[PR] JAMES-2586 Optimize findNonPersonalMailboxes method in PostgresMailboxMapper [james-project]
hungphan227 opened a new pull request, #2296:
URL: https://github.com/apache/james-project/pull/2296
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Optimize findNonPersonalMailboxes method in PostgresMailboxMapper [james-project]
Posted by "chibenwa (via GitHub)" <gi...@apache.org>.
chibenwa commented on code in PR #2296:
URL: https://github.com/apache/james-project/pull/2296#discussion_r1648441376
##########
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresTable.java:
##########
@@ -52,11 +53,58 @@ default FinalStage supportsRowLevelSecurity() {
}
}
+ public abstract static class AdditionalAlterQuery {
+ private String query;
+
+ public AdditionalAlterQuery(String query) {
+ this.query = query;
+ }
+
+ abstract boolean isApplied(boolean rowLevelSecurityEnabled);
Review Comment:
> To change this, I have to refactor code in a lot places.
Not an issue to me.
https://www.teamten.com/lawrence/programming/prefer-enums-over-booleans.html
I'm surprised I need to argue to use strong types.
##########
backends-common/postgres/src/main/java/org/apache/james/backends/postgres/PostgresTable.java:
##########
@@ -52,11 +53,58 @@ default FinalStage supportsRowLevelSecurity() {
}
}
+ public abstract static class AdditionalAlterQuery {
+ private String query;
+
+ public AdditionalAlterQuery(String query) {
+ this.query = query;
+ }
+
+ abstract boolean isApplied(boolean rowLevelSecurityEnabled);
Review Comment:
> To change this, I have to refactor code in a lot places.
Not an issue to me.
> I think rowLevelSecurityEnabled is enough to understand
This is subjective.
Rationals: https://www.teamten.com/lawrence/programming/prefer-enums-over-booleans.html
I'm surprised I need to argue to use strong types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Optimize findNonPersonalMailboxes method in PostgresMailboxMapper [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2296:
URL: https://github.com/apache/james-project/pull/2296#issuecomment-2185598425
Should we rerun a perf test, just to be sure we are on the safe side after all the refactorings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Optimize findNonPersonalMailboxes method in PostgresMailboxMapper [james-project]
Posted by "Arsnael (via GitHub)" <gi...@apache.org>.
Arsnael commented on PR #2296:
URL: https://github.com/apache/james-project/pull/2296#issuecomment-2185850548
Needs a rebase :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org
Re: [PR] JAMES-2586 Optimize findNonPersonalMailboxes method in PostgresMailboxMapper [james-project]
Posted by "hungphan227 (via GitHub)" <gi...@apache.org>.
hungphan227 commented on PR #2296:
URL: https://github.com/apache/james-project/pull/2296#issuecomment-2185753611
> Should we rerun a perf test, just to be sure we are on the safe side after all the refactorings?
I am sure those changes don't have any impact
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org