You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Thomas Marshall <tw...@gmail.com> on 2013/05/17 02:52:25 UTC
Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use roles
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Description
-------
Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
Diffs
-----
include/mesos/mesos.proto 1c242d6
src/master/hierarchical_allocator_process.hpp 2422fbd
src/tests/allocator_tests.cpp 540c05a
Diff: https://reviews.apache.org/r/11205/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use
roles
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/#review21724
-----------------------------------------------------------
Ship it!
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11205/#comment44893>
Please keep the newline here.
src/tests/allocator_tests.cpp
<https://reviews.apache.org/r/11205/#comment44894>
Please keep the newline here as well, thanks!
- Benjamin Hindman
On June 5, 2013, 9:07 p.m., Thomas Marshall wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11205/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 9:07 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Description
> -------
>
> Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ece6559
> src/master/hierarchical_allocator_process.hpp 1048a28
> src/tests/allocator_tests.cpp 32f0a90
>
> Diff: https://reviews.apache.org/r/11205/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Thomas Marshall
>
>
Re: Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use
roles
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/
-----------------------------------------------------------
(Updated June 12, 2013, 11:40 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Added bug.
Description
-------
Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
This addresses bug MESOS-504.
https://issues.apache.org/jira/browse/MESOS-504
Diffs
-----
include/mesos/mesos.proto 8cbcd9a
src/master/hierarchical_allocator_process.hpp 1048a28
src/tests/allocator_tests.cpp 32f0a90
Diff: https://reviews.apache.org/r/11205/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use
roles
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/
-----------------------------------------------------------
(Updated June 11, 2013, 6:55 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Ben H's review.
Description
-------
Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
Diffs (updated)
-----
include/mesos/mesos.proto 8cbcd9a
src/master/hierarchical_allocator_process.hpp 1048a28
src/tests/allocator_tests.cpp 32f0a90
Diff: https://reviews.apache.org/r/11205/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use
roles
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/
-----------------------------------------------------------
(Updated June 5, 2013, 9:07 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Rebased.
A [DISCUSS} has been sent out to mesos-dev about these changes, and the only response so far has been positive, so it should be safe to go ahead with them.
Description
-------
Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
Diffs (updated)
-----
include/mesos/mesos.proto ece6559
src/master/hierarchical_allocator_process.hpp 1048a28
src/tests/allocator_tests.cpp 32f0a90
Diff: https://reviews.apache.org/r/11205/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use
roles
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/
-----------------------------------------------------------
(Updated May 30, 2013, 6:15 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Rebased.
Description
-------
Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
Diffs (updated)
-----
include/mesos/mesos.proto ece6559
src/master/hierarchical_allocator_process.hpp 28a7879
src/tests/allocator_tests.cpp b153dee
Diff: https://reviews.apache.org/r/11205/diff/
Testing
-------
make check
Thanks,
Thomas Marshall
Re: Review Request: WDRF 1 - Refactor HierarchicalAllocatorProcess to use
roles
Posted by Thomas Marshall <tw...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11205/
-----------------------------------------------------------
(Updated May 30, 2013, 6:04 p.m.)
Review request for mesos and Benjamin Hindman.
Changes
-------
Rebased.
Description
-------
Refactors HierarchicalAllocatorProcess to use role instead of user. Also adds role as a field in FrameworkInfo, and updated DRFAllocatorTest appropriately.
Diffs (updated)
-----
include/mesos/mesos.proto ece6559
src/master/hierarchical_allocator_process.hpp 2422fbd
src/tests/allocator_tests.cpp 540c05a
Diff: https://reviews.apache.org/r/11205/diff/
Testing
-------
make check
Thanks,
Thomas Marshall