You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/08/12 13:23:25 UTC
[GitHub] [incubator-nuttx] acassis opened a new pull request, #6843: sim: Fix the /etc/passwd after TEA algo fixing
acassis opened a new pull request, #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843
## Summary
After TEA fixing https://github.com/apache/incubator-nuttx-apps/pull/1097 the Console Login to SIM stopped to work.
## Impact
It makes sim nsh board profile work again
## Testing
sim
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213329493
I think it depends on the password length. If it is 8, 16, 24, etc. bytes, then no update is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213335382
> Won't this break any existing systems that have the password saved and are upgraded?
If passwd is in ROM and is a part of an image, then no l issues as passwd will be upgraded with image upgrade. Only cases when the file is stored not in ROM FS will be affected.
I already wrote in the mailing list, that I'm not sure what is the best solution here. I think that it is bad to keep out of a bound array access, but on the other hand most of the existing passwd cases are getting affected. The other option is to use zero as a padding bytes instead of "space". In this case I think we can keep compatibility, but it will be a bit different algorithm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213330868
> Won't this break any existing systems that have the password saved and are upgraded?
Normally the update will write the entire system with the new password (FLAT mode), assuming the product owner remembered to update the passwd file. Case it is PROTECTED or KERNEL mode the kernel is not affected, then same case: user need to update the passwd file. Maybe we could put some warning in the Release Notes, what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] btashton commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
btashton commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213326033
Won't this break any existing systems that have the password saved and are upgraded?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213368410
ping @jerpelea !!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
jerpelea commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1214688941
I think that v11 is a good way to indicate that we break compatibility
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] tmedicci commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
tmedicci commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213139009
Fixed it!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213316899
@pkarashchenko you was right:
```
$ find . -name passwd
./sim/sim/sim/src/etctmp/etc/passwd
./sim/sim/sim/src/etc/passwd
./risc-v/esp32c3/esp32c3-devkit/src/etc/passwd
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213368133
@davids5 Do you think we need to move to version 11.0.0 to indicate it broke compatibility with previous version? @pkarashchenko it could be an option, but we need be 100% sure that it will generate same hash for all passwords.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6843: sim: Fix the /etc/passwd after TEA algo fixing
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6843:
URL: https://github.com/apache/incubator-nuttx/pull/6843#issuecomment-1213326846
Strange, seems like ./sim/sim/sim/src/etctmp/etc/passwd was already with the right password
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org