You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Guangya Liu <gy...@gmail.com> on 2016/04/02 07:52:35 UTC

Re: Review Request 45270: Added spec protobut for external mount.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 2, 2016, 5:52 a.m.)


Review request for mesos, Gilbert Song and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobut for external mount.


Diffs (updated)
-----

  src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing (updated)
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review127132
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto (line 32)
<https://reviews.apache.org/r/45270/#comment190273>

    Does it should be repeated? And because the options looks like:
    
    ```
    --volumeopts=k1=v1 --volumeopts=k2=v2
    ```
    
    I think the type should be `Parameter`?


- haosdent huang


On April 2, 2016, 5:52 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 2, 2016, 5:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 4, 2016, 11:16 p.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp, line 28
> > <https://reviews.apache.org/r/45270/diff/4/?file=1322998#file1322998line28>
> >
> >     Should we add a inline parse method here?

Seems not as the dvd isolator do not need to parse some JSON files.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review126968
-----------------------------------------------------------


On 四月 2, 2016, 5:52 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated 四月 2, 2016, 5:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review126968
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp (line 28)
<https://reviews.apache.org/r/45270/#comment190091>

    Should we add a inline parse method here?



src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp (line 29)
<https://reviews.apache.org/r/45270/#comment190088>

    s/function/functions/g


- Gilbert Song


On April 1, 2016, 10:52 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 1, 2016, 10:52 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ff225c0d51a32b03a1b5f2ba31718ec2305c7ced 
>   src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Greg Mann <gr...@mesosphere.io>.

> On April 14, 2016, 8:17 p.m., Greg Mann wrote:
> >

Could you fix the typo in the commit message: "protobut" should be "protobuf". Also, could you remove the duplicate Summary that's in the Description field, and add a more verbose description of the patch in the Description field?


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128971
-----------------------------------------------------------


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128971
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 30)
<https://reviews.apache.org/r/45270/#comment192422>

    s/and not configurable/and is not configurable/


- Greg Mann


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review128922
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 19)
<https://reviews.apache.org/r/45270/#comment192360>

    above `import "mesos/mesos.proto";`



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (lines 26 - 27)
<https://reviews.apache.org/r/45270/#comment192369>

    This field make me feel confused, since we also have a `conainer_path` field in volume as a required string. Should they be identical? If yes, we should comment it.



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 34)
<https://reviews.apache.org/r/45270/#comment192371>

    +1 on parameters.


- Gilbert Song


On April 13, 2016, 9:41 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 9:41 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, line 19
> > <https://reviews.apache.org/r/45270/diff/7/?file=1343794#file1343794line19>
> >
> >     Why this namespace? This is technically not 'spec', but the _state_ scheme used by the isolator. We should call the protobuf file 'state.proto'.
> >     
> >     I would suggest we still put it under `package mesos.internal.slave`, and call it `DockerVolumeMount`.
> >     
> >     s/ExternalMountList/DockerVolumeState/

what about putting this under `package mesos.internal.slave.volume`?


> On 四月 14, 2016, 10:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/spec.proto, lines 21-35
> > <https://reviews.apache.org/r/45270/diff/7/?file=1343794#file1343794line21>
> >
> >     Why do you need to checkpoint 'container_path', 'mount_point' and 'driver_options'?

My original thought was adding more info here for debug, yes, we can remove them now.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129011
-----------------------------------------------------------


On 四月 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated 四月 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129011
-----------------------------------------------------------




src/CMakeLists.txt (lines 52 - 54)
<https://reviews.apache.org/r/45270/#comment192472>

    the naming here looks bad. We should rename them to:
    ```
    PROVISIONER_DOCKER
    ISOLATOR_CNI_SPEC
    ISOLATOR_DOCKER_VOLUME_SPEC
    ```



src/CMakeLists.txt (line 63)
<https://reviews.apache.org/r/45270/#comment192473>

    You need to update the protobuf here as well (also adding the new one you just added).



src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp (line 29)
<https://reviews.apache.org/r/45270/#comment192477>

    Let's not yet introduce file yet.



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (line 19)
<https://reviews.apache.org/r/45270/#comment192476>

    Why this namespace? This is technically not 'spec', but the _state_ scheme used by the isolator. We should call the protobuf file 'state.proto'.
    
    I would suggest we still put it under `package mesos.internal.slave`, and call it `DockerVolumeMount`.
    
    s/ExternalMountList/DockerVolumeState/



src/slave/containerizer/mesos/isolators/docker/volume/spec.proto (lines 21 - 35)
<https://reviews.apache.org/r/45270/#comment192474>

    Why do you need to checkpoint 'container_path', 'mount_point' and 'driver_options'?


- Jie Yu


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129650
-----------------------------------------------------------




src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 21)
<https://reviews.apache.org/r/45270/#comment193137>

    s/DockerVolumeMount/DockerVolume/



src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 22)
<https://reviews.apache.org/r/45270/#comment193138>

    s/volume_driver/driver/
    s/volume_name/name/
    
    Volume already in the message Type.



src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 27)
<https://reviews.apache.org/r/45270/#comment193139>

    s/DockerVolumeMountList/DockerVolumes/



src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 28)
<https://reviews.apache.org/r/45270/#comment193141>

    s/mounts/volumes/


- Jie Yu


On April 19, 2016, 3:04 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 3:04 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolumeMount.
> The DockerVolumeMount was used to check point the mount
> point for each container to recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 19, 2016, 5:27 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/state.proto, lines 32-46
> > <https://reviews.apache.org/r/45270/diff/9/?file=1350577#file1350577line32>
> >
> >     I still don't understand why we want to make it a protobuf? Can that just be a nested struct in the isolator?

OK, will move this to struct.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129570
-----------------------------------------------------------


On 四月 19, 2016, 3:04 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated 四月 19, 2016, 3:04 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolumeMount.
> The DockerVolumeMount was used to check point the mount
> point for each container to recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129570
-----------------------------------------------------------




src/CMakeLists.txt (line 55)
<https://reviews.apache.org/r/45270/#comment193000>

    s/SPEC/STATE/?



src/CMakeLists.txt (line 88)
<https://reviews.apache.org/r/45270/#comment193001>

    Ditto.



src/slave/containerizer/mesos/isolators/docker/volume/state.proto (line 27)
<https://reviews.apache.org/r/45270/#comment193002>

    s/DockerVolumeMountList/DockerVolumeMounts/



src/slave/containerizer/mesos/isolators/docker/volume/state.proto (lines 32 - 46)
<https://reviews.apache.org/r/45270/#comment193003>

    I still don't understand why we want to make it a protobuf? Can that just be a nested struct in the isolator?


- Jie Yu


On April 19, 2016, 3:04 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 19, 2016, 3:04 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolumeMount.
> The DockerVolumeMount was used to check point the mount
> point for each container to recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129751
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On April 20, 2016, 10:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 10:57 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolume.
> The DockerVolume was used to check point the mount
> point for each container when recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129753
-----------------------------------------------------------




src/Makefile.am (line 837)
<https://reviews.apache.org/r/45270/#comment193291>

    Why remove paths.hpp??
    
    Please be careful and do a make distcheck when submitting a patch.


- Jie Yu


On April 20, 2016, 10:57 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 10:57 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobuf for DockerVolume.
> The DockerVolume was used to check point the mount
> point for each container when recover.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
>   src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 20, 2016, 5:39 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.


Diffs (updated)
-----

  src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
  src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolume.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 20, 2016, 10:57 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Summary (updated)
-----------------

Added spec protobuf for DockerVolume.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.


Diffs (updated)
-----

  src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
  src/slave/containerizer/mesos/isolators/docker/volume/state.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 20, 2016, 6:38 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
-------

Added spec protobuf for DockerVolume.
The DockerVolume was used to check point the mount
point for each container when recover.


Diffs (updated)
-----

  src/CMakeLists.txt e4923c4d4a7a9eefcab9267fe5def7f7535e49ed 
  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 19, 2016, 3:04 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
-------

Added spec protobuf for DockerVolumeMount.
The DockerVolumeMount was used to check point the mount
point for each container to recover.


Diffs (updated)
-----

  src/CMakeLists.txt aabb33dfd4b985fe5774f87bb63b4ec1ec853962 
  src/Makefile.am 5a2b4efa781752863d6751f98614fb78bece73ac 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 15, 2016, 11:56 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
-------

Added spec protobuf for DockerVolumeMount. The DockerVolumeMount
was used to check point the mount point for each container to recover.


Diffs
-----

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for DockerVolumeMount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 15, 2016, 2:44 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Summary (updated)
-----------------

Added spec protobuf for DockerVolumeMount.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
-------

Added spec protobuf for DockerVolumeMount. The DockerVolumeMount was used to check point the mount point for each container to recover.


Diffs
-----

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobuf for external mount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 15, 2016, 2:23 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Summary (updated)
-----------------

Added spec protobuf for external mount.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description (updated)
-------

Added spec protobuf for external mount.


Diffs (updated)
-----

  src/CMakeLists.txt 06f58c4a88e3c527df727df1efe11ed3ab77efa8 
  src/Makefile.am ec855263d620e4723c8ba9cd056c40a3a2e9ca99 
  src/slave/containerizer/mesos/isolators/docker/volume/state.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Guangya Liu <gy...@gmail.com>.

> On 四月 15, 2016, 12:27 a.m., Jie Yu wrote:
> > Second thoughts on this. We should not use a single protobuf file for checkpointing. Otherwise, we'll have to write the entire file to the filesystem anytime we do a mount or umount. Let's just create some directory structure under /var/run/mesos/isolators/docker/volume. Please take a look at network/cni/paths.hpp|cpp.

OK, will create a separate patch for this.

The hierarchy of the checkpoint will be:

   /var/run/mesos/isolators/docker/volume
    |- <ID of Container1>/
    |  |-- mountinfo <volumedriver, volumename>
    |-- <ID of ContainerID 2>/
    | ...


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129043
-----------------------------------------------------------


On 四月 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated 四月 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/#review129043
-----------------------------------------------------------



Second thoughts on this. We should not use a single protobuf file for checkpointing. Otherwise, we'll have to write the entire file to the filesystem anytime we do a mount or umount. Let's just create some directory structure under /var/run/mesos/isolators/docker/volume. Please take a look at network/cni/paths.hpp|cpp.

- Jie Yu


On April 14, 2016, 4:41 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45270/
> -----------------------------------------------------------
> 
> (Updated April 14, 2016, 4:41 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.
> 
> 
> Bugs: MESOS-5013
>     https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added spec protobut for external mount.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
>   src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
>   src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45270/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 14, 2016, 4:41 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobut for external mount.


Diffs (updated)
-----

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am 139935fb40f8986427c85537a400ff945e54433f 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 13, 2016, 10:40 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Changes
-------

move files to docker/volume


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobut for external mount.


Diffs (updated)
-----

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/volume/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu

Re: Review Request 45270: Added spec protobut for external mount.

Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45270/
-----------------------------------------------------------

(Updated 四月 13, 2016, 7:16 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and Jie Yu.


Bugs: MESOS-5013
    https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
-------

Added spec protobut for external mount.


Diffs (updated)
-----

  src/CMakeLists.txt ca59a1824352423f4db6ef8bb41acc6fe602c041 
  src/Makefile.am a8f68316c5d4d4c82d99363535a97fa5b1caafc5 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.hpp PRE-CREATION 
  src/slave/containerizer/mesos/isolators/docker/dvd/spec.proto PRE-CREATION 

Diff: https://reviews.apache.org/r/45270/diff/


Testing
-------

make
make check


Thanks,

Guangya Liu