You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Josh Rosen (JIRA)" <ji...@apache.org> on 2015/06/17 21:20:00 UTC
[jira] [Commented] (SPARK-3854) Scala style: require spaces before
`{`
[ https://issues.apache.org/jira/browse/SPARK-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590394#comment-14590394 ]
Josh Rosen commented on SPARK-3854:
-----------------------------------
Does anyone know whether we're now enforcing this? [~rxin] may have fixed this recently.
> Scala style: require spaces before `{`
> --------------------------------------
>
> Key: SPARK-3854
> URL: https://issues.apache.org/jira/browse/SPARK-3854
> Project: Spark
> Issue Type: Sub-task
> Components: Project Infra
> Reporter: Josh Rosen
>
> We should require spaces before opening curly braces. This isn't in the style guide, but it probably should be:
> {code}
> // Correct:
> if (true) {
> println("Wow!")
> }
> // Incorrect:
> if (true){
> println("Wow!")
> }
> {code}
> See https://github.com/apache/spark/pull/1658#discussion-diff-18611791 for an example "in the wild."
> {{git grep "){"}} shows only a few occurrences of this style.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org