You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrew Schwartzmeyer <an...@schwartzmeyer.com> on 2017/05/15 20:45:45 UTC
Review Request 59293: Windows: Fixed apply-reviews.py to retain line
feeds.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59293/
-----------------------------------------------------------
Review request for mesos and Joseph Wu.
Repository: mesos
Description
-------
Write using 'wb' instead of 'w' for binary mode. This writes the
downloaded patch file exactly as it came, instead of treating as text
and changing line endings. This resolves a bug where `git apply` doesn't
always work with CRLF endings in patch files.
Diffs
-----
support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850
Diff: https://reviews.apache.org/r/59293/diff/1/
Testing
-------
Applied patch 59177 successfully after failing to apply it without change due to:
```
59177.patch:9: trailing whitespace.
59177.patch:18: trailing whitespace.
def autocomplete(cmds, plugins, config, argv):
59177.patch:26: trailing whitespace.
current_word = argv[0]
59177.patch:27: trailing whitespace.
argv = argv[1:]
59177.patch:36: trailing whitespace.
return plugin_class(settings, config).__autocomplete_base__(
error: git apply: bad git-diff - expected /dev/null on line 167
```
Thanks,
Andrew Schwartzmeyer
Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain
line feeds.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59293/#review175065
-----------------------------------------------------------
Patch looks great!
Reviews applied: [59293]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On May 15, 2017, 8:45 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59293/
> -----------------------------------------------------------
>
> (Updated May 15, 2017, 8:45 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Write using 'wb' instead of 'w' for binary mode. This writes the
> downloaded patch file exactly as it came, instead of treating as text
> and changing line endings. This resolves a bug where `git apply` doesn't
> always work with CRLF endings in patch files.
>
>
> Diffs
> -----
>
> support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850
>
>
> Diff: https://reviews.apache.org/r/59293/diff/1/
>
>
> Testing
> -------
>
> Applied patch 59177 successfully after failing to apply it without change due to:
>
> ```
> 59177.patch:9: trailing whitespace.
>
> 59177.patch:18: trailing whitespace.
> def autocomplete(cmds, plugins, config, argv):
> 59177.patch:26: trailing whitespace.
> current_word = argv[0]
> 59177.patch:27: trailing whitespace.
> argv = argv[1:]
> 59177.patch:36: trailing whitespace.
> return plugin_class(settings, config).__autocomplete_base__(
> error: git apply: bad git-diff - expected /dev/null on line 167
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain
line feeds.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59293/#review175426
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On May 17, 2017, 3:13 p.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59293/
> -----------------------------------------------------------
>
> (Updated May 17, 2017, 3:13 p.m.)
>
>
> Review request for mesos and Joseph Wu.
>
>
> Bugs: MESOS-7343
> https://issues.apache.org/jira/browse/MESOS-7343
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Write using 'wb' instead of 'w' for binary mode. This writes the
> downloaded patch file exactly as it came, instead of treating as text
> and changing line endings. This resolves a bug where `git apply` doesn't
> always work with CRLF endings in patch files.
>
>
> Diffs
> -----
>
> support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850
>
>
> Diff: https://reviews.apache.org/r/59293/diff/1/
>
>
> Testing
> -------
>
> Applied patch 59177 successfully after failing to apply it without change due to:
>
> ```
> 59177.patch:9: trailing whitespace.
>
> 59177.patch:18: trailing whitespace.
> def autocomplete(cmds, plugins, config, argv):
> 59177.patch:26: trailing whitespace.
> current_word = argv[0]
> 59177.patch:27: trailing whitespace.
> argv = argv[1:]
> 59177.patch:36: trailing whitespace.
> return plugin_class(settings, config).__autocomplete_base__(
> error: git apply: bad git-diff - expected /dev/null on line 167
> ```
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
Re: Review Request 59293: Windows: Fixed apply-reviews.py to retain
line feeds.
Posted by Andrew Schwartzmeyer <an...@schwartzmeyer.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59293/
-----------------------------------------------------------
(Updated May 17, 2017, 10:13 p.m.)
Review request for mesos and Joseph Wu.
Bugs: MESOS-7343
https://issues.apache.org/jira/browse/MESOS-7343
Repository: mesos
Description
-------
Write using 'wb' instead of 'w' for binary mode. This writes the
downloaded patch file exactly as it came, instead of treating as text
and changing line endings. This resolves a bug where `git apply` doesn't
always work with CRLF endings in patch files.
Diffs
-----
support/apply-reviews.py b495675de80fd995f208f1b9ca8c88a717cf2850
Diff: https://reviews.apache.org/r/59293/diff/1/
Testing
-------
Applied patch 59177 successfully after failing to apply it without change due to:
```
59177.patch:9: trailing whitespace.
59177.patch:18: trailing whitespace.
def autocomplete(cmds, plugins, config, argv):
59177.patch:26: trailing whitespace.
current_word = argv[0]
59177.patch:27: trailing whitespace.
argv = argv[1:]
59177.patch:36: trailing whitespace.
return plugin_class(settings, config).__autocomplete_base__(
error: git apply: bad git-diff - expected /dev/null on line 167
```
Thanks,
Andrew Schwartzmeyer