You are viewing a plain text version of this content. The canonical link for it is here.
Posted to hdfs-issues@hadoop.apache.org by "Eli Collins (JIRA)" <ji...@apache.org> on 2010/02/22 04:38:27 UTC
[jira] Created: (HDFS-995) Replace usage of FileStatus#isDir()
Replace usage of FileStatus#isDir()
-----------------------------------
Key: HDFS-995
URL: https://issues.apache.org/jira/browse/HDFS-995
Project: Hadoop HDFS
Issue Type: Improvement
Components: name-node
Affects Versions: 0.22.0
Reporter: Eli Collins
Assignee: Eli Collins
Fix For: 0.22.0
HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HDFS-995:
---------------------------
Status: Resolved (was: Patch Available)
Fix Version/s: (was: 0.22.0)
Resolution: Fixed
I've just committed this. Thanks Eli!
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873748#action_12873748 ]
Eli Collins commented on HDFS-995:
----------------------------------
Wrong jira, the TestLargeDirectoryDelete time out is what I saw in HDFS-615. Since this patch just replaces uses of isDir with isDirectory and they have the same implementation that should be a separate issue.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-995:
-----------------------------
Attachment: hdfs-995-4.patch
Updated patch attached. Missed some calls to isDir() in TestFileStatus since it got refactored.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-995:
-----------------------------
Attachment: hdfs-995-1.patch
Patch attached. The change is pretty small and straight-forward, mostly updates tests. HDFS rarely uses FileStatus internally. The changes in the previous comment don't apply here because those are for INode rather than FileStatus (and those particular checks don't need to be performed since getFileINode fully resolves the link so the returned INode represents either a file or directory).
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
> Attachments: hdfs-995-1.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837027#action_12837027 ]
Eli Collins commented on HDFS-995:
----------------------------------
Places Sanjay called out in HDFS-245 that need to be fixed in this jira:
* FSImage#loadFilesUnderConstruction
{code}
if (old.isDirectory()) ...
add an additional check for isSymlink() -- or better !isFile()
{code}
* FSNamesystem#startFileInternal
{code}
} else if (myFile,isDirectory() {
....
} else if (myFile.isSymlink() {
assert(false, cannot reach here ) <-- add
}
{code}
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: name-node
> Affects Versions: 0.22.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Fix For: 0.22.0
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-995:
-----------------------------
Attachment: hdfs-995-2.patch
Attached patch merges with trunk.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873807#action_12873807 ]
Hudson commented on HDFS-995:
-----------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #288 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/288/])
HDFS-995. Replace usage of FileStatus#isDir(). Contributed by Eli Collins.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-995:
-----------------------------
Issue Type: Bug (was: Improvement)
Fix Version/s: 0.21.0
Affects Version/s: 0.20.3
0.21.0
(was: 0.22.0)
Priority: Blocker (was: Major)
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873743#action_12873743 ]
Eli Collins commented on HDFS-995:
----------------------------------
The hdfsproxy failure is HDFS-1164. The TestLargeDirectoryDelete time out is HDFS-816. TestDFSPermission doesn't time out for me locally, don't see a jira for it, can't reproduce it locally.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Eli Collins (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eli Collins updated HDFS-995:
-----------------------------
Attachment: hdfs-995-3.patch
Patch attached.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12872692#action_12872692 ]
Tom White commented on HDFS-995:
--------------------------------
+1 This patch has gone stale, can you regenerate please?
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Tom White (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tom White updated HDFS-995:
---------------------------
Status: Patch Available (was: Open)
Hadoop Flags: [Reviewed]
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HDFS-995) Replace usage of FileStatus#isDir()
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HDFS-995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12873576#action_12873576 ]
Hadoop QA commented on HDFS-995:
--------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12445728/hdfs-995-4.patch
against trunk revision 949333.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 30 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/386/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/386/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/386/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/386/console
This message is automatically generated.
> Replace usage of FileStatus#isDir()
> -----------------------------------
>
> Key: HDFS-995
> URL: https://issues.apache.org/jira/browse/HDFS-995
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: name-node
> Affects Versions: 0.20.3, 0.21.0
> Reporter: Eli Collins
> Assignee: Eli Collins
> Priority: Blocker
> Fix For: 0.21.0, 0.22.0
>
> Attachments: hdfs-995-1.patch, hdfs-995-2.patch, hdfs-995-3.patch, hdfs-995-4.patch
>
>
> HADOOP-6585 is going to deprecate FileStatus#isDir(). This jira is for replacing all uses of isDir() in HDFS with checks of isDirectory(), isFile(), or isSymlink() as needed.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.