You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/10/09 17:29:19 UTC
[GitHub] [airflow] potiuk opened a new pull request #18858: Stabilize occasional test_logging_head_error_request failures
potiuk opened a new pull request #18858:
URL: https://github.com/apache/airflow/pull/18858
Sometimes, when the test is executed in parallel it managed to
execute the test just 4 times instead of 5 before the timeout and the
test failed. This PR stabilizes the test by verifying if just two
first times were executed. There is no need to check the exact
number of retries - we just have to see that we tried at least
2 times and that the task eventually timed-out.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #18858: Stabilize occasional test_logging_head_error_request failures
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #18858:
URL: https://github.com/apache/airflow/pull/18858#issuecomment-940943943
This one happens quite rare, but it would be great to merge it to stabilize our CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #18858: Stabilize occasional test_logging_head_error_request failures
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #18858:
URL: https://github.com/apache/airflow/pull/18858#issuecomment-940951044
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #18858: Stabilize occasional test_logging_head_error_request failures
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #18858:
URL: https://github.com/apache/airflow/pull/18858
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org