[GitHub] [incubator-doris] morningman commented on a diff in pull request #8891: [Bug] Fix error bucket num get in bucket shuffle join in dynamic partition

[GitBox <gi...@apache.org>]

morningman commented on code in PR #8891:
URL: https://github.com/apache/incubator-doris/pull/8891#discussion_r844897351


##########
regression-test/suites/join/ddl/test_bucket_shuffle_join.sql:
##########
@@ -0,0 +1,20 @@
+CREATE TABLE test_bucket_shuffle_join (
+  `id` int NOT NULL COMMENT "",
+  `rectime` datetime NOT NULL COMMENT ""
+)
+UNIQUE KEY(`id`,`rectime`)
+COMMENT "olap"
+PARTITION BY RANGE(rectime) ()
+DISTRIBUTED BY HASH(id)
+PROPERTIES
+(
+ "replication_num" = "1",

Review Comment:
   Better not using `dynamic_partition`, because it will change as time pass by.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org