You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "heresie (via GitHub)" <gi...@apache.org> on 2023/03/10 13:49:58 UTC
[GitHub] [apisix-helm-chart] heresie opened a new pull request, #507: feat: upgrading etcd version in helm chart dependency for apisix
heresie opened a new pull request, #507:
URL: https://github.com/apache/apisix-helm-chart/pull/507
Hello,
Closes #506
All comments are welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] Gallardot merged pull request #507: feat: upgrading etcd version in helm chart dependency for apisix
Posted by "Gallardot (via GitHub)" <gi...@apache.org>.
Gallardot merged PR #507:
URL: https://github.com/apache/apisix-helm-chart/pull/507
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] heresie commented on a diff in pull request #507: feat: upgrading etcd version in helm chart dependency for apisix
Posted by "heresie (via GitHub)" <gi...@apache.org>.
heresie commented on code in PR #507:
URL: https://github.com/apache/apisix-helm-chart/pull/507#discussion_r1144368284
##########
charts/apisix/Chart.yaml:
##########
@@ -31,7 +31,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.2.0
+version: 1.2.1
Review Comment:
Hello @tao12345666333
Thank you for the feedback. I updated the Chart version to `1.3.0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #507: feat: upgrading etcd version in helm chart dependency for apisix
Posted by "tao12345666333 (via GitHub)" <gi...@apache.org>.
tao12345666333 commented on code in PR #507:
URL: https://github.com/apache/apisix-helm-chart/pull/507#discussion_r1143947894
##########
charts/apisix/Chart.yaml:
##########
@@ -31,7 +31,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
-version: 1.2.0
+version: 1.2.1
Review Comment:
Due to the large span of etcd version upgrades, I tend to upgrade a large version, how about we upgrade the version number to 1.3.0?
```suggestion
version: 1.3.0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org