You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/29 12:55:51 UTC
[GitHub] [pulsar] RobertIndie opened a new pull request, #16287: [improve][broker] Make Namespaces.deleteNamespaceBundle async
RobertIndie opened a new pull request, #16287:
URL: https://github.com/apache/pulsar/pull/16287
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://docs.google.com/document/d/1d8Pw6ZbWk-_pCKdOmdvx9rnhPiyuxwq60_TrD68d7BA/edit#heading=h.trs9rsex3xom)*.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
Master Issue: #14365
### Motivation
Please see #14365
### Modifications
* Make Namespaces.deleteNamespaceBundle async
* Combine internalDeleteNamespaceBundle
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc-required`
(Your PR needs to update docs and you will update later)
- [x] `doc-not-needed`
(Please explain why)
- [ ] `doc`
(Your PR contains doc changes)
- [ ] `doc-complete`
(Docs have been already added)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie commented on pull request #16287: [improve][broker] Make Namespaces.deleteNamespaceBundle async
Posted by GitBox <gi...@apache.org>.
RobertIndie commented on PR #16287:
URL: https://github.com/apache/pulsar/pull/16287#issuecomment-1175734528
Please take a look if you have time. @mattisonchao @Technoboy-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] RobertIndie merged pull request #16287: [improve][broker] Make Namespaces.deleteNamespaceBundle async
Posted by GitBox <gi...@apache.org>.
RobertIndie merged PR #16287:
URL: https://github.com/apache/pulsar/pull/16287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- commented on a diff in pull request #16287: [improve][broker] Make Namespaces.deleteNamespaceBundle async
Posted by GitBox <gi...@apache.org>.
Technoboy- commented on code in PR #16287:
URL: https://github.com/apache/pulsar/pull/16287#discussion_r916416032
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/v2/Namespaces.java:
##########
@@ -208,13 +208,20 @@ public void deleteNamespace(@Suspended final AsyncResponse asyncResponse, @PathP
@ApiResponse(code = 307, message = "Current broker doesn't serve the namespace"),
@ApiResponse(code = 403, message = "Don't have admin permission"),
@ApiResponse(code = 404, message = "Tenant or cluster or namespace doesn't exist"),
- @ApiResponse(code = 409, message = "Namespace bundle is not empty") })
- public void deleteNamespaceBundle(@PathParam("tenant") String tenant, @PathParam("namespace") String namespace,
- @PathParam("bundle") String bundleRange,
- @QueryParam("force") @DefaultValue("false") boolean force,
- @QueryParam("authoritative") @DefaultValue("false") boolean authoritative) {
+ @ApiResponse(code = 409, message = "Namespace bundle is not empty")})
+ public void deleteNamespaceBundle(@Suspended AsyncResponse response, @PathParam("tenant") String tenant,
+ @PathParam("namespace") String namespace,
+ @PathParam("bundle") String bundleRange,
+ @QueryParam("force") @DefaultValue("false") boolean force,
+ @QueryParam("authoritative") @DefaultValue("false") boolean authoritative) {
validateNamespaceName(tenant, namespace);
- internalDeleteNamespaceBundle(bundleRange, authoritative, force);
+ internalDeleteNamespaceBundleAsync(bundleRange, authoritative, force)
+ .thenRun(() -> response.resume(Response.noContent().build()))
+ .exceptionally(ex -> {
+ log.error("[{}] Failed to delete namespace bundle {}", clientAppId(), namespaceName, ex);
Review Comment:
We have `validateClusterOwnershipAsync` which will redirect the request, so it's better to add `isRedirectException` to filter this exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org