You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2018/10/01 07:41:42 UTC

[GitHub] sdedic opened a new pull request #934: Autoupdated fragment restarts only if its host is already ON

sdedic opened a new pull request #934: Autoupdated fragment restarts only if its host is already ON
URL: https://github.com/apache/incubator-netbeans/pull/934
 
 
   This is a followup to #715 - the AutoUpdate contains code which causes IDE to restart when Fragment module is install although the action is harmless: if the hosting module is not enabled, or is not installed at all, no classloader was created for the module, so it is safe to install fragment and continue with the same VM since no possibly affected classes are linked.
   
   When I was trying to add the logic to AU, I've realized that the current AU catalog for plugin portal does not list necessary fragment-host info  (see [NETBEANS-1297](https://issues.apache.org/jira/browse/NETBEANS-1297), [NETBEANS-1296](https://issues.apache.org/jira/browse/NETBEANS-1296)). But this PR anticipates the generated info will be fixed and processes the manifest entries from AU catalog.
   
   Before the catalog is fixed, this PR adds a check in validation phase, which **updates** the data structures based on the `Info.xml` from the downloaded NBM and determines if the fragment's host is enabled or not. This does not fix missing dependencies (see [NETBEANS-1298](https://issues.apache.org/jira/browse/NETBEANS-1298)), but at least fixes the restart logic.
   
   Basic tests included.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists