You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2015/01/21 21:56:44 UTC
Review Request 30138: LDAP Group sync truncates whitespace in group
name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30138/
-----------------------------------------------------------
Review request for Ambari and Jonathan Hurley.
Bugs: AMBARI-9250
https://issues.apache.org/jira/browse/AMBARI-9250
Repository: ambari
Description
-------
Group sync fails with groups whose names have white space such as 'Unix Systems Engineers' due to the white space being removed.
ambari-server sync-ldap --groups=groups.txt
groups.txt:
Unix Systems Engineers
09:08:06,460 ERROR [pool-2-thread-9] LdapSyncEventResourceProvider:425 - Caught exception running LDAP sync.
org.apache.ambari.server.AmbariException: Couldn't sync LDAP group UnixSystemsEngineers, it doesn't exist
at org.apache.ambari.server.security.ldap.AmbariLdapDataPopulator.synchronizeLdapGroups(AmbariLdapDataPopulator.java:238)
Diffs
-----
ambari-server/src/main/python/ambari-server.py b75611f
ambari-server/src/test/python/TestAmbariServer.py e0b390c
Diff: https://reviews.apache.org/r/30138/diff/
Testing
-------
New unit tests added.
Manual test to verify that spaces in names are not stripped.
All existing tests pass ...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:04 min
[INFO] Finished at: 2015-01-21T14:56:49-05:00
[INFO] Final Memory: 42M/629M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 30138: LDAP Group sync truncates whitespace in
group name
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30138/#review69167
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On Jan. 22, 2015, 6:10 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30138/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 6:10 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9250
> https://issues.apache.org/jira/browse/AMBARI-9250
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Group sync fails with groups whose names have white space such as 'Unix Systems Engineers' due to the white space being removed.
>
>
> ambari-server sync-ldap --groups=groups.txt
>
>
> groups.txt:
> Unix Systems Engineers
>
>
> 09:08:06,460 ERROR [pool-2-thread-9] LdapSyncEventResourceProvider:425 - Caught exception running LDAP sync.
> org.apache.ambari.server.AmbariException: Couldn't sync LDAP group UnixSystemsEngineers, it doesn't exist
> at org.apache.ambari.server.security.ldap.AmbariLdapDataPopulator.synchronizeLdapGroups(AmbariLdapDataPopulator.java:238)
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py b75611f
> ambari-server/src/test/python/TestAmbariServer.py e0b390c
>
> Diff: https://reviews.apache.org/r/30138/diff/
>
>
> Testing
> -------
>
> New unit tests added.
>
> Manual test to verify that spaces in names are not stripped.
>
> All existing tests pass ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:04 min
> [INFO] Finished at: 2015-01-21T14:56:49-05:00
> [INFO] Final Memory: 42M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30138: LDAP Group sync truncates whitespace in
group name
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30138/#review69169
-----------------------------------------------------------
Ship it!
- Jonathan Hurley
On Jan. 22, 2015, 6:10 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30138/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2015, 6:10 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and Nate Cole.
>
>
> Bugs: AMBARI-9250
> https://issues.apache.org/jira/browse/AMBARI-9250
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Group sync fails with groups whose names have white space such as 'Unix Systems Engineers' due to the white space being removed.
>
>
> ambari-server sync-ldap --groups=groups.txt
>
>
> groups.txt:
> Unix Systems Engineers
>
>
> 09:08:06,460 ERROR [pool-2-thread-9] LdapSyncEventResourceProvider:425 - Caught exception running LDAP sync.
> org.apache.ambari.server.AmbariException: Couldn't sync LDAP group UnixSystemsEngineers, it doesn't exist
> at org.apache.ambari.server.security.ldap.AmbariLdapDataPopulator.synchronizeLdapGroups(AmbariLdapDataPopulator.java:238)
>
>
> Diffs
> -----
>
> ambari-server/src/main/python/ambari-server.py b75611f
> ambari-server/src/test/python/TestAmbariServer.py e0b390c
>
> Diff: https://reviews.apache.org/r/30138/diff/
>
>
> Testing
> -------
>
> New unit tests added.
>
> Manual test to verify that spaces in names are not stripped.
>
> All existing tests pass ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 30:04 min
> [INFO] Finished at: 2015-01-21T14:56:49-05:00
> [INFO] Final Memory: 42M/629M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 30138: LDAP Group sync truncates whitespace in
group name
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30138/
-----------------------------------------------------------
(Updated Jan. 22, 2015, 11:10 a.m.)
Review request for Ambari, Jonathan Hurley and Nate Cole.
Bugs: AMBARI-9250
https://issues.apache.org/jira/browse/AMBARI-9250
Repository: ambari
Description
-------
Group sync fails with groups whose names have white space such as 'Unix Systems Engineers' due to the white space being removed.
ambari-server sync-ldap --groups=groups.txt
groups.txt:
Unix Systems Engineers
09:08:06,460 ERROR [pool-2-thread-9] LdapSyncEventResourceProvider:425 - Caught exception running LDAP sync.
org.apache.ambari.server.AmbariException: Couldn't sync LDAP group UnixSystemsEngineers, it doesn't exist
at org.apache.ambari.server.security.ldap.AmbariLdapDataPopulator.synchronizeLdapGroups(AmbariLdapDataPopulator.java:238)
Diffs
-----
ambari-server/src/main/python/ambari-server.py b75611f
ambari-server/src/test/python/TestAmbariServer.py e0b390c
Diff: https://reviews.apache.org/r/30138/diff/
Testing
-------
New unit tests added.
Manual test to verify that spaces in names are not stripped.
All existing tests pass ...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 30:04 min
[INFO] Finished at: 2015-01-21T14:56:49-05:00
[INFO] Final Memory: 42M/629M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower