[GitHub] [arrow-datafusion] Dandandan commented on a change in pull request #334: Add window expr

[GitBox <gi...@apache.org>]

Dandandan commented on a change in pull request #334:
URL: https://github.com/apache/arrow-datafusion/pull/334#discussion_r631927655



##########
File path: datafusion/src/optimizer/hash_build_probe_order.rs
##########
@@ -53,8 +53,8 @@ fn get_num_rows(logical_plan: &LogicalPlan) -> Option<usize> {
             let num_rows_input = get_num_rows(input);
             num_rows_input.map(|rows| std::cmp::min(*limit, rows))
         }
-        LogicalPlan::Aggregate { .. } => {
-            // we cannot yet predict how many rows will be produced by an aggregate because
+        LogicalPlan::Window { .. } | LogicalPlan::Aggregate { .. } => {

Review comment:
       Window has the same nr of rows as the input!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org