You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Dain Sundstrom <da...@iq80.com> on 2006/02/27 17:47:58 UTC
Console patches [was: GERONIMO-1529, GERONIMO-1484, or how to get things included]
On Feb 27, 2006, at 7:15 AM, Jacek Laskowski wrote:
> 2006/2/27, schmidtm@mock-software.de <sc...@mock-software.de>:
>
>> I've created these two items in January:
>
> Hi,
>
> Not that long ago ;)
>
>> GERONIMO-1529 Console should display Geronimo Version
>> GERONIMO-1484 Display username who is logged into the Webconsole
I'm not a console guy, but I think this info be on the footer of
every page like JIRA does
>> now i have a couple of questions around how to get things included
>> since
>> not much happened with them since then:
>
> Perhaps people were busy doing other stuff and missed that one. Not
> that it changes much, but worth to take it into account.
>
>> a) I've provided a fix in the body of the RFE, would it had been
>> better
>> to attach it as a patch?
>
> A patch is the best way to submit changes since it's just a matter of
> review and commit.
The best way is to "attach" a patch file generated with svn diff.
>> b) Can I assign an item to myself?
>
> Yes.
Once you have earned a bit of karma in the community, we can give you
rights to assign JIRA issues to yourself.
>> c) what did i done wrong?
>
> Well, submit the updated patch again and I'm sure it will be processed
> very quickly afterwards. I'll keep an eye on it ;)
Looks good to me.
-dain