You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/11 18:22:33 UTC

[GitHub] [spark] MaxGekk opened a new pull request #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

MaxGekk opened a new pull request #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543
 
 
   ### What changes were proposed in this pull request?
   In the PR, I propose to replace `%` by `Math.floorMod` in `DateTimeUtils.truncTimestamp` for the `SECOND` and `MINUTE` levels.
   
   ### Why are the changes needed?
   This fixes the issue of incorrect truncation of timestamps before the epoch `1970-01-01T00:00:00.000000Z` to the `SECOND` and `MINUTE` levels. For example, timestamps after the epoch are truncated by cutting off the rest part of the timestamp:
   ```sql
   spark-sql> select date_trunc('SECOND', '2020-02-11 00:01:02.123');
   2020-02-11 00:01:02
   ```
   but seconds in the truncated timestamp before the epoch are increased by 1:
   ```sql
   spark-sql> select date_trunc('SECOND', '1960-02-11 00:01:02.123');
   1960-02-11 00:01:03
   ```
   
   ### Does this PR introduce any user-facing change?
   Yes. After the changes, the example statement outputs correct result:
   ```sql
   spark-sql> select date_trunc('SECOND', '1960-02-11 00:01:02.123');
   1960-02-11 00:01:02
   ```
   
   ### How was this patch tested?
   Added new tests to `DateFunctionsSuite`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586871980
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586354181
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] kiszk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
kiszk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585288829
 
 
   This change looks good. In addition, I think that this function has the similar problems in `TRUNC_TO_HOUR` and `TRUNC_TO_DAY`, too.
   
   How about the results with `val df = Seq("1961-04-12 03:01:02.345")...`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585601629
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118337/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584780683
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586833966
 
 
   I've merged https://github.com/apache/spark/pull/27596 , let's see if tests still pass here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586354181
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#discussion_r378658197
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
 ##########
 @@ -828,4 +828,17 @@ class DateFunctionsSuite extends QueryTest with SharedSparkSession {
       TimeZone.setDefault(defaultTz)
     }
   }
+
+  test("truncate timestamps before the epoch to seconds and minutes") {
 
 Review comment:
   Added JIRA id to the test title.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585605859
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23100/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584780696
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23017/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586871980
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585605280
 
 
   **[Test build #118343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118343/testReport)** for PR 27543 at commit [`702e536`](https://github.com/apache/spark/commit/702e536bef884d876012312dd8ff022c3fb2c9fd).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587013795
 
 
   **[Test build #118555 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118555/testReport)** for PR 27543 at commit [`76ca700`](https://github.com/apache/spark/commit/76ca7003b67645f7a99cd0092ebe58cd9a77408f).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  case class WorkerDecommission(`
     * `  case class DecommissionExecutor(executorId: String)  extends CoarseGrainedClusterMessage`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585602548
 
 
   jenkins, retest this, please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585605847
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585323719
 
 
   @kiszk Right, and truncations to hours and days have one more issue of getting time zone offsets. This should be fixed by another PR: https://github.com/apache/spark/pull/27512

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584780696
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23017/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585757073
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585757080
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118343/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586461528
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118438/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587066710
 
 
   @cloud-fan 2.4 **has** the same issue:
   ```sql
   $ spark-sql -S
   20/02/17 08:12:28 INFO SparkContext: Running Spark version 2.4.5
   ...
   spark-sql> select date_trunc('SECOND', '1960-02-11 00:01:02.123');
   1960-02-11 00:01:03
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585601629
 
 
   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118337/
   Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on a change in pull request #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#discussion_r378585490
 
 

 ##########
 File path: sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala
 ##########
 @@ -828,4 +828,17 @@ class DateFunctionsSuite extends QueryTest with SharedSparkSession {
       TimeZone.setDefault(defaultTz)
     }
   }
+
+  test("truncate timestamps before the epoch to seconds and minutes") {
 
 Review comment:
   Can you add the jira number in the prefix?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586871988
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23310/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586354193
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23195/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587014802
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118555/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584896568
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118258/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584896559
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584780038
 
 
   **[Test build #118258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118258/testReport)** for PR 27543 at commit [`e8540b4`](https://github.com/apache/spark/commit/e8540b449cffa3251f606e21385379b84e64070c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584896559
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585601618
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586871988
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23310/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560074
 
 
   **[Test build #118337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118337/testReport)** for PR 27543 at commit [`702e536`](https://github.com/apache/spark/commit/702e536bef884d876012312dd8ff022c3fb2c9fd).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586833991
 
 
   retest it please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587030669
 
 
   to confirm, this bug doesn't exist in 2.4 as we switch the calendar in 3.0 only, right @MaxGekk ?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584895826
 
 
   **[Test build #118258 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118258/testReport)** for PR 27543 at commit [`e8540b4`](https://github.com/apache/spark/commit/e8540b449cffa3251f606e21385379b84e64070c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586460468
 
 
   **[Test build #118438 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118438/testReport)** for PR 27543 at commit [`b7ca731`](https://github.com/apache/spark/commit/b7ca731f0347aa45045809269f21ccb131e1e341).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560359
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585605847
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585605859
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23100/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560074
 
 
   **[Test build #118337 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118337/testReport)** for PR 27543 at commit [`702e536`](https://github.com/apache/spark/commit/702e536bef884d876012312dd8ff022c3fb2c9fd).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584780038
 
 
   **[Test build #118258 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118258/testReport)** for PR 27543 at commit [`e8540b4`](https://github.com/apache/spark/commit/e8540b449cffa3251f606e21385379b84e64070c).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585757080
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118343/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586871404
 
 
   **[Test build #118555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118555/testReport)** for PR 27543 at commit [`76ca700`](https://github.com/apache/spark/commit/76ca7003b67645f7a99cd0092ebe58cd9a77408f).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586352510
 
 
   **[Test build #118438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118438/testReport)** for PR 27543 at commit [`b7ca731`](https://github.com/apache/spark/commit/b7ca731f0347aa45045809269f21ccb131e1e341).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan closed pull request #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587068743
 
 
   cool, thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk edited a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk edited a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587066710
 
 
   @cloud-fan 2.4 **has** the same issue:
   ```sql
   $ spark-sql -S
   20/02/17 08:12:28 INFO SparkContext: Running Spark version 2.4.5
   ...
   spark-sql> select date_trunc('SECOND', '1960-02-11 00:01:02.123');
   1960-02-11 00:01:03
   ```
   I will open a PR to backport the fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586461528
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118438/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587030005
 
 
   thanks, merging to master/3.0!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586352510
 
 
   **[Test build #118438 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118438/testReport)** for PR 27543 at commit [`b7ca731`](https://github.com/apache/spark/commit/b7ca731f0347aa45045809269f21ccb131e1e341).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585756088
 
 
   **[Test build #118343 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118343/testReport)** for PR 27543 at commit [`702e536`](https://github.com/apache/spark/commit/702e536bef884d876012312dd8ff022c3fb2c9fd).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585601618
 
 
   Merged build finished. Test FAILed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585225158
 
 
   @srowen @maropu @kiszk May I ask you to review this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585578247
 
 
   cc: @dongjoon-hyun 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560362
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23094/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585605280
 
 
   **[Test build #118343 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118343/testReport)** for PR 27543 at commit [`702e536`](https://github.com/apache/spark/commit/702e536bef884d876012312dd8ff022c3fb2c9fd).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560359
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587014784
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586461518
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586461518
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584896568
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118258/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587014802
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/118555/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585601421
 
 
   **[Test build #118337 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118337/testReport)** for PR 27543 at commit [`702e536`](https://github.com/apache/spark/commit/702e536bef884d876012312dd8ff022c3fb2c9fd).
    * This patch **fails due to an unknown error code, -9**.
    * This patch merges cleanly.
    * This patch adds no public classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586354193
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23195/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560123
 
 
   > The code itself looks fine. btw, is this not a correctness issue? (trivial though)
   
   I do believe it is a correctness issue. Rounding 2.123 -> 3 doesn't make any sense. This is not arithmetic rounding, and not just cutting off the rest. And this contradicts to truncations to other levels.  

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587014784
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585560362
 
 
   Test PASSed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/23094/
   Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] maropu commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
maropu commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585483599
 
 
   The code itself looks fine. btw, is this not a correctness issue? (trivial though)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-587089224
 
 
   Here is the PR for 2.4: https://github.com/apache/spark/pull/27611

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-585757073
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27543: [SQL][SPARK-30793] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-584780683
 
 
   Merged build finished. Test PASSed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586734623
 
 
   @cloud-fan @HyukjinKwon Please, take a look at the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27543: [SPARK-30793][SQL] Fix truncations of timestamps before the epoch to minutes and seconds
URL: https://github.com/apache/spark/pull/27543#issuecomment-586871404
 
 
   **[Test build #118555 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/118555/testReport)** for PR 27543 at commit [`76ca700`](https://github.com/apache/spark/commit/76ca7003b67645f7a99cd0092ebe58cd9a77408f).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org