[kudu-CR] Don't rely on pending config OpId index for peer promotion

["Alexey Serbin (Code Review)" <ge...@cloudera.org>]

Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/9161 )

Change subject: Don't rely on pending config OpId index for peer promotion
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/9161/3//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/9161/3//COMMIT_MSG@13
PS3, Line 13: remove
nit: removing?


http://gerrit.cloudera.org:8080/#/c/9161/3/src/kudu/consensus/raft_consensus.cc
File src/kudu/consensus/raft_consensus.cc:

http://gerrit.cloudera.org:8080/#/c/9161/3/src/kudu/consensus/raft_consensus.cc@864
PS3, Line 864: req.set_cas_config_opid_index(current_committed_config_index);
Wouldn't it break the CAS semantics?  As I understand, the CAS semantics assumes the configuration change should be done as exactly with the configuration it was planned.  If it happens that the current committed configuration differs, how is it CAS semantics?  Probably, I miss something, but this piece looks suspicious to me.



-- 
To view, visit http://gerrit.cloudera.org:8080/9161
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a033ce16f626458efdb59b1b4dd8450e8591761
Gerrit-Change-Number: 9161
Gerrit-PatchSet: 3
Gerrit-Owner: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 02 Feb 2018 00:18:36 +0000
Gerrit-HasComments: Yes