You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by Sean Busbey <se...@manvsbeard.com> on 2014/03/26 02:06:56 UTC
Review Request 19662: ACCUMULO-2551 adds read only fate operations.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/
-----------------------------------------------------------
Review request for accumulo and kturner.
Bugs: ACCUMULO-2551
https://issues.apache.org/jira/browse/ACCUMULO-2551
Repository: accumulo
Description
-------
Per request in #Accumulo, proposed changes to provide read only access
Diffs
-----
fate/pom.xml 433e61a
fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
Diff: https://reviews.apache.org/r/19662/diff/
Testing
-------
existing and new unit tests run
Thanks,
Sean Busbey
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Sean Busbey <se...@manvsbeard.com>.
> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 34
> > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line34>
> >
> > The store field can be final.
fixed.
> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 37
> > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line37>
> >
> > You could check for null here (with Guava's Preconditions, for instance).
fixed
> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java, line 31
> > <https://reviews.apache.org/r/19662/diff/2/?file=536761#file536761line31>
> >
> > All members of this interface, including the enum, are automatically public, so the "public" modifier should be dropped.
also removed public from methods in modified interfaces.
> On March 26, 2014, 2:51 p.m., Bill Havanki wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java, lines 46-49
> > <https://reviews.apache.org/r/19662/diff/2/?file=536761#file536761line46>
> >
> > Missing @return. (Yeah, missing from the original too.) If it's possible to complete the Javadoc across this class, that would be a welcome addition.
fixed
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38605
-----------------------------------------------------------
On March 26, 2014, 1:06 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:06 a.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38605
-----------------------------------------------------------
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
<https://reviews.apache.org/r/19662/#comment70861>
The store field can be final.
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
<https://reviews.apache.org/r/19662/#comment70862>
You could check for null here (with Guava's Preconditions, for instance).
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java
<https://reviews.apache.org/r/19662/#comment70863>
All members of this interface, including the enum, are automatically public, so the "public" modifier should be dropped.
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java
<https://reviews.apache.org/r/19662/#comment70864>
Missing @return. (Yeah, missing from the original too.) If it's possible to complete the Javadoc across this class, that would be a welcome addition.
- Bill Havanki
On March 25, 2014, 9:06 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 25, 2014, 9:06 p.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38649
-----------------------------------------------------------
ugh. Forgot to update tests for the insertion of wrapping the Repo to make sure htey're read only. updated diff in a few.
- Sean Busbey
On March 26, 2014, 7:05 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 7:05 p.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Bill Havanki <bh...@clouderagovt.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38742
-----------------------------------------------------------
Ship it!
Ship It!
- Bill Havanki
On March 26, 2014, 5:19 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 5:19 p.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review39483
-----------------------------------------------------------
Ship it!
Ship It!
- kturner
On March 26, 2014, 9:19 p.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 9:19 p.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/
-----------------------------------------------------------
(Updated March 26, 2014, 9:19 p.m.)
Review request for accumulo and kturner.
Changes
-------
update tests to deal with changes in ReadOnlyStore
Bugs: ACCUMULO-2551
https://issues.apache.org/jira/browse/ACCUMULO-2551
Repository: accumulo
Description
-------
Per request in #Accumulo, proposed changes to provide read only access
Diffs (updated)
-----
fate/pom.xml 433e61a
fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
Diff: https://reviews.apache.org/r/19662/diff/
Testing
-------
existing and new unit tests run
Thanks,
Sean Busbey
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Sean Busbey <se...@manvsbeard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/
-----------------------------------------------------------
(Updated March 26, 2014, 7:05 p.m.)
Review request for accumulo and kturner.
Changes
-------
updated with feedback from previous reviews.
Bugs: ACCUMULO-2551
https://issues.apache.org/jira/browse/ACCUMULO-2551
Repository: accumulo
Description
-------
Per request in #Accumulo, proposed changes to provide read only access
Diffs (updated)
-----
fate/pom.xml 433e61a
fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
Diff: https://reviews.apache.org/r/19662/diff/
Testing
-------
existing and new unit tests run
Thanks,
Sean Busbey
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by Sean Busbey <se...@manvsbeard.com>.
> On March 26, 2014, 3:10 p.m., kturner wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 57
> > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line57>
> >
> > Seems like this can be cast to Repo after return?
It can. I suppose if you're distrustful enough that you're bothering to use the decorator that's probably an issue. I could make a similarly distrustful decorator for Repo that enforces the ReadOnlyRepo interface?
- Sean
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38610
-----------------------------------------------------------
On March 26, 2014, 1:06 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:06 a.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by ke...@deenlo.com.
> On March 26, 2014, 3:10 p.m., kturner wrote:
> > fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java, line 57
> > <https://reviews.apache.org/r/19662/diff/2/?file=536760#file536760line57>
> >
> > Seems like this can be cast to Repo after return?
>
> Sean Busbey wrote:
> It can. I suppose if you're distrustful enough that you're bothering to use the decorator that's probably an issue. I could make a similarly distrustful decorator for Repo that enforces the ReadOnlyRepo interface?
I think a decorator that limits the ability to cast would be a good thing. Makes it much easier to reason about passing a read only store to other code.
- kturner
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38610
-----------------------------------------------------------
On March 26, 2014, 1:06 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:06 a.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>
Re: Review Request 19662: ACCUMULO-2551 adds read only fate operations.
Posted by ke...@deenlo.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/19662/#review38610
-----------------------------------------------------------
fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
<https://reviews.apache.org/r/19662/#comment70865>
Seems like this can be cast to Repo after return?
- kturner
On March 26, 2014, 1:06 a.m., Sean Busbey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/19662/
> -----------------------------------------------------------
>
> (Updated March 26, 2014, 1:06 a.m.)
>
>
> Review request for accumulo and kturner.
>
>
> Bugs: ACCUMULO-2551
> https://issues.apache.org/jira/browse/ACCUMULO-2551
>
>
> Repository: accumulo
>
>
> Description
> -------
>
> Per request in #Accumulo, proposed changes to provide read only access
>
>
> Diffs
> -----
>
> fate/pom.xml 433e61a
> fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java 0162466
> fate/src/main/java/org/apache/accumulo/fate/Fate.java 9d24b0b
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java PRE-CREATION
> fate/src/main/java/org/apache/accumulo/fate/Repo.java 8bdca10
> fate/src/main/java/org/apache/accumulo/fate/TStore.java 3554064
> fate/src/test/java/org/apache/accumulo/fate/AgeOffStoreTest.java c212649
> fate/src/test/java/org/apache/accumulo/fate/ReadOnlyStoreTest.java PRE-CREATION
> fate/src/test/java/org/apache/accumulo/fate/SimpleStore.java 3b78131
> server/src/main/java/org/apache/accumulo/server/fate/Admin.java 4a5f0bc
> server/src/main/java/org/apache/accumulo/server/master/Master.java 8c4c864
>
> Diff: https://reviews.apache.org/r/19662/diff/
>
>
> Testing
> -------
>
> existing and new unit tests run
>
>
> Thanks,
>
> Sean Busbey
>
>