[jira] Closed: (MJARSIGNER-7) jarsigner plugin to support all "types" of zip files

["Benjamin Bentmann (JIRA)" <ji...@codehaus.org>]

     [ http://jira.codehaus.org/browse/MJARSIGNER-7?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Benjamin Bentmann closed MJARSIGNER-7.
--------------------------------------

         Assignee: Benjamin Bentmann
       Resolution: Fixed
    Fix Version/s: 1.2

Done in [r817056|http://svn.apache.org/viewvc?view=rev&revision=817056].

> jarsigner plugin to support all "types" of zip files
> ----------------------------------------------------
>
>                 Key: MJARSIGNER-7
>                 URL: http://jira.codehaus.org/browse/MJARSIGNER-7
>             Project: Maven 2.x Jar Signer Plugin
>          Issue Type: Wish
>    Affects Versions: 1.1
>         Environment: all
>            Reporter: Martin Scholl
>            Assignee: Benjamin Bentmann
>            Priority: Minor
>             Fix For: 1.2
>
>
> It would be great if the jarsigner plugin was able to sign all zip files, not only those which contain a META-INF folder and/or jar files as the jarsigner command line tool is not limited to "real" jar files. The META-INF folder is created anyway by the jarsigner tool.
> My usecase is that I have some projects that create attached zip assemblies and I would like to sign them, too. I don't want to use e.g. an additional ant task attached to the verification phase, as the signing should be done automatically imho. And I don't want to use "external" signing tools like gpg as it requires a manual installation of that tool whereas the jarsigner is always present (in a JDK).
> Simply replace the isJarFile method like that or similar:
> private boolean isZipFile( final File file )
>     {
>         try
>         {
>             // NOTE: ZipFile.getEntry() might be shorter but is several factors slower on large files
>             ZipInputStream zis = new ZipInputStream( new FileInputStream( file ) );
>             try
>             {
>                 return zis.available() == 1;
>             }
>             finally
>             {
>                 zis.close();
>             }
>         }
>         catch ( Exception e )
>         {
>             // ignore, will fail below
>         }
>         return false;
>     }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira