You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/02/22 05:52:21 UTC

[GitHub] [incubator-kyuubi] yaooqinn opened a new pull request #1957: Skip html comments in merge commit test body from PR desc

yaooqinn opened a new pull request #1957:
URL: https://github.com/apache/incubator-kyuubi/pull/1957


   <!--
   Thanks for sending a pull request!
   
   Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
     2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
   -->
   
   ### _Why are the changes needed?_
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you add a feature, you can talk about the use case of it.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### _How was this patch tested?_
   - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
   - [ ] Add screenshots for manual tests if appropriate
   
   - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1957: Skip html comments in merge commit test body from PR desc

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1957:
URL: https://github.com/apache/incubator-kyuubi/pull/1957#issuecomment-1047456053


   cc @ulysses-you @pan3793 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1957: Skip html comments in merge commit test body from PR desc

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1957:
URL: https://github.com/apache/incubator-kyuubi/pull/1957#issuecomment-1047452012


   new commit message will be much pretty and easy to read, see the example below
   
   ```
   commit aac4a9a9c6198f9a80901647a0e580a63cb1ba07 (HEAD -> PR_TOOL_MERGE_PR_1957_MASTER)
   Author: Kent Yao <ya...@apache.org>
   Date:   Tue Feb 22 13:56:09 2022 +0800
   
       [KYUUBI #1957] Skip html comments in merge commit test body from PR desc
   
       ### _Why are the changes needed?_
   
       ### _How was this patch tested?_
       - [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
   
       - [ ] Add screenshots for manual tests if appropriate
   
       - [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
   
       Closes #1957 from yaooqinn/merge.
   
       Closes #1957
   
       8b3eeffe [Kent Yao] Skip html comments in merge commit test body from PR desc
   
       Authored-by: Kent Yao <ya...@apache.org>
       Signed-off-by: Kent Yao <ya...@apache.org>
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #1957: Skip html comments in merge commit test body from PR desc

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #1957:
URL: https://github.com/apache/incubator-kyuubi/pull/1957#issuecomment-1047463256


   thanks, merged to master


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kyuubi] yaooqinn closed pull request #1957: Skip html comments in merge commit test body from PR desc

Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #1957:
URL: https://github.com/apache/incubator-kyuubi/pull/1957


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org