[GitHub] [calcite] snuyanzin commented on a diff in pull request #3212: [CALCITE-5710] Add ARRAY_MAX, ARRAY_MIN function (enabled in Spark li…

["snuyanzin (via GitHub)" <gi...@apache.org>]

snuyanzin commented on code in PR #3212:
URL: https://github.com/apache/calcite/pull/3212#discussion_r1215265249


##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3870,7 +3870,7 @@ private static AtomicLong getAtomicLong(String key) {
   }
 
   /** Support the ARRAY_COMPACT function. */
-  public static List compact(List list) {
+  public static List arrayCompact(List list) {

Review Comment:
   why are we going to rename public methods?
   that could impact downstream dependencies



##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -3881,13 +3881,41 @@ public static List compact(List list) {
   }
 
   /** Support the ARRAY_DISTINCT function. */
-  public static List distinct(List list) {
+  public static List arrayDistinct(List list) {

Review Comment:
   why are we going to rename public methods?
   that could impact downstream dependencies



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org