You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by gi...@apache.org on 2018/05/24 14:48:35 UTC

[15/51] [partial] hbase-site git commit: Published site at f3d1c021de2264301f68eadb9ef126ff83d7ef53.

http://git-wip-us.apache.org/repos/asf/hbase-site/blob/883dde2f/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html
----------------------------------------------------------------------
diff --git a/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html b/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html
index 78aac51..d08a687 100644
--- a/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html
+++ b/devapidocs/src-html/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.html
@@ -299,421 +299,377 @@
 <span class="sourceLineNo">291</span>    // Hold a lock on the manager instance while moving servers to prevent<a name="line.291"></a>
 <span class="sourceLineNo">292</span>    // another writer changing our state while we are working.<a name="line.292"></a>
 <span class="sourceLineNo">293</span>    synchronized (rsGroupInfoManager) {<a name="line.293"></a>
-<span class="sourceLineNo">294</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.294"></a>
-<span class="sourceLineNo">295</span>        master.getMasterCoprocessorHost().preMoveServers(servers, targetGroupName);<a name="line.295"></a>
-<span class="sourceLineNo">296</span>      }<a name="line.296"></a>
-<span class="sourceLineNo">297</span>      // Presume first server's source group. Later ensure all servers are from this group.<a name="line.297"></a>
-<span class="sourceLineNo">298</span>      Address firstServer = servers.iterator().next();<a name="line.298"></a>
-<span class="sourceLineNo">299</span>      RSGroupInfo srcGrp = rsGroupInfoManager.getRSGroupOfServer(firstServer);<a name="line.299"></a>
-<span class="sourceLineNo">300</span>      if (srcGrp == null) {<a name="line.300"></a>
-<span class="sourceLineNo">301</span>        // Be careful. This exception message is tested for in TestRSGroupsBase...<a name="line.301"></a>
-<span class="sourceLineNo">302</span>        throw new ConstraintException("Source RSGroup for server " + firstServer<a name="line.302"></a>
-<span class="sourceLineNo">303</span>            + " does not exist.");<a name="line.303"></a>
-<span class="sourceLineNo">304</span>      }<a name="line.304"></a>
-<span class="sourceLineNo">305</span>      if (srcGrp.getName().equals(targetGroupName)) {<a name="line.305"></a>
-<span class="sourceLineNo">306</span>        throw new ConstraintException("Target RSGroup " + targetGroupName +<a name="line.306"></a>
-<span class="sourceLineNo">307</span>            " is same as source " + srcGrp + " RSGroup.");<a name="line.307"></a>
-<span class="sourceLineNo">308</span>      }<a name="line.308"></a>
-<span class="sourceLineNo">309</span>      // Only move online servers (when moving from 'default') or servers from other<a name="line.309"></a>
-<span class="sourceLineNo">310</span>      // groups. This prevents bogus servers from entering groups<a name="line.310"></a>
-<span class="sourceLineNo">311</span>      if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName())) {<a name="line.311"></a>
-<span class="sourceLineNo">312</span>        if (srcGrp.getServers().size() &lt;= servers.size()) {<a name="line.312"></a>
-<span class="sourceLineNo">313</span>          throw new ConstraintException(KEEP_ONE_SERVER_IN_DEFAULT_ERROR_MESSAGE);<a name="line.313"></a>
-<span class="sourceLineNo">314</span>        }<a name="line.314"></a>
-<span class="sourceLineNo">315</span>        checkOnlineServersOnly(servers);<a name="line.315"></a>
-<span class="sourceLineNo">316</span>      }<a name="line.316"></a>
-<span class="sourceLineNo">317</span>      // Ensure all servers are of same rsgroup.<a name="line.317"></a>
-<span class="sourceLineNo">318</span>      for (Address server: servers) {<a name="line.318"></a>
-<span class="sourceLineNo">319</span>        String tmpGroup = rsGroupInfoManager.getRSGroupOfServer(server).getName();<a name="line.319"></a>
-<span class="sourceLineNo">320</span>        if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.320"></a>
-<span class="sourceLineNo">321</span>          throw new ConstraintException("Move server request should only come from one source " +<a name="line.321"></a>
-<span class="sourceLineNo">322</span>              "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.322"></a>
-<span class="sourceLineNo">323</span>        }<a name="line.323"></a>
-<span class="sourceLineNo">324</span>      }<a name="line.324"></a>
-<span class="sourceLineNo">325</span>      if (srcGrp.getServers().size() &lt;= servers.size() &amp;&amp; srcGrp.getTables().size() &gt; 0) {<a name="line.325"></a>
-<span class="sourceLineNo">326</span>        throw new ConstraintException("Cannot leave a RSGroup " + srcGrp.getName() +<a name="line.326"></a>
-<span class="sourceLineNo">327</span>            " that contains tables without servers to host them.");<a name="line.327"></a>
-<span class="sourceLineNo">328</span>      }<a name="line.328"></a>
-<span class="sourceLineNo">329</span><a name="line.329"></a>
-<span class="sourceLineNo">330</span>      // MovedServers may be &lt; passed in 'servers'.<a name="line.330"></a>
-<span class="sourceLineNo">331</span>      Set&lt;Address&gt; movedServers = rsGroupInfoManager.moveServers(servers, srcGrp.getName(),<a name="line.331"></a>
-<span class="sourceLineNo">332</span>          targetGroupName);<a name="line.332"></a>
-<span class="sourceLineNo">333</span>      List&lt;Address&gt; editableMovedServers = Lists.newArrayList(movedServers);<a name="line.333"></a>
-<span class="sourceLineNo">334</span>      boolean foundRegionsToMove;<a name="line.334"></a>
-<span class="sourceLineNo">335</span>      do {<a name="line.335"></a>
-<span class="sourceLineNo">336</span>        foundRegionsToMove = false;<a name="line.336"></a>
-<span class="sourceLineNo">337</span>        for (Iterator&lt;Address&gt; iter = editableMovedServers.iterator(); iter.hasNext();) {<a name="line.337"></a>
-<span class="sourceLineNo">338</span>          Address rs = iter.next();<a name="line.338"></a>
-<span class="sourceLineNo">339</span>          // Get regions that are associated with this server.<a name="line.339"></a>
-<span class="sourceLineNo">340</span>          List&lt;RegionInfo&gt; regions = getRegions(rs);<a name="line.340"></a>
+<span class="sourceLineNo">294</span>      // Presume first server's source group. Later ensure all servers are from this group.<a name="line.294"></a>
+<span class="sourceLineNo">295</span>      Address firstServer = servers.iterator().next();<a name="line.295"></a>
+<span class="sourceLineNo">296</span>      RSGroupInfo srcGrp = rsGroupInfoManager.getRSGroupOfServer(firstServer);<a name="line.296"></a>
+<span class="sourceLineNo">297</span>      if (srcGrp == null) {<a name="line.297"></a>
+<span class="sourceLineNo">298</span>        // Be careful. This exception message is tested for in TestRSGroupsBase...<a name="line.298"></a>
+<span class="sourceLineNo">299</span>        throw new ConstraintException("Source RSGroup for server " + firstServer<a name="line.299"></a>
+<span class="sourceLineNo">300</span>            + " does not exist.");<a name="line.300"></a>
+<span class="sourceLineNo">301</span>      }<a name="line.301"></a>
+<span class="sourceLineNo">302</span>      if (srcGrp.getName().equals(targetGroupName)) {<a name="line.302"></a>
+<span class="sourceLineNo">303</span>        throw new ConstraintException("Target RSGroup " + targetGroupName +<a name="line.303"></a>
+<span class="sourceLineNo">304</span>            " is same as source " + srcGrp + " RSGroup.");<a name="line.304"></a>
+<span class="sourceLineNo">305</span>      }<a name="line.305"></a>
+<span class="sourceLineNo">306</span>      // Only move online servers (when moving from 'default') or servers from other<a name="line.306"></a>
+<span class="sourceLineNo">307</span>      // groups. This prevents bogus servers from entering groups<a name="line.307"></a>
+<span class="sourceLineNo">308</span>      if (RSGroupInfo.DEFAULT_GROUP.equals(srcGrp.getName())) {<a name="line.308"></a>
+<span class="sourceLineNo">309</span>        if (srcGrp.getServers().size() &lt;= servers.size()) {<a name="line.309"></a>
+<span class="sourceLineNo">310</span>          throw new ConstraintException(KEEP_ONE_SERVER_IN_DEFAULT_ERROR_MESSAGE);<a name="line.310"></a>
+<span class="sourceLineNo">311</span>        }<a name="line.311"></a>
+<span class="sourceLineNo">312</span>        checkOnlineServersOnly(servers);<a name="line.312"></a>
+<span class="sourceLineNo">313</span>      }<a name="line.313"></a>
+<span class="sourceLineNo">314</span>      // Ensure all servers are of same rsgroup.<a name="line.314"></a>
+<span class="sourceLineNo">315</span>      for (Address server: servers) {<a name="line.315"></a>
+<span class="sourceLineNo">316</span>        String tmpGroup = rsGroupInfoManager.getRSGroupOfServer(server).getName();<a name="line.316"></a>
+<span class="sourceLineNo">317</span>        if (!tmpGroup.equals(srcGrp.getName())) {<a name="line.317"></a>
+<span class="sourceLineNo">318</span>          throw new ConstraintException("Move server request should only come from one source " +<a name="line.318"></a>
+<span class="sourceLineNo">319</span>              "RSGroup. Expecting only " + srcGrp.getName() + " but contains " + tmpGroup);<a name="line.319"></a>
+<span class="sourceLineNo">320</span>        }<a name="line.320"></a>
+<span class="sourceLineNo">321</span>      }<a name="line.321"></a>
+<span class="sourceLineNo">322</span>      if (srcGrp.getServers().size() &lt;= servers.size() &amp;&amp; srcGrp.getTables().size() &gt; 0) {<a name="line.322"></a>
+<span class="sourceLineNo">323</span>        throw new ConstraintException("Cannot leave a RSGroup " + srcGrp.getName() +<a name="line.323"></a>
+<span class="sourceLineNo">324</span>            " that contains tables without servers to host them.");<a name="line.324"></a>
+<span class="sourceLineNo">325</span>      }<a name="line.325"></a>
+<span class="sourceLineNo">326</span><a name="line.326"></a>
+<span class="sourceLineNo">327</span>      // MovedServers may be &lt; passed in 'servers'.<a name="line.327"></a>
+<span class="sourceLineNo">328</span>      Set&lt;Address&gt; movedServers = rsGroupInfoManager.moveServers(servers, srcGrp.getName(),<a name="line.328"></a>
+<span class="sourceLineNo">329</span>          targetGroupName);<a name="line.329"></a>
+<span class="sourceLineNo">330</span>      List&lt;Address&gt; editableMovedServers = Lists.newArrayList(movedServers);<a name="line.330"></a>
+<span class="sourceLineNo">331</span>      boolean foundRegionsToMove;<a name="line.331"></a>
+<span class="sourceLineNo">332</span>      do {<a name="line.332"></a>
+<span class="sourceLineNo">333</span>        foundRegionsToMove = false;<a name="line.333"></a>
+<span class="sourceLineNo">334</span>        for (Iterator&lt;Address&gt; iter = editableMovedServers.iterator(); iter.hasNext();) {<a name="line.334"></a>
+<span class="sourceLineNo">335</span>          Address rs = iter.next();<a name="line.335"></a>
+<span class="sourceLineNo">336</span>          // Get regions that are associated with this server.<a name="line.336"></a>
+<span class="sourceLineNo">337</span>          List&lt;RegionInfo&gt; regions = getRegions(rs);<a name="line.337"></a>
+<span class="sourceLineNo">338</span><a name="line.338"></a>
+<span class="sourceLineNo">339</span>          LOG.info("Moving " + regions.size() + " region(s) from " + rs +<a name="line.339"></a>
+<span class="sourceLineNo">340</span>              " for server move to " + targetGroupName);<a name="line.340"></a>
 <span class="sourceLineNo">341</span><a name="line.341"></a>
-<span class="sourceLineNo">342</span>          LOG.info("Moving " + regions.size() + " region(s) from " + rs +<a name="line.342"></a>
-<span class="sourceLineNo">343</span>              " for server move to " + targetGroupName);<a name="line.343"></a>
-<span class="sourceLineNo">344</span><a name="line.344"></a>
-<span class="sourceLineNo">345</span>          for (RegionInfo region: regions) {<a name="line.345"></a>
-<span class="sourceLineNo">346</span>            // Regions might get assigned from tables of target group so we need to filter<a name="line.346"></a>
-<span class="sourceLineNo">347</span>            if (targetGrp.containsTable(region.getTable())) {<a name="line.347"></a>
-<span class="sourceLineNo">348</span>              continue;<a name="line.348"></a>
-<span class="sourceLineNo">349</span>            }<a name="line.349"></a>
-<span class="sourceLineNo">350</span>            LOG.info("Moving region " + region.getShortNameToLog());<a name="line.350"></a>
-<span class="sourceLineNo">351</span>            this.master.getAssignmentManager().move(region);<a name="line.351"></a>
-<span class="sourceLineNo">352</span>            if (master.getAssignmentManager().getRegionStates().<a name="line.352"></a>
-<span class="sourceLineNo">353</span>                getRegionState(region).isFailedOpen()) {<a name="line.353"></a>
-<span class="sourceLineNo">354</span>              // If region is in FAILED_OPEN state, it won't recover, not without<a name="line.354"></a>
-<span class="sourceLineNo">355</span>              // operator intervention... in hbase-2.0.0 at least. Continue rather<a name="line.355"></a>
-<span class="sourceLineNo">356</span>              // than mark region as 'foundRegionsToMove'.<a name="line.356"></a>
-<span class="sourceLineNo">357</span>              continue;<a name="line.357"></a>
-<span class="sourceLineNo">358</span>            }<a name="line.358"></a>
-<span class="sourceLineNo">359</span>            foundRegionsToMove = true;<a name="line.359"></a>
+<span class="sourceLineNo">342</span>          for (RegionInfo region: regions) {<a name="line.342"></a>
+<span class="sourceLineNo">343</span>            // Regions might get assigned from tables of target group so we need to filter<a name="line.343"></a>
+<span class="sourceLineNo">344</span>            if (targetGrp.containsTable(region.getTable())) {<a name="line.344"></a>
+<span class="sourceLineNo">345</span>              continue;<a name="line.345"></a>
+<span class="sourceLineNo">346</span>            }<a name="line.346"></a>
+<span class="sourceLineNo">347</span>            LOG.info("Moving region " + region.getShortNameToLog());<a name="line.347"></a>
+<span class="sourceLineNo">348</span>            this.master.getAssignmentManager().move(region);<a name="line.348"></a>
+<span class="sourceLineNo">349</span>            if (master.getAssignmentManager().getRegionStates().<a name="line.349"></a>
+<span class="sourceLineNo">350</span>                getRegionState(region).isFailedOpen()) {<a name="line.350"></a>
+<span class="sourceLineNo">351</span>              // If region is in FAILED_OPEN state, it won't recover, not without<a name="line.351"></a>
+<span class="sourceLineNo">352</span>              // operator intervention... in hbase-2.0.0 at least. Continue rather<a name="line.352"></a>
+<span class="sourceLineNo">353</span>              // than mark region as 'foundRegionsToMove'.<a name="line.353"></a>
+<span class="sourceLineNo">354</span>              continue;<a name="line.354"></a>
+<span class="sourceLineNo">355</span>            }<a name="line.355"></a>
+<span class="sourceLineNo">356</span>            foundRegionsToMove = true;<a name="line.356"></a>
+<span class="sourceLineNo">357</span>          }<a name="line.357"></a>
+<span class="sourceLineNo">358</span>          if (!foundRegionsToMove) {<a name="line.358"></a>
+<span class="sourceLineNo">359</span>            iter.remove();<a name="line.359"></a>
 <span class="sourceLineNo">360</span>          }<a name="line.360"></a>
-<span class="sourceLineNo">361</span>          if (!foundRegionsToMove) {<a name="line.361"></a>
-<span class="sourceLineNo">362</span>            iter.remove();<a name="line.362"></a>
-<span class="sourceLineNo">363</span>          }<a name="line.363"></a>
-<span class="sourceLineNo">364</span>        }<a name="line.364"></a>
-<span class="sourceLineNo">365</span>        try {<a name="line.365"></a>
-<span class="sourceLineNo">366</span>          rsGroupInfoManager.wait(1000);<a name="line.366"></a>
-<span class="sourceLineNo">367</span>        } catch (InterruptedException e) {<a name="line.367"></a>
-<span class="sourceLineNo">368</span>          LOG.warn("Sleep interrupted", e);<a name="line.368"></a>
-<span class="sourceLineNo">369</span>          Thread.currentThread().interrupt();<a name="line.369"></a>
-<span class="sourceLineNo">370</span>        }<a name="line.370"></a>
-<span class="sourceLineNo">371</span>      } while (foundRegionsToMove);<a name="line.371"></a>
-<span class="sourceLineNo">372</span><a name="line.372"></a>
-<span class="sourceLineNo">373</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.373"></a>
-<span class="sourceLineNo">374</span>        master.getMasterCoprocessorHost().postMoveServers(servers, targetGroupName);<a name="line.374"></a>
-<span class="sourceLineNo">375</span>      }<a name="line.375"></a>
-<span class="sourceLineNo">376</span>      LOG.info("Move server done: " + srcGrp.getName() + "=&gt;" + targetGroupName);<a name="line.376"></a>
-<span class="sourceLineNo">377</span>    }<a name="line.377"></a>
-<span class="sourceLineNo">378</span>  }<a name="line.378"></a>
-<span class="sourceLineNo">379</span><a name="line.379"></a>
-<span class="sourceLineNo">380</span>  @Override<a name="line.380"></a>
-<span class="sourceLineNo">381</span>  public void moveTables(Set&lt;TableName&gt; tables, String targetGroup) throws IOException {<a name="line.381"></a>
-<span class="sourceLineNo">382</span>    if (tables == null) {<a name="line.382"></a>
-<span class="sourceLineNo">383</span>      throw new ConstraintException("The list of servers cannot be null.");<a name="line.383"></a>
-<span class="sourceLineNo">384</span>    }<a name="line.384"></a>
-<span class="sourceLineNo">385</span>    if (tables.size() &lt; 1) {<a name="line.385"></a>
-<span class="sourceLineNo">386</span>      LOG.debug("moveTables() passed an empty set. Ignoring.");<a name="line.386"></a>
-<span class="sourceLineNo">387</span>      return;<a name="line.387"></a>
-<span class="sourceLineNo">388</span>    }<a name="line.388"></a>
-<span class="sourceLineNo">389</span><a name="line.389"></a>
-<span class="sourceLineNo">390</span>    // Hold a lock on the manager instance while moving servers to prevent<a name="line.390"></a>
-<span class="sourceLineNo">391</span>    // another writer changing our state while we are working.<a name="line.391"></a>
-<span class="sourceLineNo">392</span>    synchronized (rsGroupInfoManager) {<a name="line.392"></a>
-<span class="sourceLineNo">393</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.393"></a>
-<span class="sourceLineNo">394</span>        master.getMasterCoprocessorHost().preMoveTables(tables, targetGroup);<a name="line.394"></a>
+<span class="sourceLineNo">361</span>        }<a name="line.361"></a>
+<span class="sourceLineNo">362</span>        try {<a name="line.362"></a>
+<span class="sourceLineNo">363</span>          rsGroupInfoManager.wait(1000);<a name="line.363"></a>
+<span class="sourceLineNo">364</span>        } catch (InterruptedException e) {<a name="line.364"></a>
+<span class="sourceLineNo">365</span>          LOG.warn("Sleep interrupted", e);<a name="line.365"></a>
+<span class="sourceLineNo">366</span>          Thread.currentThread().interrupt();<a name="line.366"></a>
+<span class="sourceLineNo">367</span>        }<a name="line.367"></a>
+<span class="sourceLineNo">368</span>      } while (foundRegionsToMove);<a name="line.368"></a>
+<span class="sourceLineNo">369</span><a name="line.369"></a>
+<span class="sourceLineNo">370</span>      LOG.info("Move server done: " + srcGrp.getName() + "=&gt;" + targetGroupName);<a name="line.370"></a>
+<span class="sourceLineNo">371</span>    }<a name="line.371"></a>
+<span class="sourceLineNo">372</span>  }<a name="line.372"></a>
+<span class="sourceLineNo">373</span><a name="line.373"></a>
+<span class="sourceLineNo">374</span>  @Override<a name="line.374"></a>
+<span class="sourceLineNo">375</span>  public void moveTables(Set&lt;TableName&gt; tables, String targetGroup) throws IOException {<a name="line.375"></a>
+<span class="sourceLineNo">376</span>    if (tables == null) {<a name="line.376"></a>
+<span class="sourceLineNo">377</span>      throw new ConstraintException("The list of servers cannot be null.");<a name="line.377"></a>
+<span class="sourceLineNo">378</span>    }<a name="line.378"></a>
+<span class="sourceLineNo">379</span>    if (tables.size() &lt; 1) {<a name="line.379"></a>
+<span class="sourceLineNo">380</span>      LOG.debug("moveTables() passed an empty set. Ignoring.");<a name="line.380"></a>
+<span class="sourceLineNo">381</span>      return;<a name="line.381"></a>
+<span class="sourceLineNo">382</span>    }<a name="line.382"></a>
+<span class="sourceLineNo">383</span><a name="line.383"></a>
+<span class="sourceLineNo">384</span>    // Hold a lock on the manager instance while moving servers to prevent<a name="line.384"></a>
+<span class="sourceLineNo">385</span>    // another writer changing our state while we are working.<a name="line.385"></a>
+<span class="sourceLineNo">386</span>    synchronized (rsGroupInfoManager) {<a name="line.386"></a>
+<span class="sourceLineNo">387</span>      if(targetGroup != null) {<a name="line.387"></a>
+<span class="sourceLineNo">388</span>        RSGroupInfo destGroup = rsGroupInfoManager.getRSGroup(targetGroup);<a name="line.388"></a>
+<span class="sourceLineNo">389</span>        if(destGroup == null) {<a name="line.389"></a>
+<span class="sourceLineNo">390</span>          throw new ConstraintException("Target " + targetGroup + " RSGroup does not exist.");<a name="line.390"></a>
+<span class="sourceLineNo">391</span>        }<a name="line.391"></a>
+<span class="sourceLineNo">392</span>        if(destGroup.getServers().size() &lt; 1) {<a name="line.392"></a>
+<span class="sourceLineNo">393</span>          throw new ConstraintException("Target RSGroup must have at least one server.");<a name="line.393"></a>
+<span class="sourceLineNo">394</span>        }<a name="line.394"></a>
 <span class="sourceLineNo">395</span>      }<a name="line.395"></a>
-<span class="sourceLineNo">396</span>      if(targetGroup != null) {<a name="line.396"></a>
-<span class="sourceLineNo">397</span>        RSGroupInfo destGroup = rsGroupInfoManager.getRSGroup(targetGroup);<a name="line.397"></a>
-<span class="sourceLineNo">398</span>        if(destGroup == null) {<a name="line.398"></a>
-<span class="sourceLineNo">399</span>          throw new ConstraintException("Target " + targetGroup + " RSGroup does not exist.");<a name="line.399"></a>
-<span class="sourceLineNo">400</span>        }<a name="line.400"></a>
-<span class="sourceLineNo">401</span>        if(destGroup.getServers().size() &lt; 1) {<a name="line.401"></a>
-<span class="sourceLineNo">402</span>          throw new ConstraintException("Target RSGroup must have at least one server.");<a name="line.402"></a>
+<span class="sourceLineNo">396</span><a name="line.396"></a>
+<span class="sourceLineNo">397</span>      for (TableName table : tables) {<a name="line.397"></a>
+<span class="sourceLineNo">398</span>        String srcGroup = rsGroupInfoManager.getRSGroupOfTable(table);<a name="line.398"></a>
+<span class="sourceLineNo">399</span>        if(srcGroup != null &amp;&amp; srcGroup.equals(targetGroup)) {<a name="line.399"></a>
+<span class="sourceLineNo">400</span>          throw new ConstraintException(<a name="line.400"></a>
+<span class="sourceLineNo">401</span>              "Source RSGroup " + srcGroup + " is same as target " + targetGroup +<a name="line.401"></a>
+<span class="sourceLineNo">402</span>              " RSGroup for table " + table);<a name="line.402"></a>
 <span class="sourceLineNo">403</span>        }<a name="line.403"></a>
-<span class="sourceLineNo">404</span>      }<a name="line.404"></a>
-<span class="sourceLineNo">405</span><a name="line.405"></a>
-<span class="sourceLineNo">406</span>      for (TableName table : tables) {<a name="line.406"></a>
-<span class="sourceLineNo">407</span>        String srcGroup = rsGroupInfoManager.getRSGroupOfTable(table);<a name="line.407"></a>
-<span class="sourceLineNo">408</span>        if(srcGroup != null &amp;&amp; srcGroup.equals(targetGroup)) {<a name="line.408"></a>
-<span class="sourceLineNo">409</span>          throw new ConstraintException(<a name="line.409"></a>
-<span class="sourceLineNo">410</span>              "Source RSGroup " + srcGroup + " is same as target " + targetGroup +<a name="line.410"></a>
-<span class="sourceLineNo">411</span>              " RSGroup for table " + table);<a name="line.411"></a>
-<span class="sourceLineNo">412</span>        }<a name="line.412"></a>
-<span class="sourceLineNo">413</span>        LOG.info("Moving table " + table.getNameAsString() + " to RSGroup " + targetGroup);<a name="line.413"></a>
-<span class="sourceLineNo">414</span>      }<a name="line.414"></a>
-<span class="sourceLineNo">415</span>      rsGroupInfoManager.moveTables(tables, targetGroup);<a name="line.415"></a>
-<span class="sourceLineNo">416</span><a name="line.416"></a>
-<span class="sourceLineNo">417</span>      // targetGroup is null when a table is being deleted. In this case no further<a name="line.417"></a>
-<span class="sourceLineNo">418</span>      // action is required.<a name="line.418"></a>
-<span class="sourceLineNo">419</span>      if (targetGroup != null) {<a name="line.419"></a>
-<span class="sourceLineNo">420</span>        for (TableName table: tables) {<a name="line.420"></a>
-<span class="sourceLineNo">421</span>          if (master.getAssignmentManager().isTableDisabled(table)) {<a name="line.421"></a>
-<span class="sourceLineNo">422</span>            LOG.debug("Skipping move regions because the table" + table + " is disabled.");<a name="line.422"></a>
-<span class="sourceLineNo">423</span>            continue;<a name="line.423"></a>
-<span class="sourceLineNo">424</span>          }<a name="line.424"></a>
-<span class="sourceLineNo">425</span>          for (RegionInfo region :<a name="line.425"></a>
-<span class="sourceLineNo">426</span>              master.getAssignmentManager().getRegionStates().getRegionsOfTable(table)) {<a name="line.426"></a>
-<span class="sourceLineNo">427</span>            LOG.info("Moving region " + region.getShortNameToLog() +<a name="line.427"></a>
-<span class="sourceLineNo">428</span>                " to RSGroup " + targetGroup);<a name="line.428"></a>
-<span class="sourceLineNo">429</span>            master.getAssignmentManager().move(region);<a name="line.429"></a>
-<span class="sourceLineNo">430</span>          }<a name="line.430"></a>
-<span class="sourceLineNo">431</span>        }<a name="line.431"></a>
-<span class="sourceLineNo">432</span>      }<a name="line.432"></a>
-<span class="sourceLineNo">433</span><a name="line.433"></a>
-<span class="sourceLineNo">434</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.434"></a>
-<span class="sourceLineNo">435</span>        master.getMasterCoprocessorHost().postMoveTables(tables, targetGroup);<a name="line.435"></a>
-<span class="sourceLineNo">436</span>      }<a name="line.436"></a>
-<span class="sourceLineNo">437</span>    }<a name="line.437"></a>
-<span class="sourceLineNo">438</span>  }<a name="line.438"></a>
-<span class="sourceLineNo">439</span><a name="line.439"></a>
-<span class="sourceLineNo">440</span>  @Override<a name="line.440"></a>
-<span class="sourceLineNo">441</span>  public void addRSGroup(String name) throws IOException {<a name="line.441"></a>
-<span class="sourceLineNo">442</span>    if (master.getMasterCoprocessorHost() != null) {<a name="line.442"></a>
-<span class="sourceLineNo">443</span>      master.getMasterCoprocessorHost().preAddRSGroup(name);<a name="line.443"></a>
-<span class="sourceLineNo">444</span>    }<a name="line.444"></a>
-<span class="sourceLineNo">445</span>    rsGroupInfoManager.addRSGroup(new RSGroupInfo(name));<a name="line.445"></a>
-<span class="sourceLineNo">446</span>    if (master.getMasterCoprocessorHost() != null) {<a name="line.446"></a>
-<span class="sourceLineNo">447</span>      master.getMasterCoprocessorHost().postAddRSGroup(name);<a name="line.447"></a>
-<span class="sourceLineNo">448</span>    }<a name="line.448"></a>
-<span class="sourceLineNo">449</span>  }<a name="line.449"></a>
-<span class="sourceLineNo">450</span><a name="line.450"></a>
-<span class="sourceLineNo">451</span>  @Override<a name="line.451"></a>
-<span class="sourceLineNo">452</span>  public void removeRSGroup(String name) throws IOException {<a name="line.452"></a>
-<span class="sourceLineNo">453</span>    // Hold a lock on the manager instance while moving servers to prevent<a name="line.453"></a>
-<span class="sourceLineNo">454</span>    // another writer changing our state while we are working.<a name="line.454"></a>
-<span class="sourceLineNo">455</span>    synchronized (rsGroupInfoManager) {<a name="line.455"></a>
-<span class="sourceLineNo">456</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.456"></a>
-<span class="sourceLineNo">457</span>        master.getMasterCoprocessorHost().preRemoveRSGroup(name);<a name="line.457"></a>
-<span class="sourceLineNo">458</span>      }<a name="line.458"></a>
-<span class="sourceLineNo">459</span>      RSGroupInfo rsGroupInfo = rsGroupInfoManager.getRSGroup(name);<a name="line.459"></a>
-<span class="sourceLineNo">460</span>      if (rsGroupInfo == null) {<a name="line.460"></a>
-<span class="sourceLineNo">461</span>        throw new ConstraintException("RSGroup " + name + " does not exist");<a name="line.461"></a>
-<span class="sourceLineNo">462</span>      }<a name="line.462"></a>
-<span class="sourceLineNo">463</span>      int tableCount = rsGroupInfo.getTables().size();<a name="line.463"></a>
-<span class="sourceLineNo">464</span>      if (tableCount &gt; 0) {<a name="line.464"></a>
-<span class="sourceLineNo">465</span>        throw new ConstraintException("RSGroup " + name + " has " + tableCount +<a name="line.465"></a>
-<span class="sourceLineNo">466</span>            " tables; you must remove these tables from the rsgroup before " +<a name="line.466"></a>
-<span class="sourceLineNo">467</span>            "the rsgroup can be removed.");<a name="line.467"></a>
-<span class="sourceLineNo">468</span>      }<a name="line.468"></a>
-<span class="sourceLineNo">469</span>      int serverCount = rsGroupInfo.getServers().size();<a name="line.469"></a>
-<span class="sourceLineNo">470</span>      if (serverCount &gt; 0) {<a name="line.470"></a>
-<span class="sourceLineNo">471</span>        throw new ConstraintException("RSGroup " + name + " has " + serverCount +<a name="line.471"></a>
-<span class="sourceLineNo">472</span>            " servers; you must remove these servers from the RSGroup before" +<a name="line.472"></a>
-<span class="sourceLineNo">473</span>            "the RSGroup can be removed.");<a name="line.473"></a>
+<span class="sourceLineNo">404</span>        LOG.info("Moving table " + table.getNameAsString() + " to RSGroup " + targetGroup);<a name="line.404"></a>
+<span class="sourceLineNo">405</span>      }<a name="line.405"></a>
+<span class="sourceLineNo">406</span>      rsGroupInfoManager.moveTables(tables, targetGroup);<a name="line.406"></a>
+<span class="sourceLineNo">407</span><a name="line.407"></a>
+<span class="sourceLineNo">408</span>      // targetGroup is null when a table is being deleted. In this case no further<a name="line.408"></a>
+<span class="sourceLineNo">409</span>      // action is required.<a name="line.409"></a>
+<span class="sourceLineNo">410</span>      if (targetGroup != null) {<a name="line.410"></a>
+<span class="sourceLineNo">411</span>        for (TableName table: tables) {<a name="line.411"></a>
+<span class="sourceLineNo">412</span>          if (master.getAssignmentManager().isTableDisabled(table)) {<a name="line.412"></a>
+<span class="sourceLineNo">413</span>            LOG.debug("Skipping move regions because the table" + table + " is disabled.");<a name="line.413"></a>
+<span class="sourceLineNo">414</span>            continue;<a name="line.414"></a>
+<span class="sourceLineNo">415</span>          }<a name="line.415"></a>
+<span class="sourceLineNo">416</span>          for (RegionInfo region :<a name="line.416"></a>
+<span class="sourceLineNo">417</span>              master.getAssignmentManager().getRegionStates().getRegionsOfTable(table)) {<a name="line.417"></a>
+<span class="sourceLineNo">418</span>            LOG.info("Moving region " + region.getShortNameToLog() +<a name="line.418"></a>
+<span class="sourceLineNo">419</span>                " to RSGroup " + targetGroup);<a name="line.419"></a>
+<span class="sourceLineNo">420</span>            master.getAssignmentManager().move(region);<a name="line.420"></a>
+<span class="sourceLineNo">421</span>          }<a name="line.421"></a>
+<span class="sourceLineNo">422</span>        }<a name="line.422"></a>
+<span class="sourceLineNo">423</span>      }<a name="line.423"></a>
+<span class="sourceLineNo">424</span>    }<a name="line.424"></a>
+<span class="sourceLineNo">425</span>  }<a name="line.425"></a>
+<span class="sourceLineNo">426</span><a name="line.426"></a>
+<span class="sourceLineNo">427</span>  @Override<a name="line.427"></a>
+<span class="sourceLineNo">428</span>  public void addRSGroup(String name) throws IOException {<a name="line.428"></a>
+<span class="sourceLineNo">429</span>    rsGroupInfoManager.addRSGroup(new RSGroupInfo(name));<a name="line.429"></a>
+<span class="sourceLineNo">430</span>  }<a name="line.430"></a>
+<span class="sourceLineNo">431</span><a name="line.431"></a>
+<span class="sourceLineNo">432</span>  @Override<a name="line.432"></a>
+<span class="sourceLineNo">433</span>  public void removeRSGroup(String name) throws IOException {<a name="line.433"></a>
+<span class="sourceLineNo">434</span>    // Hold a lock on the manager instance while moving servers to prevent<a name="line.434"></a>
+<span class="sourceLineNo">435</span>    // another writer changing our state while we are working.<a name="line.435"></a>
+<span class="sourceLineNo">436</span>    synchronized (rsGroupInfoManager) {<a name="line.436"></a>
+<span class="sourceLineNo">437</span>      RSGroupInfo rsGroupInfo = rsGroupInfoManager.getRSGroup(name);<a name="line.437"></a>
+<span class="sourceLineNo">438</span>      if (rsGroupInfo == null) {<a name="line.438"></a>
+<span class="sourceLineNo">439</span>        throw new ConstraintException("RSGroup " + name + " does not exist");<a name="line.439"></a>
+<span class="sourceLineNo">440</span>      }<a name="line.440"></a>
+<span class="sourceLineNo">441</span>      int tableCount = rsGroupInfo.getTables().size();<a name="line.441"></a>
+<span class="sourceLineNo">442</span>      if (tableCount &gt; 0) {<a name="line.442"></a>
+<span class="sourceLineNo">443</span>        throw new ConstraintException("RSGroup " + name + " has " + tableCount +<a name="line.443"></a>
+<span class="sourceLineNo">444</span>            " tables; you must remove these tables from the rsgroup before " +<a name="line.444"></a>
+<span class="sourceLineNo">445</span>            "the rsgroup can be removed.");<a name="line.445"></a>
+<span class="sourceLineNo">446</span>      }<a name="line.446"></a>
+<span class="sourceLineNo">447</span>      int serverCount = rsGroupInfo.getServers().size();<a name="line.447"></a>
+<span class="sourceLineNo">448</span>      if (serverCount &gt; 0) {<a name="line.448"></a>
+<span class="sourceLineNo">449</span>        throw new ConstraintException("RSGroup " + name + " has " + serverCount +<a name="line.449"></a>
+<span class="sourceLineNo">450</span>            " servers; you must remove these servers from the RSGroup before" +<a name="line.450"></a>
+<span class="sourceLineNo">451</span>            "the RSGroup can be removed.");<a name="line.451"></a>
+<span class="sourceLineNo">452</span>      }<a name="line.452"></a>
+<span class="sourceLineNo">453</span>      for (NamespaceDescriptor ns: master.getClusterSchema().getNamespaces()) {<a name="line.453"></a>
+<span class="sourceLineNo">454</span>        String nsGroup = ns.getConfigurationValue(rsGroupInfo.NAMESPACE_DESC_PROP_GROUP);<a name="line.454"></a>
+<span class="sourceLineNo">455</span>        if (nsGroup != null &amp;&amp;  nsGroup.equals(name)) {<a name="line.455"></a>
+<span class="sourceLineNo">456</span>          throw new ConstraintException("RSGroup " + name + " is referenced by namespace: " +<a name="line.456"></a>
+<span class="sourceLineNo">457</span>              ns.getName());<a name="line.457"></a>
+<span class="sourceLineNo">458</span>        }<a name="line.458"></a>
+<span class="sourceLineNo">459</span>      }<a name="line.459"></a>
+<span class="sourceLineNo">460</span>      rsGroupInfoManager.removeRSGroup(name);<a name="line.460"></a>
+<span class="sourceLineNo">461</span>    }<a name="line.461"></a>
+<span class="sourceLineNo">462</span>  }<a name="line.462"></a>
+<span class="sourceLineNo">463</span><a name="line.463"></a>
+<span class="sourceLineNo">464</span>  @Override<a name="line.464"></a>
+<span class="sourceLineNo">465</span>  public boolean balanceRSGroup(String groupName) throws IOException {<a name="line.465"></a>
+<span class="sourceLineNo">466</span>    ServerManager serverManager = master.getServerManager();<a name="line.466"></a>
+<span class="sourceLineNo">467</span>    AssignmentManager assignmentManager = master.getAssignmentManager();<a name="line.467"></a>
+<span class="sourceLineNo">468</span>    LoadBalancer balancer = master.getLoadBalancer();<a name="line.468"></a>
+<span class="sourceLineNo">469</span><a name="line.469"></a>
+<span class="sourceLineNo">470</span>    synchronized (balancer) {<a name="line.470"></a>
+<span class="sourceLineNo">471</span>      // If balance not true, don't run balancer.<a name="line.471"></a>
+<span class="sourceLineNo">472</span>      if (!((HMaster) master).isBalancerOn()) {<a name="line.472"></a>
+<span class="sourceLineNo">473</span>        return false;<a name="line.473"></a>
 <span class="sourceLineNo">474</span>      }<a name="line.474"></a>
-<span class="sourceLineNo">475</span>      for (NamespaceDescriptor ns: master.getClusterSchema().getNamespaces()) {<a name="line.475"></a>
-<span class="sourceLineNo">476</span>        String nsGroup = ns.getConfigurationValue(rsGroupInfo.NAMESPACE_DESC_PROP_GROUP);<a name="line.476"></a>
-<span class="sourceLineNo">477</span>        if (nsGroup != null &amp;&amp;  nsGroup.equals(name)) {<a name="line.477"></a>
-<span class="sourceLineNo">478</span>          throw new ConstraintException("RSGroup " + name + " is referenced by namespace: " +<a name="line.478"></a>
-<span class="sourceLineNo">479</span>              ns.getName());<a name="line.479"></a>
-<span class="sourceLineNo">480</span>        }<a name="line.480"></a>
-<span class="sourceLineNo">481</span>      }<a name="line.481"></a>
-<span class="sourceLineNo">482</span>      rsGroupInfoManager.removeRSGroup(name);<a name="line.482"></a>
-<span class="sourceLineNo">483</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.483"></a>
-<span class="sourceLineNo">484</span>        master.getMasterCoprocessorHost().postRemoveRSGroup(name);<a name="line.484"></a>
-<span class="sourceLineNo">485</span>      }<a name="line.485"></a>
-<span class="sourceLineNo">486</span>    }<a name="line.486"></a>
-<span class="sourceLineNo">487</span>  }<a name="line.487"></a>
-<span class="sourceLineNo">488</span><a name="line.488"></a>
-<span class="sourceLineNo">489</span>  @Override<a name="line.489"></a>
-<span class="sourceLineNo">490</span>  public boolean balanceRSGroup(String groupName) throws IOException {<a name="line.490"></a>
-<span class="sourceLineNo">491</span>    ServerManager serverManager = master.getServerManager();<a name="line.491"></a>
-<span class="sourceLineNo">492</span>    AssignmentManager assignmentManager = master.getAssignmentManager();<a name="line.492"></a>
-<span class="sourceLineNo">493</span>    LoadBalancer balancer = master.getLoadBalancer();<a name="line.493"></a>
-<span class="sourceLineNo">494</span><a name="line.494"></a>
-<span class="sourceLineNo">495</span>    synchronized (balancer) {<a name="line.495"></a>
-<span class="sourceLineNo">496</span>      // If balance not true, don't run balancer.<a name="line.496"></a>
-<span class="sourceLineNo">497</span>      if (!((HMaster) master).isBalancerOn()) {<a name="line.497"></a>
-<span class="sourceLineNo">498</span>        return false;<a name="line.498"></a>
-<span class="sourceLineNo">499</span>      }<a name="line.499"></a>
-<span class="sourceLineNo">500</span><a name="line.500"></a>
-<span class="sourceLineNo">501</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.501"></a>
-<span class="sourceLineNo">502</span>        master.getMasterCoprocessorHost().preBalanceRSGroup(groupName);<a name="line.502"></a>
-<span class="sourceLineNo">503</span>      }<a name="line.503"></a>
-<span class="sourceLineNo">504</span>      if (getRSGroupInfo(groupName) == null) {<a name="line.504"></a>
-<span class="sourceLineNo">505</span>        throw new ConstraintException("RSGroup does not exist: "+groupName);<a name="line.505"></a>
-<span class="sourceLineNo">506</span>      }<a name="line.506"></a>
-<span class="sourceLineNo">507</span>      // Only allow one balance run at at time.<a name="line.507"></a>
-<span class="sourceLineNo">508</span>      Map&lt;String, RegionState&gt; groupRIT = rsGroupGetRegionsInTransition(groupName);<a name="line.508"></a>
-<span class="sourceLineNo">509</span>      if (groupRIT.size() &gt; 0) {<a name="line.509"></a>
-<span class="sourceLineNo">510</span>        LOG.debug("Not running balancer because " + groupRIT.size() + " region(s) in transition: " +<a name="line.510"></a>
-<span class="sourceLineNo">511</span>          StringUtils.abbreviate(<a name="line.511"></a>
-<span class="sourceLineNo">512</span>              master.getAssignmentManager().getRegionStates().getRegionsInTransition().toString(),<a name="line.512"></a>
-<span class="sourceLineNo">513</span>              256));<a name="line.513"></a>
-<span class="sourceLineNo">514</span>        return false;<a name="line.514"></a>
-<span class="sourceLineNo">515</span>      }<a name="line.515"></a>
-<span class="sourceLineNo">516</span>      if (serverManager.areDeadServersInProgress()) {<a name="line.516"></a>
-<span class="sourceLineNo">517</span>        LOG.debug("Not running balancer because processing dead regionserver(s): " +<a name="line.517"></a>
-<span class="sourceLineNo">518</span>            serverManager.getDeadServers());<a name="line.518"></a>
-<span class="sourceLineNo">519</span>        return false;<a name="line.519"></a>
-<span class="sourceLineNo">520</span>      }<a name="line.520"></a>
-<span class="sourceLineNo">521</span><a name="line.521"></a>
-<span class="sourceLineNo">522</span>      //We balance per group instead of per table<a name="line.522"></a>
-<span class="sourceLineNo">523</span>      List&lt;RegionPlan&gt; plans = new ArrayList&lt;&gt;();<a name="line.523"></a>
-<span class="sourceLineNo">524</span>      for(Map.Entry&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; tableMap:<a name="line.524"></a>
-<span class="sourceLineNo">525</span>          getRSGroupAssignmentsByTable(groupName).entrySet()) {<a name="line.525"></a>
-<span class="sourceLineNo">526</span>        LOG.info("Creating partial plan for table " + tableMap.getKey() + ": "<a name="line.526"></a>
-<span class="sourceLineNo">527</span>            + tableMap.getValue());<a name="line.527"></a>
-<span class="sourceLineNo">528</span>        List&lt;RegionPlan&gt; partialPlans = balancer.balanceCluster(tableMap.getValue());<a name="line.528"></a>
-<span class="sourceLineNo">529</span>        LOG.info("Partial plan for table " + tableMap.getKey() + ": " + partialPlans);<a name="line.529"></a>
-<span class="sourceLineNo">530</span>        if (partialPlans != null) {<a name="line.530"></a>
-<span class="sourceLineNo">531</span>          plans.addAll(partialPlans);<a name="line.531"></a>
-<span class="sourceLineNo">532</span>        }<a name="line.532"></a>
-<span class="sourceLineNo">533</span>      }<a name="line.533"></a>
-<span class="sourceLineNo">534</span>      long startTime = System.currentTimeMillis();<a name="line.534"></a>
-<span class="sourceLineNo">535</span>      boolean balancerRan = !plans.isEmpty();<a name="line.535"></a>
-<span class="sourceLineNo">536</span>      if (balancerRan) {<a name="line.536"></a>
-<span class="sourceLineNo">537</span>        LOG.info("RSGroup balance " + groupName + " starting with plan count: " + plans.size());<a name="line.537"></a>
-<span class="sourceLineNo">538</span>        for (RegionPlan plan: plans) {<a name="line.538"></a>
-<span class="sourceLineNo">539</span>          LOG.info("balance " + plan);<a name="line.539"></a>
-<span class="sourceLineNo">540</span>          assignmentManager.moveAsync(plan);<a name="line.540"></a>
-<span class="sourceLineNo">541</span>        }<a name="line.541"></a>
-<span class="sourceLineNo">542</span>        LOG.info("RSGroup balance " + groupName + " completed after " +<a name="line.542"></a>
-<span class="sourceLineNo">543</span>            (System.currentTimeMillis()-startTime) + " seconds");<a name="line.543"></a>
-<span class="sourceLineNo">544</span>      }<a name="line.544"></a>
-<span class="sourceLineNo">545</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.545"></a>
-<span class="sourceLineNo">546</span>        master.getMasterCoprocessorHost().postBalanceRSGroup(groupName, balancerRan);<a name="line.546"></a>
-<span class="sourceLineNo">547</span>      }<a name="line.547"></a>
-<span class="sourceLineNo">548</span>      return balancerRan;<a name="line.548"></a>
-<span class="sourceLineNo">549</span>    }<a name="line.549"></a>
-<span class="sourceLineNo">550</span>  }<a name="line.550"></a>
-<span class="sourceLineNo">551</span><a name="line.551"></a>
-<span class="sourceLineNo">552</span>  @Override<a name="line.552"></a>
-<span class="sourceLineNo">553</span>  public List&lt;RSGroupInfo&gt; listRSGroups() throws IOException {<a name="line.553"></a>
-<span class="sourceLineNo">554</span>    return rsGroupInfoManager.listRSGroups();<a name="line.554"></a>
-<span class="sourceLineNo">555</span>  }<a name="line.555"></a>
-<span class="sourceLineNo">556</span><a name="line.556"></a>
-<span class="sourceLineNo">557</span>  @Override<a name="line.557"></a>
-<span class="sourceLineNo">558</span>  public RSGroupInfo getRSGroupOfServer(Address hostPort) throws IOException {<a name="line.558"></a>
-<span class="sourceLineNo">559</span>    return rsGroupInfoManager.getRSGroupOfServer(hostPort);<a name="line.559"></a>
-<span class="sourceLineNo">560</span>  }<a name="line.560"></a>
-<span class="sourceLineNo">561</span><a name="line.561"></a>
-<span class="sourceLineNo">562</span>  @Override<a name="line.562"></a>
-<span class="sourceLineNo">563</span>  public void moveServersAndTables(Set&lt;Address&gt; servers, Set&lt;TableName&gt; tables, String targetGroup)<a name="line.563"></a>
-<span class="sourceLineNo">564</span>      throws IOException {<a name="line.564"></a>
-<span class="sourceLineNo">565</span>    if (servers == null || servers.isEmpty()) {<a name="line.565"></a>
-<span class="sourceLineNo">566</span>      throw new ConstraintException("The list of servers to move cannot be null or empty.");<a name="line.566"></a>
-<span class="sourceLineNo">567</span>    }<a name="line.567"></a>
-<span class="sourceLineNo">568</span>    if (tables == null || tables.isEmpty()) {<a name="line.568"></a>
-<span class="sourceLineNo">569</span>      throw new ConstraintException("The list of tables to move cannot be null or empty.");<a name="line.569"></a>
-<span class="sourceLineNo">570</span>    }<a name="line.570"></a>
-<span class="sourceLineNo">571</span><a name="line.571"></a>
-<span class="sourceLineNo">572</span>    //check target group<a name="line.572"></a>
-<span class="sourceLineNo">573</span>    getAndCheckRSGroupInfo(targetGroup);<a name="line.573"></a>
-<span class="sourceLineNo">574</span><a name="line.574"></a>
-<span class="sourceLineNo">575</span>    // Hold a lock on the manager instance while moving servers and tables to prevent<a name="line.575"></a>
-<span class="sourceLineNo">576</span>    // another writer changing our state while we are working.<a name="line.576"></a>
-<span class="sourceLineNo">577</span>    synchronized (rsGroupInfoManager) {<a name="line.577"></a>
-<span class="sourceLineNo">578</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.578"></a>
-<span class="sourceLineNo">579</span>        master.getMasterCoprocessorHost().preMoveServersAndTables(servers, tables, targetGroup);<a name="line.579"></a>
-<span class="sourceLineNo">580</span>      }<a name="line.580"></a>
-<span class="sourceLineNo">581</span>      //check servers and tables status<a name="line.581"></a>
-<span class="sourceLineNo">582</span>      checkServersAndTables(servers, tables, targetGroup);<a name="line.582"></a>
-<span class="sourceLineNo">583</span><a name="line.583"></a>
-<span class="sourceLineNo">584</span>      //Move servers and tables to a new group.<a name="line.584"></a>
-<span class="sourceLineNo">585</span>      String srcGroup = getRSGroupOfServer(servers.iterator().next()).getName();<a name="line.585"></a>
-<span class="sourceLineNo">586</span>      rsGroupInfoManager.moveServersAndTables(servers, tables, srcGroup, targetGroup);<a name="line.586"></a>
-<span class="sourceLineNo">587</span><a name="line.587"></a>
-<span class="sourceLineNo">588</span>      //move regions which should not belong to these tables<a name="line.588"></a>
-<span class="sourceLineNo">589</span>      moveRegionsFromServers(servers, tables, targetGroup);<a name="line.589"></a>
-<span class="sourceLineNo">590</span>      //move regions which should belong to these servers<a name="line.590"></a>
-<span class="sourceLineNo">591</span>      moveRegionsToServers(servers, tables, targetGroup);<a name="line.591"></a>
-<span class="sourceLineNo">592</span><a name="line.592"></a>
-<span class="sourceLineNo">593</span>      if (master.getMasterCoprocessorHost() != null) {<a name="line.593"></a>
-<span class="sourceLineNo">594</span>        master.getMasterCoprocessorHost().postMoveServersAndTables(servers, tables, targetGroup);<a name="line.594"></a>
-<span class="sourceLineNo">595</span>      }<a name="line.595"></a>
-<span class="sourceLineNo">596</span>    }<a name="line.596"></a>
-<span class="sourceLineNo">597</span>    LOG.info("Move servers and tables done. Severs :"<a name="line.597"></a>
-<span class="sourceLineNo">598</span>            + servers + " , Tables : " + tables + " =&gt; " +  targetGroup);<a name="line.598"></a>
-<span class="sourceLineNo">599</span>  }<a name="line.599"></a>
-<span class="sourceLineNo">600</span><a name="line.600"></a>
-<span class="sourceLineNo">601</span>  @Override<a name="line.601"></a>
-<span class="sourceLineNo">602</span>  public void removeServers(Set&lt;Address&gt; servers) throws IOException {<a name="line.602"></a>
-<span class="sourceLineNo">603</span>    {<a name="line.603"></a>
-<span class="sourceLineNo">604</span>      if (servers == null || servers.isEmpty()) {<a name="line.604"></a>
-<span class="sourceLineNo">605</span>        throw new ConstraintException("The set of servers to remove cannot be null or empty.");<a name="line.605"></a>
-<span class="sourceLineNo">606</span>      }<a name="line.606"></a>
-<span class="sourceLineNo">607</span>      // Hold a lock on the manager instance while moving servers to prevent<a name="line.607"></a>
-<span class="sourceLineNo">608</span>      // another writer changing our state while we are working.<a name="line.608"></a>
-<span class="sourceLineNo">609</span>      synchronized (rsGroupInfoManager) {<a name="line.609"></a>
-<span class="sourceLineNo">610</span>        if (master.getMasterCoprocessorHost() != null) {<a name="line.610"></a>
-<span class="sourceLineNo">611</span>          master.getMasterCoprocessorHost().preRemoveServers(servers);<a name="line.611"></a>
-<span class="sourceLineNo">612</span>        }<a name="line.612"></a>
-<span class="sourceLineNo">613</span>        //check the set of servers<a name="line.613"></a>
-<span class="sourceLineNo">614</span>        checkForDeadOrOnlineServers(servers);<a name="line.614"></a>
-<span class="sourceLineNo">615</span>        rsGroupInfoManager.removeServers(servers);<a name="line.615"></a>
-<span class="sourceLineNo">616</span>        if (master.getMasterCoprocessorHost() != null) {<a name="line.616"></a>
-<span class="sourceLineNo">617</span>          master.getMasterCoprocessorHost().postRemoveServers(servers);<a name="line.617"></a>
-<span class="sourceLineNo">618</span>        }<a name="line.618"></a>
-<span class="sourceLineNo">619</span>        LOG.info("Remove decommissioned servers " + servers + " from rsgroup done.");<a name="line.619"></a>
-<span class="sourceLineNo">620</span>      }<a name="line.620"></a>
-<span class="sourceLineNo">621</span>    }<a name="line.621"></a>
-<span class="sourceLineNo">622</span>  }<a name="line.622"></a>
-<span class="sourceLineNo">623</span><a name="line.623"></a>
-<span class="sourceLineNo">624</span>  private Map&lt;String, RegionState&gt; rsGroupGetRegionsInTransition(String groupName)<a name="line.624"></a>
-<span class="sourceLineNo">625</span>      throws IOException {<a name="line.625"></a>
-<span class="sourceLineNo">626</span>    Map&lt;String, RegionState&gt; rit = Maps.newTreeMap();<a name="line.626"></a>
-<span class="sourceLineNo">627</span>    AssignmentManager am = master.getAssignmentManager();<a name="line.627"></a>
-<span class="sourceLineNo">628</span>    for(TableName tableName : getRSGroupInfo(groupName).getTables()) {<a name="line.628"></a>
-<span class="sourceLineNo">629</span>      for(RegionInfo regionInfo: am.getRegionStates().getRegionsOfTable(tableName)) {<a name="line.629"></a>
-<span class="sourceLineNo">630</span>        RegionState state = am.getRegionStates().getRegionTransitionState(regionInfo);<a name="line.630"></a>
-<span class="sourceLineNo">631</span>        if(state != null) {<a name="line.631"></a>
-<span class="sourceLineNo">632</span>          rit.put(regionInfo.getEncodedName(), state);<a name="line.632"></a>
-<span class="sourceLineNo">633</span>        }<a name="line.633"></a>
-<span class="sourceLineNo">634</span>      }<a name="line.634"></a>
-<span class="sourceLineNo">635</span>    }<a name="line.635"></a>
-<span class="sourceLineNo">636</span>    return rit;<a name="line.636"></a>
-<span class="sourceLineNo">637</span>  }<a name="line.637"></a>
-<span class="sourceLineNo">638</span><a name="line.638"></a>
-<span class="sourceLineNo">639</span>  private Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt;<a name="line.639"></a>
-<span class="sourceLineNo">640</span>      getRSGroupAssignmentsByTable(String groupName) throws IOException {<a name="line.640"></a>
-<span class="sourceLineNo">641</span>    Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; result = Maps.newHashMap();<a name="line.641"></a>
-<span class="sourceLineNo">642</span>    RSGroupInfo rsGroupInfo = getRSGroupInfo(groupName);<a name="line.642"></a>
-<span class="sourceLineNo">643</span>    Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; assignments = Maps.newHashMap();<a name="line.643"></a>
-<span class="sourceLineNo">644</span>    for(Map.Entry&lt;RegionInfo, ServerName&gt; entry:<a name="line.644"></a>
-<span class="sourceLineNo">645</span>        master.getAssignmentManager().getRegionStates().getRegionAssignments().entrySet()) {<a name="line.645"></a>
-<span class="sourceLineNo">646</span>      TableName currTable = entry.getKey().getTable();<a name="line.646"></a>
-<span class="sourceLineNo">647</span>      ServerName currServer = entry.getValue();<a name="line.647"></a>
-<span class="sourceLineNo">648</span>      RegionInfo currRegion = entry.getKey();<a name="line.648"></a>
-<span class="sourceLineNo">649</span>      if (rsGroupInfo.getTables().contains(currTable)) {<a name="line.649"></a>
-<span class="sourceLineNo">650</span>        assignments.putIfAbsent(currTable, new HashMap&lt;&gt;());<a name="line.650"></a>
-<span class="sourceLineNo">651</span>        assignments.get(currTable).putIfAbsent(currServer, new ArrayList&lt;&gt;());<a name="line.651"></a>
-<span class="sourceLineNo">652</span>        assignments.get(currTable).get(currServer).add(currRegion);<a name="line.652"></a>
-<span class="sourceLineNo">653</span>      }<a name="line.653"></a>
-<span class="sourceLineNo">654</span>    }<a name="line.654"></a>
-<span class="sourceLineNo">655</span><a name="line.655"></a>
-<span class="sourceLineNo">656</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; serverMap = Maps.newHashMap();<a name="line.656"></a>
-<span class="sourceLineNo">657</span>    for(ServerName serverName: master.getServerManager().getOnlineServers().keySet()) {<a name="line.657"></a>
-<span class="sourceLineNo">658</span>      if(rsGroupInfo.getServers().contains(serverName.getAddress())) {<a name="line.658"></a>
-<span class="sourceLineNo">659</span>        serverMap.put(serverName, Collections.emptyList());<a name="line.659"></a>
-<span class="sourceLineNo">660</span>      }<a name="line.660"></a>
-<span class="sourceLineNo">661</span>    }<a name="line.661"></a>
-<span class="sourceLineNo">662</span><a name="line.662"></a>
-<span class="sourceLineNo">663</span>    // add all tables that are members of the group<a name="line.663"></a>
-<span class="sourceLineNo">664</span>    for(TableName tableName : rsGroupInfo.getTables()) {<a name="line.664"></a>
-<span class="sourceLineNo">665</span>      if(assignments.containsKey(tableName)) {<a name="line.665"></a>
-<span class="sourceLineNo">666</span>        result.put(tableName, new HashMap&lt;&gt;());<a name="line.666"></a>
-<span class="sourceLineNo">667</span>        result.get(tableName).putAll(serverMap);<a name="line.667"></a>
-<span class="sourceLineNo">668</span>        result.get(tableName).putAll(assignments.get(tableName));<a name="line.668"></a>
-<span class="sourceLineNo">669</span>        LOG.debug("Adding assignments for " + tableName + ": " + assignments.get(tableName));<a name="line.669"></a>
-<span class="sourceLineNo">670</span>      }<a name="line.670"></a>
-<span class="sourceLineNo">671</span>    }<a name="line.671"></a>
-<span class="sourceLineNo">672</span><a name="line.672"></a>
-<span class="sourceLineNo">673</span>    return result;<a name="line.673"></a>
-<span class="sourceLineNo">674</span>  }<a name="line.674"></a>
-<span class="sourceLineNo">675</span><a name="line.675"></a>
-<span class="sourceLineNo">676</span>  /**<a name="line.676"></a>
-<span class="sourceLineNo">677</span>   * Check if the set of servers are belong to dead servers list or online servers list.<a name="line.677"></a>
-<span class="sourceLineNo">678</span>   * @param servers servers to remove<a name="line.678"></a>
-<span class="sourceLineNo">679</span>   */<a name="line.679"></a>
-<span class="sourceLineNo">680</span>  private void checkForDeadOrOnlineServers(Set&lt;Address&gt; servers) throws ConstraintException {<a name="line.680"></a>
-<span class="sourceLineNo">681</span>    // This uglyness is because we only have Address, not ServerName.<a name="line.681"></a>
-<span class="sourceLineNo">682</span>    Set&lt;Address&gt; onlineServers = new HashSet&lt;&gt;();<a name="line.682"></a>
-<span class="sourceLineNo">683</span>    List&lt;ServerName&gt; drainingServers = master.getServerManager().getDrainingServersList();<a name="line.683"></a>
-<span class="sourceLineNo">684</span>    for (ServerName server : master.getServerManager().getOnlineServers().keySet()) {<a name="line.684"></a>
-<span class="sourceLineNo">685</span>      // Only online but not decommissioned servers are really online<a name="line.685"></a>
-<span class="sourceLineNo">686</span>      if (!drainingServers.contains(server)) {<a name="line.686"></a>
-<span class="sourceLineNo">687</span>        onlineServers.add(server.getAddress());<a name="line.687"></a>
-<span class="sourceLineNo">688</span>      }<a name="line.688"></a>
-<span class="sourceLineNo">689</span>    }<a name="line.689"></a>
-<span class="sourceLineNo">690</span><a name="line.690"></a>
-<span class="sourceLineNo">691</span>    Set&lt;Address&gt; deadServers = new HashSet&lt;&gt;();<a name="line.691"></a>
-<span class="sourceLineNo">692</span>    for(ServerName server: master.getServerManager().getDeadServers().copyServerNames()) {<a name="line.692"></a>
-<span class="sourceLineNo">693</span>      deadServers.add(server.getAddress());<a name="line.693"></a>
-<span class="sourceLineNo">694</span>    }<a name="line.694"></a>
-<span class="sourceLineNo">695</span><a name="line.695"></a>
-<span class="sourceLineNo">696</span>    for (Address address: servers) {<a name="line.696"></a>
-<span class="sourceLineNo">697</span>      if (onlineServers.contains(address)) {<a name="line.697"></a>
-<span class="sourceLineNo">698</span>        throw new ConstraintException(<a name="line.698"></a>
-<span class="sourceLineNo">699</span>            "Server " + address + " is an online server, not allowed to remove.");<a name="line.699"></a>
-<span class="sourceLineNo">700</span>      }<a name="line.700"></a>
-<span class="sourceLineNo">701</span>      if (deadServers.contains(address)) {<a name="line.701"></a>
-<span class="sourceLineNo">702</span>        throw new ConstraintException(<a name="line.702"></a>
-<span class="sourceLineNo">703</span>            "Server " + address + " is on the dead servers list,"<a name="line.703"></a>
-<span class="sourceLineNo">704</span>                + " Maybe it will come back again, not allowed to remove.");<a name="line.704"></a>
-<span class="sourceLineNo">705</span>      }<a name="line.705"></a>
-<span class="sourceLineNo">706</span>    }<a name="line.706"></a>
-<span class="sourceLineNo">707</span>  }<a name="line.707"></a>
-<span class="sourceLineNo">708</span>}<a name="line.708"></a>
+<span class="sourceLineNo">475</span><a name="line.475"></a>
+<span class="sourceLineNo">476</span>      if (getRSGroupInfo(groupName) == null) {<a name="line.476"></a>
+<span class="sourceLineNo">477</span>        throw new ConstraintException("RSGroup does not exist: "+groupName);<a name="line.477"></a>
+<span class="sourceLineNo">478</span>      }<a name="line.478"></a>
+<span class="sourceLineNo">479</span>      // Only allow one balance run at at time.<a name="line.479"></a>
+<span class="sourceLineNo">480</span>      Map&lt;String, RegionState&gt; groupRIT = rsGroupGetRegionsInTransition(groupName);<a name="line.480"></a>
+<span class="sourceLineNo">481</span>      if (groupRIT.size() &gt; 0) {<a name="line.481"></a>
+<span class="sourceLineNo">482</span>        LOG.debug("Not running balancer because " + groupRIT.size() + " region(s) in transition: " +<a name="line.482"></a>
+<span class="sourceLineNo">483</span>          StringUtils.abbreviate(<a name="line.483"></a>
+<span class="sourceLineNo">484</span>              master.getAssignmentManager().getRegionStates().getRegionsInTransition().toString(),<a name="line.484"></a>
+<span class="sourceLineNo">485</span>              256));<a name="line.485"></a>
+<span class="sourceLineNo">486</span>        return false;<a name="line.486"></a>
+<span class="sourceLineNo">487</span>      }<a name="line.487"></a>
+<span class="sourceLineNo">488</span>      if (serverManager.areDeadServersInProgress()) {<a name="line.488"></a>
+<span class="sourceLineNo">489</span>        LOG.debug("Not running balancer because processing dead regionserver(s): " +<a name="line.489"></a>
+<span class="sourceLineNo">490</span>            serverManager.getDeadServers());<a name="line.490"></a>
+<span class="sourceLineNo">491</span>        return false;<a name="line.491"></a>
+<span class="sourceLineNo">492</span>      }<a name="line.492"></a>
+<span class="sourceLineNo">493</span><a name="line.493"></a>
+<span class="sourceLineNo">494</span>      //We balance per group instead of per table<a name="line.494"></a>
+<span class="sourceLineNo">495</span>      List&lt;RegionPlan&gt; plans = new ArrayList&lt;&gt;();<a name="line.495"></a>
+<span class="sourceLineNo">496</span>      for(Map.Entry&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; tableMap:<a name="line.496"></a>
+<span class="sourceLineNo">497</span>          getRSGroupAssignmentsByTable(groupName).entrySet()) {<a name="line.497"></a>
+<span class="sourceLineNo">498</span>        LOG.info("Creating partial plan for table " + tableMap.getKey() + ": "<a name="line.498"></a>
+<span class="sourceLineNo">499</span>            + tableMap.getValue());<a name="line.499"></a>
+<span class="sourceLineNo">500</span>        List&lt;RegionPlan&gt; partialPlans = balancer.balanceCluster(tableMap.getValue());<a name="line.500"></a>
+<span class="sourceLineNo">501</span>        LOG.info("Partial plan for table " + tableMap.getKey() + ": " + partialPlans);<a name="line.501"></a>
+<span class="sourceLineNo">502</span>        if (partialPlans != null) {<a name="line.502"></a>
+<span class="sourceLineNo">503</span>          plans.addAll(partialPlans);<a name="line.503"></a>
+<span class="sourceLineNo">504</span>        }<a name="line.504"></a>
+<span class="sourceLineNo">505</span>      }<a name="line.505"></a>
+<span class="sourceLineNo">506</span>      long startTime = System.currentTimeMillis();<a name="line.506"></a>
+<span class="sourceLineNo">507</span>      boolean balancerRan = !plans.isEmpty();<a name="line.507"></a>
+<span class="sourceLineNo">508</span>      if (balancerRan) {<a name="line.508"></a>
+<span class="sourceLineNo">509</span>        LOG.info("RSGroup balance " + groupName + " starting with plan count: " + plans.size());<a name="line.509"></a>
+<span class="sourceLineNo">510</span>        for (RegionPlan plan: plans) {<a name="line.510"></a>
+<span class="sourceLineNo">511</span>          LOG.info("balance " + plan);<a name="line.511"></a>
+<span class="sourceLineNo">512</span>          assignmentManager.moveAsync(plan);<a name="line.512"></a>
+<span class="sourceLineNo">513</span>        }<a name="line.513"></a>
+<span class="sourceLineNo">514</span>        LOG.info("RSGroup balance " + groupName + " completed after " +<a name="line.514"></a>
+<span class="sourceLineNo">515</span>            (System.currentTimeMillis()-startTime) + " seconds");<a name="line.515"></a>
+<span class="sourceLineNo">516</span>      }<a name="line.516"></a>
+<span class="sourceLineNo">517</span>      return balancerRan;<a name="line.517"></a>
+<span class="sourceLineNo">518</span>    }<a name="line.518"></a>
+<span class="sourceLineNo">519</span>  }<a name="line.519"></a>
+<span class="sourceLineNo">520</span><a name="line.520"></a>
+<span class="sourceLineNo">521</span>  @Override<a name="line.521"></a>
+<span class="sourceLineNo">522</span>  public List&lt;RSGroupInfo&gt; listRSGroups() throws IOException {<a name="line.522"></a>
+<span class="sourceLineNo">523</span>    return rsGroupInfoManager.listRSGroups();<a name="line.523"></a>
+<span class="sourceLineNo">524</span>  }<a name="line.524"></a>
+<span class="sourceLineNo">525</span><a name="line.525"></a>
+<span class="sourceLineNo">526</span>  @Override<a name="line.526"></a>
+<span class="sourceLineNo">527</span>  public RSGroupInfo getRSGroupOfServer(Address hostPort) throws IOException {<a name="line.527"></a>
+<span class="sourceLineNo">528</span>    return rsGroupInfoManager.getRSGroupOfServer(hostPort);<a name="line.528"></a>
+<span class="sourceLineNo">529</span>  }<a name="line.529"></a>
+<span class="sourceLineNo">530</span><a name="line.530"></a>
+<span class="sourceLineNo">531</span>  @Override<a name="line.531"></a>
+<span class="sourceLineNo">532</span>  public void moveServersAndTables(Set&lt;Address&gt; servers, Set&lt;TableName&gt; tables, String targetGroup)<a name="line.532"></a>
+<span class="sourceLineNo">533</span>      throws IOException {<a name="line.533"></a>
+<span class="sourceLineNo">534</span>    if (servers == null || servers.isEmpty()) {<a name="line.534"></a>
+<span class="sourceLineNo">535</span>      throw new ConstraintException("The list of servers to move cannot be null or empty.");<a name="line.535"></a>
+<span class="sourceLineNo">536</span>    }<a name="line.536"></a>
+<span class="sourceLineNo">537</span>    if (tables == null || tables.isEmpty()) {<a name="line.537"></a>
+<span class="sourceLineNo">538</span>      throw new ConstraintException("The list of tables to move cannot be null or empty.");<a name="line.538"></a>
+<span class="sourceLineNo">539</span>    }<a name="line.539"></a>
+<span class="sourceLineNo">540</span><a name="line.540"></a>
+<span class="sourceLineNo">541</span>    //check target group<a name="line.541"></a>
+<span class="sourceLineNo">542</span>    getAndCheckRSGroupInfo(targetGroup);<a name="line.542"></a>
+<span class="sourceLineNo">543</span><a name="line.543"></a>
+<span class="sourceLineNo">544</span>    // Hold a lock on the manager instance while moving servers and tables to prevent<a name="line.544"></a>
+<span class="sourceLineNo">545</span>    // another writer changing our state while we are working.<a name="line.545"></a>
+<span class="sourceLineNo">546</span>    synchronized (rsGroupInfoManager) {<a name="line.546"></a>
+<span class="sourceLineNo">547</span>      //check servers and tables status<a name="line.547"></a>
+<span class="sourceLineNo">548</span>      checkServersAndTables(servers, tables, targetGroup);<a name="line.548"></a>
+<span class="sourceLineNo">549</span><a name="line.549"></a>
+<span class="sourceLineNo">550</span>      //Move servers and tables to a new group.<a name="line.550"></a>
+<span class="sourceLineNo">551</span>      String srcGroup = getRSGroupOfServer(servers.iterator().next()).getName();<a name="line.551"></a>
+<span class="sourceLineNo">552</span>      rsGroupInfoManager.moveServersAndTables(servers, tables, srcGroup, targetGroup);<a name="line.552"></a>
+<span class="sourceLineNo">553</span><a name="line.553"></a>
+<span class="sourceLineNo">554</span>      //move regions which should not belong to these tables<a name="line.554"></a>
+<span class="sourceLineNo">555</span>      moveRegionsFromServers(servers, tables, targetGroup);<a name="line.555"></a>
+<span class="sourceLineNo">556</span>      //move regions which should belong to these servers<a name="line.556"></a>
+<span class="sourceLineNo">557</span>      moveRegionsToServers(servers, tables, targetGroup);<a name="line.557"></a>
+<span class="sourceLineNo">558</span>    }<a name="line.558"></a>
+<span class="sourceLineNo">559</span>    LOG.info("Move servers and tables done. Severs :"<a name="line.559"></a>
+<span class="sourceLineNo">560</span>            + servers + " , Tables : " + tables + " =&gt; " +  targetGroup);<a name="line.560"></a>
+<span class="sourceLineNo">561</span>  }<a name="line.561"></a>
+<span class="sourceLineNo">562</span><a name="line.562"></a>
+<span class="sourceLineNo">563</span>  @Override<a name="line.563"></a>
+<span class="sourceLineNo">564</span>  public void removeServers(Set&lt;Address&gt; servers) throws IOException {<a name="line.564"></a>
+<span class="sourceLineNo">565</span>    {<a name="line.565"></a>
+<span class="sourceLineNo">566</span>      if (servers == null || servers.isEmpty()) {<a name="line.566"></a>
+<span class="sourceLineNo">567</span>        throw new ConstraintException("The set of servers to remove cannot be null or empty.");<a name="line.567"></a>
+<span class="sourceLineNo">568</span>      }<a name="line.568"></a>
+<span class="sourceLineNo">569</span>      // Hold a lock on the manager instance while moving servers to prevent<a name="line.569"></a>
+<span class="sourceLineNo">570</span>      // another writer changing our state while we are working.<a name="line.570"></a>
+<span class="sourceLineNo">571</span>      synchronized (rsGroupInfoManager) {<a name="line.571"></a>
+<span class="sourceLineNo">572</span>        //check the set of servers<a name="line.572"></a>
+<span class="sourceLineNo">573</span>        checkForDeadOrOnlineServers(servers);<a name="line.573"></a>
+<span class="sourceLineNo">574</span>        rsGroupInfoManager.removeServers(servers);<a name="line.574"></a>
+<span class="sourceLineNo">575</span>        LOG.info("Remove decommissioned servers " + servers + " from rsgroup done.");<a name="line.575"></a>
+<span class="sourceLineNo">576</span>      }<a name="line.576"></a>
+<span class="sourceLineNo">577</span>    }<a name="line.577"></a>
+<span class="sourceLineNo">578</span>  }<a name="line.578"></a>
+<span class="sourceLineNo">579</span><a name="line.579"></a>
+<span class="sourceLineNo">580</span>  private Map&lt;String, RegionState&gt; rsGroupGetRegionsInTransition(String groupName)<a name="line.580"></a>
+<span class="sourceLineNo">581</span>      throws IOException {<a name="line.581"></a>
+<span class="sourceLineNo">582</span>    Map&lt;String, RegionState&gt; rit = Maps.newTreeMap();<a name="line.582"></a>
+<span class="sourceLineNo">583</span>    AssignmentManager am = master.getAssignmentManager();<a name="line.583"></a>
+<span class="sourceLineNo">584</span>    for(TableName tableName : getRSGroupInfo(groupName).getTables()) {<a name="line.584"></a>
+<span class="sourceLineNo">585</span>      for(RegionInfo regionInfo: am.getRegionStates().getRegionsOfTable(tableName)) {<a name="line.585"></a>
+<span class="sourceLineNo">586</span>        RegionState state = am.getRegionStates().getRegionTransitionState(regionInfo);<a name="line.586"></a>
+<span class="sourceLineNo">587</span>        if(state != null) {<a name="line.587"></a>
+<span class="sourceLineNo">588</span>          rit.put(regionInfo.getEncodedName(), state);<a name="line.588"></a>
+<span class="sourceLineNo">589</span>        }<a name="line.589"></a>
+<span class="sourceLineNo">590</span>      }<a name="line.590"></a>
+<span class="sourceLineNo">591</span>    }<a name="line.591"></a>
+<span class="sourceLineNo">592</span>    return rit;<a name="line.592"></a>
+<span class="sourceLineNo">593</span>  }<a name="line.593"></a>
+<span class="sourceLineNo">594</span><a name="line.594"></a>
+<span class="sourceLineNo">595</span>  private Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt;<a name="line.595"></a>
+<span class="sourceLineNo">596</span>      getRSGroupAssignmentsByTable(String groupName) throws IOException {<a name="line.596"></a>
+<span class="sourceLineNo">597</span>    Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; result = Maps.newHashMap();<a name="line.597"></a>
+<span class="sourceLineNo">598</span>    RSGroupInfo rsGroupInfo = getRSGroupInfo(groupName);<a name="line.598"></a>
+<span class="sourceLineNo">599</span>    Map&lt;TableName, Map&lt;ServerName, List&lt;RegionInfo&gt;&gt;&gt; assignments = Maps.newHashMap();<a name="line.599"></a>
+<span class="sourceLineNo">600</span>    for(Map.Entry&lt;RegionInfo, ServerName&gt; entry:<a name="line.600"></a>
+<span class="sourceLineNo">601</span>        master.getAssignmentManager().getRegionStates().getRegionAssignments().entrySet()) {<a name="line.601"></a>
+<span class="sourceLineNo">602</span>      TableName currTable = entry.getKey().getTable();<a name="line.602"></a>
+<span class="sourceLineNo">603</span>      ServerName currServer = entry.getValue();<a name="line.603"></a>
+<span class="sourceLineNo">604</span>      RegionInfo currRegion = entry.getKey();<a name="line.604"></a>
+<span class="sourceLineNo">605</span>      if (rsGroupInfo.getTables().contains(currTable)) {<a name="line.605"></a>
+<span class="sourceLineNo">606</span>        assignments.putIfAbsent(currTable, new HashMap&lt;&gt;());<a name="line.606"></a>
+<span class="sourceLineNo">607</span>        assignments.get(currTable).putIfAbsent(currServer, new ArrayList&lt;&gt;());<a name="line.607"></a>
+<span class="sourceLineNo">608</span>        assignments.get(currTable).get(currServer).add(currRegion);<a name="line.608"></a>
+<span class="sourceLineNo">609</span>      }<a name="line.609"></a>
+<span class="sourceLineNo">610</span>    }<a name="line.610"></a>
+<span class="sourceLineNo">611</span><a name="line.611"></a>
+<span class="sourceLineNo">612</span>    Map&lt;ServerName, List&lt;RegionInfo&gt;&gt; serverMap = Maps.newHashMap();<a name="line.612"></a>
+<span class="sourceLineNo">613</span>    for(ServerName serverName: master.getServerManager().getOnlineServers().keySet()) {<a name="line.613"></a>
+<span class="sourceLineNo">614</span>      if(rsGroupInfo.getServers().contains(serverName.getAddress())) {<a name="line.614"></a>
+<span class="sourceLineNo">615</span>        serverMap.put(serverName, Collections.emptyList());<a name="line.615"></a>
+<span class="sourceLineNo">616</span>      }<a name="line.616"></a>
+<span class="sourceLineNo">617</span>    }<a name="line.617"></a>
+<span class="sourceLineNo">618</span><a name="line.618"></a>
+<span class="sourceLineNo">619</span>    // add all tables that are members of the group<a name="line.619"></a>
+<span class="sourceLineNo">620</span>    for(TableName tableName : rsGroupInfo.getTables()) {<a name="line.620"></a>
+<span class="sourceLineNo">621</span>      if(assignments.containsKey(tableName)) {<a name="line.621"></a>
+<span class="sourceLineNo">622</span>        result.put(tableName, new HashMap&lt;&gt;());<a name="line.622"></a>
+<span class="sourceLineNo">623</span>        result.get(tableName).putAll(serverMap);<a name="line.623"></a>
+<span class="sourceLineNo">624</span>        result.get(tableName).putAll(assignments.get(tableName));<a name="line.624"></a>
+<span class="sourceLineNo">625</span>        LOG.debug("Adding assignments for " + tableName + ": " + assignments.get(tableName));<a name="line.625"></a>
+<span class="sourceLineNo">626</span>      }<a name="line.626"></a>
+<span class="sourceLineNo">627</span>    }<a name="line.627"></a>
+<span class="sourceLineNo">628</span><a name="line.628"></a>
+<span class="sourceLineNo">629</span>    return result;<a name="line.629"></a>
+<span class="sourceLineNo">630</span>  }<a name="line.630"></a>
+<span class="sourceLineNo">631</span><a name="line.631"></a>
+<span class="sourceLineNo">632</span>  /**<a name="line.632"></a>
+<span class="sourceLineNo">633</span>   * Check if the set of servers are belong to dead servers list or online servers list.<a name="line.633"></a>
+<span class="sourceLineNo">634</span>   * @param servers servers to remove<a name="line.634"></a>
+<span class="sourceLineNo">635</span>   */<a name="line.635"></a>
+<span class="sourceLineNo">636</span>  private void checkForDeadOrOnlineServers(Set&lt;Address&gt; servers) throws ConstraintException {<a name="line.636"></a>
+<span class="sourceLineNo">637</span>    // This uglyness is because we only have Address, not ServerName.<a name="line.637"></a>
+<span class="sourceLineNo">638</span>    Set&lt;Address&gt; onlineServers = new HashSet&lt;&gt;();<a name="line.638"></a>
+<span class="sourceLineNo">639</span>    List&lt;ServerName&gt; drainingServers = master.getServerManager().getDrainingServersList();<a name="line.639"></a>
+<span class="sourceLineNo">640</span>    for (ServerName server : master.getServerManager().getOnlineServers().keySet()) {<a name="line.640"></a>
+<span class="sourceLineNo">641</span>      // Only online but not decommissioned servers are really online<a name="line.641"></a>
+<span class="sourceLineNo">642</span>      if (!drainingServers.contains(server)) {<a name="line.642"></a>
+<span class="sourceLineNo">643</span>        onlineServers.add(server.getAddress());<a name="line.643"></a>
+<span class="sourceLineNo">644</span>      }<a name="line.644"></a>
+<span class="sourceLineNo">645</span>    }<a name="line.645"></a>
+<span class="sourceLineNo">646</span><a name="line.646"></a>
+<span class="sourceLineNo">647</span>    Set&lt;Address&gt; deadServers = new HashSet&lt;&gt;();<a name="line.647"></a>
+<span class="sourceLineNo">648</span>    for(ServerName server: master.getServerManager().getDeadServers().copyServerNames()) {<a name="line.648"></a>
+<span class="sourceLineNo">649</span>      deadServers.add(server.getAddress());<a name="line.649"></a>
+<span class="sourceLineNo">650</span>    }<a name="line.650"></a>
+<span class="sourceLineNo">651</span><a name="line.651"></a>
+<span class="sourceLineNo">652</span>    for (Address address: servers) {<a name="line.652"></a>
+<span class="sourceLineNo">653</span>      if (onlineServers.contains(address)) {<a name="line.653"></a>
+<span class="sourceLineNo">654</span>        throw new ConstraintException(<a name="line.654"></a>
+<span class="sourceLineNo">655</span>            "Server " + address + " is an online server, not allowed to remove.");<a name="line.655"></a>
+<span class="sourceLineNo">656</span>      }<a name="line.656"></a>
+<span class="sourceLineNo">657</span>      if (deadServers.contains(address)) {<a name="line.657"></a>
+<span class="sourceLineNo">658</span>        throw new ConstraintException(<a name="line.658"></a>
+<span class="sourceLineNo">659</span>            "Server " + address + " is on the dead servers list,"<a name="line.659"></a>
+<span class="sourceLineNo">660</span>                + " Maybe it will come back again, not allowed to remove.");<a name="line.660"></a>
+<span class="sourceLineNo">661</span>      }<a name="line.661"></a>
+<span class="sourceLineNo">662</span>    }<a name="line.662"></a>
+<span class="sourceLineNo">663</span>  }<a name="line.663"></a>
+<span class="sourceLineNo">664</span>}<a name="line.664"></a>