You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "Joseph Wu (JIRA)" <ji...@apache.org> on 2017/05/15 17:38:04 UTC
[jira] [Commented] (MESOS-7497) Remove CMake anti-pattern of `set(x
"${x} ..")`.
[ https://issues.apache.org/jira/browse/MESOS-7497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010958#comment-16010958 ]
Joseph Wu commented on MESOS-7497:
----------------------------------
{code}commit 4ce689c8e2be386d0086acce63ce5b8bbab6c34b
Author: Andrew Schwartzmeyer <an...@schwartzmeyer.com>
Date: Wed May 10 14:08:06 2017 -0700
CMake: Use `list(APPEND x ...)` over `set(x ${x} ...)`.
This removes a CMake anti-pattern where `set` was used to append to a
variable, instead of the more explicit `list(APPEND)` or
`string(APPEND)` alternatives.
Review: https://reviews.apache.org/r/59156/
{code}
> Remove CMake anti-pattern of `set(x "${x} ..")`.
> ------------------------------------------------
>
> Key: MESOS-7497
> URL: https://issues.apache.org/jira/browse/MESOS-7497
> Project: Mesos
> Issue Type: Improvement
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)