[GitHub] [kafka] ijuma commented on a diff in pull request #12538: MINOR: Fix unexpected request error in kraft shutdown

[GitBox <gi...@apache.org>]

ijuma commented on code in PR #12538:
URL: https://github.com/apache/kafka/pull/12538#discussion_r949628021


##########
core/src/test/java/kafka/testkit/KafkaClusterTestKit.java:
##########
@@ -275,15 +275,15 @@ metaProperties, config, new MetadataRecordSerde(), metadataPartition, KafkaRaftS
                     executorService.shutdownNow();
                     executorService.awaitTermination(5, TimeUnit.MINUTES);
                 }
-                for (ControllerServer controller : controllers.values()) {
-                    controller.shutdown();
-                }
                 for (BrokerServer brokerServer : brokers.values()) {
                     brokerServer.shutdown();
                 }
                 for (KafkaRaftManager<ApiMessageAndVersion> raftManager : raftManagers.values()) {
                     raftManager.shutdown();
                 }
+                for (ControllerServer controller : controllers.values()) {
+                    controller.shutdown();
+                }

Review Comment:
   Is it right that shutdown and startup are in the same order? That is, we don't shutdown in the reverse order of startup?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org