[jira] [Issue Comment Edited] (CASSANDRA-2045) Simplify HH to decrease read load when nodes come back

["Nicholas Telford (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-2045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048625#comment-13048625 ] 

Nicholas Telford edited comment on CASSANDRA-2045 at 6/13/11 4:18 PM:
----------------------------------------------------------------------

* Rebased patch to latest trunk.
* Changed serialization to use cached RowMutation.getSerializedBuffer

I agree with your thoughts on removing the old-style hinting, although I haven't given much thought to the impact on compatibility. As far as I can tell, using my patch removing the old style hinting would be a matter of removing {{hintedMutation.apply();}} from {{RowMutationVerbHandler@63}}. For now, I've left it as-is.

I tried to keep to the CodingStyle as much as possible; is there anything specific you noticed that was wrong?

Btw, the tests I promised have been delayed by nightmarish work-schedule. I'll try to get them sorted ASAP though.

      was (Author: nicktelford):
    * Rebased patch to latest trunk.
* Changed serialization to use cached RowMutation.getSerializedBuffer

I agree with your thoughts on removing the old-style hinting, although I haven't given the impact on compatibility. As far as I can tell, using my patch removing the old style hinting would be a matter of removing {{hintedMutation.apply();}} from {{RowMutationVerbHandler@63}}. For now, I've left it as-is.

I tried to keep to the CodingStyle as much as possible; is there anything specific you noticed that was wrong?

Btw, the tests I promised have been delayed by nightmarish work-schedule. I'll try to get them sorted ASAP though.
  
> Simplify HH to decrease read load when nodes come back
> ------------------------------------------------------
>
>                 Key: CASSANDRA-2045
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-2045
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Chris Goffinet
>            Assignee: Nicholas Telford
>             Fix For: 1.0
>
>         Attachments: CASSANDRA-2045-simplify-hinted-handoff-001.diff, CASSANDRA-2045-simplify-hinted-handoff-002.diff
>
>
> Currently when HH is enabled, hints are stored, and when a node comes back, we begin sending that node data. We do a lookup on the local node for the row to send. To help reduce read load (if a node is offline for long period of time) we should store the data we want forward the node locally instead. We wouldn't have to do any lookups, just take byte[] and send to the destination.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira