You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/11/21 11:46:36 UTC
[GitHub] tinkerpop pull request #755: TINKERPOP-1834: Consider iterate() as a first c...
GitHub user okram opened a pull request:
https://github.com/apache/tinkerpop/pull/755
TINKERPOP-1834: Consider iterate() as a first class step
https://issues.apache.org/jira/browse/TINKERPOP-1834
This is a re-issuing of a previously closed commit. In this model, a `NoneStep` was added as well as a `Traversal.none()`. `Traversal.iterate()` calls `Traversal.none()` if the traversal has not been fully compiled. The benefit of this is that `iterate()` will add a full filter and thus, for remote systems (non-embedded), all data is "iterated" server-side before being sent back to the client. This is a novel play in that `iterate()`, while being a terminal step, is now effecting the bytecode representation.
cc/ @BrynCooke
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1834
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/755.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #755
----
commit 2a957bb586263b2dd70b4db36d1b3c6f87d5596f
Author: Marko A. Rodriguez <ok...@gmail.com>
Date: 2017-11-21T11:44:32Z
Added NoneStep which simply filter(false). Traversal.none() was added which appends the NoneStep. Traversal.iterate() was updated such that if the traversal has not been compiled yet, then Traversal.none() is called to ensure that a full filter is propagated in the bytecode.
----
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by BrynCooke <gi...@git.apache.org>.
Github user BrynCooke commented on the issue:
https://github.com/apache/tinkerpop/pull/755
This looks great. +1 (non binding)
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/755
The standard test suite worked, but I didn't try the full integration test suite (yet). I will start a full Docker build later today.
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/755
VOTE +1
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by okram <gi...@git.apache.org>.
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/755
The bug is in GremlinServer's `TraversalOpProcessor`. I have it fixed. Running integration tests now.
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/755
I'm getting errors in Gremlin Server tests in two separate runs of docker. Did anyone else have problems?
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/755
Yep, integration tests are failing.
```
[ERROR] Failures:
[ERROR] GremlinServerIntegrateTest.shouldGetSideEffectKeysUsingWithRemote:970 expected:<2> but was:<0>
[ERROR] Errors:
[ERROR] GremlinServerIntegrateTest.shouldCloseSideEffectsUsingWithRemote:1000 ? IllegalArgument
[INFO]
[ERROR] Tests run: 203, Failures: 1, Errors: 1, Skipped: 14
```
---
[GitHub] tinkerpop pull request #755: TINKERPOP-1834: Consider iterate() as a first c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/755
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/755
That's better.
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache TinkerPop ................................... SUCCESS [01:32 min]
[INFO] Apache TinkerPop :: Gremlin Shaded ................. SUCCESS [ 17.087 s]
[INFO] Apache TinkerPop :: Gremlin Core ................... SUCCESS [01:37 min]
[INFO] Apache TinkerPop :: Gremlin Test ................... SUCCESS [ 8.780 s]
[INFO] Apache TinkerPop :: TinkerGraph Gremlin ............ SUCCESS [04:34 min]
[INFO] Apache TinkerPop :: Gremlin Groovy ................. SUCCESS [03:59 min]
[INFO] Apache TinkerPop :: Gremlin Driver ................. SUCCESS [01:44 min]
[INFO] Apache TinkerPop :: Neo4j Gremlin .................. SUCCESS [ 1.127 s]
[INFO] Apache TinkerPop :: Gremlin Server ................. SUCCESS [17:08 min]
[INFO] Apache TinkerPop :: Gremlin Python ................. SUCCESS [01:19 min]
[INFO] Apache TinkerPop :: Gremlin.Net .................... SUCCESS [ 12.029 s]
[INFO] Apache TinkerPop :: Gremlin.Net - Source ........... SUCCESS [01:08 min]
[INFO] Apache TinkerPop :: Gremlin.Net - Tests ............ SUCCESS [ 44.917 s]
[INFO] Apache TinkerPop :: Hadoop Gremlin ................. SUCCESS [19:17 min]
[INFO] Apache TinkerPop :: Spark Gremlin .................. SUCCESS [17:15 min]
[INFO] Apache TinkerPop :: Giraph Gremlin ................. SUCCESS [ 01:24 h]
[INFO] Apache TinkerPop :: Gremlin Console ................ SUCCESS [02:37 min]
[INFO] Apache TinkerPop :: Gremlin Archetype .............. SUCCESS [ 0.134 s]
[INFO] Apache TinkerPop :: Archetype - TinkerGraph ........ SUCCESS [ 20.920 s]
[INFO] Apache TinkerPop :: Archetype - Server ............. SUCCESS [ 15.828 s]
[INFO] Apache TinkerPop :: Archetype - DSL ................ SUCCESS [ 6.089 s]
[INFO] Apache TinkerPop :: Gremlin Tools .................. SUCCESS [ 0.306 s]
[INFO] Apache TinkerPop :: Gremlin Benchmark .............. SUCCESS [ 4.824 s]
[INFO] Apache TinkerPop :: Gremlin Coverage ............... SUCCESS [ 0.737 s]
[INFO] Apache TinkerPop :: Gremlin IO Test ................ SUCCESS [ 5.217 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 02:39 h
[INFO] Finished at: 2017-11-28T15:43:00+00:00
[INFO] Final Memory: 180M/1136M
[INFO] ------------------------------------------------------------------------
```
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the issue:
https://github.com/apache/tinkerpop/pull/755
Fails for me with:
`mvn clean install -DskipTests && mvn verify -pl gremlin-server -DskipIntegrationTests=false -DincludeNeo4j`
---
[GitHub] tinkerpop issue #755: TINKERPOP-1834: Consider iterate() as a first class st...
Posted by dkuppitz <gi...@git.apache.org>.
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/755
VOTE: +1
---