You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2023/01/03 05:49:11 UTC
[GitHub] [kafka] ivanyu opened a new pull request, #13066: KAFKA-14485: Move Throttler to storage module
ivanyu opened a new pull request, #13066:
URL: https://github.com/apache/kafka/pull/13066
This commit moves `Throttler` to the `storage` module. It also creates a Java counterpart of `KafkaMetricsGroup`.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu closed pull request #13066: KAFKA-14485: Move Throttler to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu closed pull request #13066: KAFKA-14485: Move Throttler to storage module
URL: https://github.com/apache/kafka/pull/13066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu commented on a diff in pull request #13066: KAFKA-14485: Move Throttler to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu commented on code in PR #13066:
URL: https://github.com/apache/kafka/pull/13066#discussion_r1060293729
##########
storage/src/main/java/org/apache/kafka/server/log/internals/KafkaMetricsGroup.java:
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
Review Comment:
I put this class into the `storage` module for the lack of better place. Probably it needs a separate module, some `utils`. But as it can be moved easily once such a module is introduced, I decided to keep it here for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ivanyu commented on a diff in pull request #13066: KAFKA-14485: Move Throttler to storage module
Posted by GitBox <gi...@apache.org>.
ivanyu commented on code in PR #13066:
URL: https://github.com/apache/kafka/pull/13066#discussion_r1060293729
##########
storage/src/main/java/org/apache/kafka/server/log/internals/KafkaMetricsGroup.java:
##########
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.kafka.server.log.internals;
Review Comment:
I put this class into the `storage` module for the lack of better place. Probably it needs a separate module, some `utils`. But as it can be moved easily once such a module is introduced, I decided to keep it here in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org