You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@ambari.apache.org by venkat sairam <ve...@gmail.com> on 2017/02/13 18:52:43 UTC

Review Request 56606: Allow user to view Tez View after executing query

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/
-----------------------------------------------------------

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19989
    https://issues.apache.org/jira/browse/AMBARI-19989


Repository: ambari


Description
-------

As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.


Diffs
-----

  contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7 
  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
  contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
  contrib/views/hive20/src/main/resources/ui/app/services/job-data.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
  contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 

Diff: https://reviews.apache.org/r/56606/diff/


Testing
-------

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by Pallav Kulshreshtha <pa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165368
-----------------------------------------------------------




contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js (line 24)
<https://reviews.apache.org/r/56606/#comment237200>

    Looks like this is by mistake. pls check.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 306)
<https://reviews.apache.org/r/56606/#comment237201>

    remove un-necessary blank lines.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 536)
<https://reviews.apache.org/r/56606/#comment237202>

    space


- Pallav Kulshreshtha


On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
>     https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
>   contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/job-data.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165373
-----------------------------------------------------------




contrib/views/hive20/src/main/resources/ui/app/adapters/query.js (line 51)
<https://reviews.apache.org/r/56606/#comment237216>

    Please check, seems like typo.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 24)
<https://reviews.apache.org/r/56606/#comment237207>

    spelling?



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 30)
<https://reviews.apache.org/r/56606/#comment237215>

    Move these to the service or function as constants as described in the other comment



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 125)
<https://reviews.apache.org/r/56606/#comment237214>

    Too much of tez related logic inside a route, can you move this to a stateless service or utility functions.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 236)
<https://reviews.apache.org/r/56606/#comment237213>

    In a pure ember way routes should not contain view logic. Please fix this.



contrib/views/hive20/src/main/resources/ui/app/services/job-data.js (line 21)
<https://reviews.apache.org/r/56606/#comment237212>

    Why is this service required?



contrib/views/hive20/src/main/resources/ui/app/services/jobs.js (line 39)
<https://reviews.apache.org/r/56606/#comment237211>

    Why are you sending job model object when _fetchDummyResult() expects the job id.


- DIPAYAN BHOWMICK


On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> -----------------------------------------------------------
> 
> (Updated Feb. 13, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
>     https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/file-resource.js a25adc7 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js e519e64 
>   contrib/views/hive20/src/main/resources/ui/app/components/tez-ui.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/job-data.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 8503715 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/components/tez-ui.hbs PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165924
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 16, 2017, 2:33 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2017, 2:33 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
>     https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by Pallav Kulshreshtha <pa...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review165860
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Feb. 16, 2017, 2:33 p.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> -----------------------------------------------------------
> 
> (Updated Feb. 16, 2017, 2:33 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
>     https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
>   contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by DIPAYAN BHOWMICK <di...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/#review166352
-----------------------------------------------------------


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On Feb. 22, 2017, 11:14 a.m., venkat sairam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56606/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2017, 11:14 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19989
>     https://issues.apache.org/jira/browse/AMBARI-19989
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 4b3e1f9 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js c549d7b 
>   contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5371aa3 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs bf485ca 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9dfa3fa 
> 
> Diff: https://reviews.apache.org/r/56606/diff/
> 
> 
> Testing
> -------
> 
> Manual testing done
> 
> 
> Thanks,
> 
> venkat sairam
> 
>

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by venkat sairam <ve...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/
-----------------------------------------------------------

(Updated Feb. 22, 2017, 11:14 a.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Changes
-------

Tez-UI code moved into seperate route


Bugs: AMBARI-19989
    https://issues.apache.org/jira/browse/AMBARI-19989


Repository: ambari


Description
-------

As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.


Diffs (updated)
-----

  contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 4b3e1f9 
  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js c549d7b 
  contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 5371aa3 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs bf485ca 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/tez-ui.hbs 9dfa3fa 

Diff: https://reviews.apache.org/r/56606/diff/


Testing
-------

Manual testing done


Thanks,

venkat sairam

Re: Review Request 56606: Allow user to view Tez View after executing query

Posted by venkat sairam <ve...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56606/
-----------------------------------------------------------

(Updated Feb. 16, 2017, 2:33 p.m.)


Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav Kulshreshtha, and Rohit Choudhary.


Bugs: AMBARI-19989
    https://issues.apache.org/jira/browse/AMBARI-19989


Repository: ambari


Description
-------

As per the parity with Hive View 1.5, allow user to traverse to tez view from the query page after executing a query.


Diffs (updated)
-----

  contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 88202ff 
  contrib/views/hive20/src/main/resources/ui/app/services/tez-view-info.js PRE-CREATION 
  contrib/views/hive20/src/main/resources/ui/app/styles/app.scss a9c91c7 
  contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 

Diff: https://reviews.apache.org/r/56606/diff/


Testing
-------

Manual testing done


Thanks,

venkat sairam