You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@heron.apache.org by GitBox <gi...@apache.org> on 2020/04/30 23:07:30 UTC
[GitHub] [incubator-heron] Code0x58 opened a new pull request #3521: Make Java optional in CLI and check JAVA_BIN
Code0x58 opened a new pull request #3521:
URL: https://github.com/apache/incubator-heron/pull/3521
This is so you don't have to think about Java when using the CLI if not relying on it for something like uploading a JAR.
It also uses `JAVA_BIN` before `JAVA_HOME`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] nwangtw commented on pull request #3521: Make Java optional in CLI and check JAVA_BIN
Posted by GitBox <gi...@apache.org>.
nwangtw commented on pull request #3521:
URL: https://github.com/apache/incubator-heron/pull/3521#issuecomment-622172307
lgtm. letting java experts to take a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3521: Make Java optional in CLI and check JAVA_BIN
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3521:
URL: https://github.com/apache/incubator-heron/pull/3521#issuecomment-622194293
I'm no expert, but it looks good to me
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] Code0x58 commented on pull request #3521: Make Java optional in CLI and check JAVA_BIN
Posted by GitBox <gi...@apache.org>.
Code0x58 commented on pull request #3521:
URL: https://github.com/apache/incubator-heron/pull/3521#issuecomment-622196864
I made an amendment to use `Status.InvocationError` instead of `Status.HeronError`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-heron] joshfischer1108 commented on pull request #3521: Make Java optional in CLI and check JAVA_BIN
Posted by GitBox <gi...@apache.org>.
joshfischer1108 commented on pull request #3521:
URL: https://github.com/apache/incubator-heron/pull/3521#issuecomment-622405453
@Code0x58 It looks like there are some Python linting issues that are breaking the build. Would mind fixing those before we merge?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org