You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2023/01/11 19:18:55 UTC

[GitHub] [streampipes] tenthe commented on pull request #1079: test: [#955] Add cypress test for api docs

tenthe commented on PR #1079:
URL: https://github.com/apache/streampipes/pull/1079#issuecomment-1379369500

   Hi @smlabt,
   thanks a lot for providing the test case. 
   Was it hard to setup cypress for the tests? Is there anything we can improve?
   
   I have one minor comment regarding the PR. Can you use add the `data-cy` property to the button (e.g.`data-cy=view-api-docs-btn`).
   If you use the data-cy property you can select the button with `cy.dataCy('view-api-docs-btn').click()`.
   With this change we have no dependency on the text of the button


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org