You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Kirk Lund (Jira)" <ji...@apache.org> on 2021/04/26 17:02:00 UTC

[jira] [Created] (GEODE-9195) Remove redundant local locking from PartitionedRegionClear

Kirk Lund created GEODE-9195:
--------------------------------

             Summary: Remove redundant local locking from PartitionedRegionClear
                 Key: GEODE-9195
                 URL: https://issues.apache.org/jira/browse/GEODE-9195
             Project: Geode
          Issue Type: Bug
          Components: regions
            Reporter: Kirk Lund


Existing behavior:
PR clear employs two different locking behavior based on the presence of client subscription and cache-listeners. If there is no subscription or cache-listener it takes the bucket locks on local nodes else it will send a message to take locks on all buckets before doing the clear.

Expected behavior:
To keep the code/behavior simple, PR clear should employ single locking behavior. Now that PR clear acquires a global lock, it no longer needs to acquire local locks on all buckets before doing clear.

Solution:
Remove the logic taking lock in individual nodes in:
{noformat}
DistributedRegion.obtainWriteLocksForClear()
{noformat}
Remove:
{noformat}
if (!localLockedAlready) {
  lockLocallyForClear(getDistributionManager(), getMyId(), regionEvent);
}
{noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)